+1 Good job..

On Fri, Mar 30, 2012 at 9:51 PM, Afkham Azeez <[email protected]> wrote:

> Nice work Pradeeban. Thanks for taking up this task & fixing all these
> problems which were lingering for some time.
>
> Thanks
> Azeez
>
> On Fri, Mar 30, 2012 at 8:52 PM, Kathiravelu Pradeeban <[email protected]
> > wrote:
>
>> The attached patch fixes all the maven3 warnings and bad practices found
>> in products/pom.xml's. Will commit it after finishing this full build with
>> tests.
>>
>> Regards,
>> Pradeeban.
>>
>>
>> On Fri, Mar 30, 2012 at 3:47 PM, Kathiravelu Pradeeban <
>> [email protected]> wrote:
>>
>>> Also to avoid declaring the dependencies and versions multiple times,
>>> where there exists dependencies defined multiple times in a pom with
>>> different versions.
>>> I have already fixed all these maven3 violations. Will commit these
>>> after building with tests. So do *NOT* work on fixing these now. Just
>>> mentioning to the list for the completeness.
>>>
>>> For example, I can see the below, in many of the modules/distribution
>>> poms.
>>>
>>> *            <plugin>
>>>                 <groupId>org.apache.maven.plugins</groupId>
>>>                 <artifactId>maven-antrun-plugin</artifactId>
>>>                 <version>1.1</version>
>>>                 <executions>
>>>                     <execution>
>>>                         <id>extract-docs-from-components</id>
>>>                         <phase>package</phase>
>>>                         <goals>
>>>                             <goal>run</goal>
>>>                         </goals>
>>>                         <configuration>
>>>                             <tasks>
>>>         ....................................................... ...
>>>                             </tasks>
>>>                         </configuration>
>>>                     </execution>
>>>                 </executions>
>>>             </plugin>
>>>
>>>             <plugin>
>>>                 <groupId>org.apache.maven.plugins</groupId>
>>>                 <artifactId>maven-antrun-plugin</artifactId>
>>>                 <version>1.1</version>
>>>                 <executions>
>>>                     <execution>
>>>                         <id>clean_target</id>
>>>                         <phase>install</phase>
>>>                         <configuration>
>>>                             <tasks>
>>>         ....................................................... ...
>>>                             </tasks>
>>>                         </configuration>
>>>                         <goals>
>>>                             <goal>run</goal>
>>>                         </goals>
>>>                     </execution>
>>>                 </executions>
>>>             </plugin>
>>>
>>> *Which actually should have been defined like this.
>>>
>>> *            <plugin>
>>>                 <groupId>org.apache.maven.plugins</groupId>
>>>                 <artifactId>maven-antrun-plugin</artifactId>
>>>                 <version>1.1</version>
>>>                 <executions>
>>>                     <execution>
>>>                         <id>extract-docs-from-components</id>
>>>                         <phase>package</phase>
>>>                         <goals>
>>>                             <goal>run</goal>
>>>                         </goals>
>>>                         <configuration>
>>>                             <tasks>
>>>         ....................................................... ...
>>>                             </tasks>
>>>                         </configuration>
>>>                     </execution>
>>>                     <execution>
>>>                         <id>clean_target</id>
>>>                         <phase>install</phase>
>>>                         <configuration>
>>>                             <tasks>
>>>         ....................................................... ...
>>>                             </tasks>
>>>                         </configuration>
>>>                         <goals>
>>>                             <goal>run</goal>
>>>                         </goals>
>>>                     </execution>
>>>                 </executions>
>>>             </plugin>
>>> *
>>> Thank you.
>>> Regards,
>>> Pradeeban.
>>> --
>>> Kathiravelu Pradeeban.
>>> Software Engineer.
>>> Cloud Technologies Team.
>>> WSO2 Inc.
>>>
>>> Blog: [Llovizna] http://kkpradeeban.blogspot.com/
>>> M: +94 776 477 976
>>>
>>>
>>
>>
>> --
>> Kathiravelu Pradeeban.
>> Software Engineer.
>> Cloud Technologies Team.
>> WSO2 Inc.
>>
>> Blog: [Llovizna] http://kkpradeeban.blogspot.com/
>> M: +94 776 477 976
>>
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Afkham Azeez*
> Director of Architecture; WSO2, Inc.; http://wso2.com
> Member; Apache Software Foundation; http://www.apache.org/
> * <http://www.apache.org/>**
> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
> *
> *
> *Lean . Enterprise . Middleware*
>
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Isuru Suriarachchi
Technical Lead
WSO2 Inc. http://wso2.com
email : [email protected]
blog : http://isurues.wordpress.com/

lean . enterprise . middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to