I have fixed it to the point below, using Sonar way with FindBugs profile. Need to do some code reviews where CC is high and NCSS is high.
Also, this code need loads of unit testing. Violations 40 <http://localhost:9000/drilldown/violations/org.wso2.carbon:jaggery>[image: -2-green-small] Rules compliance 97.4%<http://localhost:9000/drilldown/measures/168?highlight=weighted_violations&metric=weighted_violations>[image: 2-green-small] On Wed, Apr 4, 2012 at 5:16 AM, Samisa Abeysinghe <[email protected]> wrote: > Folks, > I have fixed loads of Sonar & FindBugs reported issues on Jaggery > component. > > The code compiles but I might have broken some functionality here and > there. This is due to lack of unit tests (there is no way I can verify the > tests as there are no unit tests) > > In case functionality is broken, please talk to me, without reverting > to buggy code again. This is because, I have fixed many serious > issues including file closings not handled etc. I am still in the process > of fixing. > > Thanks, > Samisa... > > Samisa Abeysinghe > VP Engineering > WSO2 Inc. > http://wso2.com > http://wso2.org > > Thanks, Samisa... Samisa Abeysinghe VP Engineering WSO2 Inc. http://wso2.com http://wso2.org
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
