And also it seems native File API is been used which is heavily platform
dependent. Its's better to use commons FileUtils.
http://commons.apache.org/io/apidocs/org/apache/commons/io/FileUtils.html

Rajika

On Thu, Apr 5, 2012 at 12:28 PM, Afkham Azeez <[email protected]> wrote:

> Not really related to this error, but this is an example of not following
> logging best practices. During my WSO2 Software Development Process
> presentation I did for the new batch, I stressed on the importance of
> logging all contextual information when logging errors. This has not been
> followed in the case of at least AbstractFilePersistenceManager.  We just
> have a message "java.io.IOException: No such file or directory". At least
> you could have printed the name of the file. Also, I see a yellow warning
> bar at line 63 in IDEA where the code reads "f.createNewFile(); //creates
> a file only if it does not exist". Please do not ignore such warnings &
> follow all best practices.
>
> On Thu, Apr 5, 2012 at 12:04 PM, Lalaji Sureshika <[email protected]> wrote:
>
>> AbstractFilePersistenceManager
>
>
>
>
> --
> *Afkham Azeez*
> Director of Architecture; WSO2, Inc.; http://wso2.com
> Member; Apache Software Foundation; http://www.apache.org/
> * <http://www.apache.org/>**
> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
> *
> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>
> *
> *
> *Lean . Enterprise . Middleware*
>
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to