Hi Lakmali, Good work! .. Also for the performance comparison, I guess you've used only big messages to test it, you should also test it with smaller messages to get a much higher TPS to check whether other parts are not affected.
Cheers, Anjana. On Thu, Apr 19, 2012 at 5:48 PM, Lakmali Baminiwatta <[email protected]>wrote: > Hi, > > A performance comparison was done between the improved smooks mediator and > the current smooks mediator. According to the test results there was no > considerable difference in performance between two mediators. I have shared > a doc [1] with the complete performance test information with results. > > Further changes were done to the code as discussed in the review. > > [1] > https://docs.google.com/a/wso2.com/document/d/1N2uAxA0G-zmGFgSP6K-AVNtHZVZBZxvIrOiJwu57Ds4/edit > > Thanks, > Lakmali > > > On Thu, Apr 19, 2012 at 5:47 PM, Lakmali Baminiwatta <[email protected]>wrote: > >> Hi, >> >> Here are the review notes >> >> >> 1. Allow to result a Java output even when Smooks is using JPA >> persistence execution. >> 2. Method name resizeBuffer() in ElementOutputStream class is >> confusing. Therefore add a more clarified comment. >> 3. Streaming code is complex, hence add more comments. >> 4. Create the EntityManager object only once. >> 5. Change new_element variable name >> 6. Handle errors when committing the transaction. (RollBack when an >> exception occurred.) >> 7. Do a performance comparison between the current Smooks mediator >> and improved mediator. >> >> >> regards, >> Lakmali >> > > > -- > Lakmali Baminiwatta* > * > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > mobile: +94 71 2335936 > * > * > > -- *Anjana Fernando* Senior Software Engineer WSO2 Inc. | http://wso2.com lean . enterprise . middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
