On Fri, Apr 20, 2012 at 11:28 AM, Subash Chaturanga <[email protected]> wrote:
> > > On Fri, Apr 20, 2012 at 10:30 AM, Afkham Azeez <[email protected]> wrote: > >> >> >> On Fri, Apr 20, 2012 at 8:50 AM, Vijitha Kumara <[email protected]> wrote: >> >>> Yes, perhaps those were written with the Junit in mind :) >>> >> >> Exactly, in JUnit it is the other way about. I too realized this when I >> read their API docs and then corrected some of my mistakes. I guess there >> may be tons of incorrectly written assert statements :( >> > > Yes Azeez, you're quite right. > I also checked with few other product integration tests as well. And there > are loads of them in testng migrated integration tests. But they didn't get > noticed until an assert fails and you find hard to understand the assertion > failure message. But we have to fix them all. > Hi All greg integration tests have migrated with proper testng assertions. > > I have started refactoring them for GReg and there're quite a many to fix > :(. > > >> >> >>> >>> >>> On Thu, Apr 19, 2012 at 8:18 PM, Afkham Azeez <[email protected]> wrote: >>> >>>> >>>> >>>> On Thu, Apr 19, 2012 at 1:47 PM, Vijitha Kumara <[email protected]>wrote: >>>> >>>>> >>>>> This seems bit strange, the real test case expects the length to be 2 >>>>> but the test failure complains it expects 3... >>>> >>>> >>>> The way the parameters have been passed to that test is incorrect. It >>>> should be; >>>> >>>> *assertEquals(schemas.length, 2);* >>>> >>>> >>>>> >>>>> >>>>> ----------------------------------------------------------------------------------------------------------------- >>>>> build 18-Apr-2012 17:01:13 Failed tests: >>>>> build 18-Apr-2012 17:01:13 >>>>> testAddSchema(org.wso2.carbon.registry.governance.api.test.SchemaTestCase): >>>>> expected:<3> but was:<2> >>>>> build 18-Apr-2012 17:01:13 >>>>> build 18-Apr-2012 17:01:13 Tests run: 233, Failures: 1, Errors: 0, >>>>> Skipped: 0 >>>>> >>>>> ----------------------------------------------------------------------------------------------------------------- >>>>> >>>>> Test case: >>>>> >>>>> ----------------------------------------------------------------------------------------------------------------- >>>>> Schema[] schemas = schemaManager.findSchemas(new SchemaFilter() { >>>>> public boolean matches(Schema schema) throws >>>>> GovernanceException { >>>>> if (schema.getAttribute("version").equals("0.01")) { >>>>> return true; >>>>> } >>>>> return false; >>>>> } >>>>> }); >>>>> *assertEquals(2, schemas.length);* >>>>> assertEquals(newSchema.getId(), schemas[0].getId()); >>>>> >>>>> ----------------------------------------------------------------------------------------------------------------- >>>>> >>>>> Regards, >>>>> >>>>> On Thu, Apr 19, 2012 at 10:56 AM, Subash Chaturanga >>>>> <[email protected]>wrote: >>>>> >>>>>> >>>>>> >>>>>> On Thu, Apr 19, 2012 at 10:41 AM, Subash Chaturanga >>>>>> <[email protected]>wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Thu, Apr 19, 2012 at 10:19 AM, Ishan Jayawardena >>>>>>> <[email protected]>wrote: >>>>>>> >>>>>>>> Hi, please have a look at this error. Attached Log. >>>>>>>> >>>>>>> >>>>>>> Hi, already saw this on bamboo logs and working on it, this is not >>>>>>> only due to a testng failure. But product-governance-services also >>>>>>> fails. >>>>>>> >>>>>>> - governance stratos fails. >>>>>>> >>>>>> There was patch for this fix, and not yet commited. I think Dimuthu >>>>>> is looking in to this to commit the patch. >>>>>> >>>>>> >>>>>>> - 1 test failure and I am locally trying to reproduce this.(This was >>>>>>> a randomly failing test and we intentionally add this(+ two other >>>>>>> tests) to >>>>>>> see the behavior of this, because we couldn't reproduce this locally in >>>>>>> anyway). >>>>>>> >>>>>>> Excluded SchemaTest until get fixed. >>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> >>>>>>>> Thanks, >>>>>>>> Ishan. >>>>>>>> -- >>>>>>>> Ishan Jayawardena >>>>>>>> Software Engineer >>>>>>>> Integration Technologies Team >>>>>>>> WSO2, Inc. http://wso2.com/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Dev mailing list >>>>>>>> [email protected] >>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Subash Chaturanga >>>>>>> Software Engineer >>>>>>> WSO2 Inc. http://wso2.com >>>>>>> >>>>>>> email - [email protected] >>>>>>> phone - 077 2225922 >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Subash Chaturanga >>>>>> Software Engineer >>>>>> WSO2 Inc. http://wso2.com >>>>>> >>>>>> email - [email protected] >>>>>> phone - 077 2225922 >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> [email protected] >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Vijitha Kumara >>>>> Senior Software Engineer; WSO2, Inc.; http://wso2.com/ >>>>> email: [email protected] >>>>> >>>>> Lean . Enterprise . Middleware >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> * <http://www.apache.org/>** >>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>> twitter: >>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>> * >>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>> >>>> * >>>> * >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>> >>> >>> -- >>> Vijitha Kumara >>> Senior Software Engineer; WSO2, Inc.; http://wso2.com/ >>> email: [email protected] >>> >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>** >> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > Subash Chaturanga > Software Engineer > WSO2 Inc. http://wso2.com > > email - [email protected] > phone - 077 2225922 > > -- Subash Chaturanga Software Engineer WSO2 Inc. http://wso2.com email - [email protected] phone - 077 2225922
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
