Ajith, As discussed offline, don't break the working functionality during the refactoring. If needed, create a different branch & merge later.
On Mon, Apr 30, 2012 at 11:31 AM, Hiranya Jayathilaka <[email protected]>wrote: > JIRA issue: https://wso2.org/jira/browse/APISTORE-260 > > > On Fri, Apr 27, 2012 at 3:20 PM, Denis Weerasiri <[email protected]> wrote: > >> Hi all, >> Here are the meeting notes of the session. >> >> 1. Seperating out the API manager based on its publisher / subscriber >> functionalities >> 2. Creating an artifactMnager - Check whether it's required to have a >> checked exception on can have a runtimeexception >> 3. write a util method to generate the provider path etc. (In APIUtil >> class) >> 4. UpdateAPI method - avoid from null check >> 5. When (Adding/Updating) a (Document/API) provide a helper method to >> clients, as underneath, they do the same task >> 6. Refactor the method createNewAPIVersion (as it got similar >> functionality with AddAPI method) >> 7. when creating the API/Document, there are some properties get set >> inside the AddAPI and AddDocument menthods. We can move those property >> settings to a util method. >> 8. In addRXTConfig method - move resourceExist() check further up >> 9. In addRXTConfig method - move for loop inside to the try block >> 10. Use Apache commons IO to handle file name, extensions >> 11. Get rid of getRegistry(), see APIManagerImpl.getRegistryService() >> 12. Use a singleton to maintain OSGi service dependencies >> 13. Use a file filter to get rid of "rxt" type extensions, addRxtConfigs() >> 14. avoid getThumbAsString() method >> 15. move Pattern.compile like expensive operations out of the for loop in >> SearchAPI() >> 16. get rid of keepAliveRegistry() as ws-api is no longer in use >> >> >> On Wed, Apr 25, 2012 at 10:24 AM, Hiranya Jayathilaka >> <[email protected]>wrote: >> >>> more details >>> »<https://www.google.com/calendar/event?action=VIEW&eid=Nm5uaXJhcGNwZHQyNjRqN3AwbTUyaXI0MWcgZGV2QHdzbzIub3Jn&tok=MTYjaGlyYW55YUB3c28yLmNvbTIzNmQyNGNhNTg0NjZiYzQ5OTdkZWExNjFjZTY4Y2ZhMDI1ZjY4MzE&ctz=Asia/Colombo&hl=en> >>> [Integration TG] Weekly Code Review - Governance Implementation in API >>> Manager >>> We are pushing the code review which was scheduled to be held on in the >>> morning to afternoon. Please be there at 2.30. >>> *When* >>> Wed Apr 25 2:30pm – 3:30pm Colombo >>> *Where* >>> LK #58 5th Floor - Meeting room >>> (map<http://maps.google.lk/maps?q=LK+%2358+5th+Floor+-+Meeting+room&hl=en> >>> ) >>> *Calendar* >>> [email protected] >>> *Who* >>> • >>> [email protected] - organizer >>> • >>> Ajith Vitharana >>> • >>> [email protected] >>> • >>> Sumedha Rubasinghe >>> >>> Going? >>> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=Nm5uaXJhcGNwZHQyNjRqN3AwbTUyaXI0MWcgZGV2QHdzbzIub3Jn&rst=1&tok=MTYjaGlyYW55YUB3c28yLmNvbTIzNmQyNGNhNTg0NjZiYzQ5OTdkZWExNjFjZTY4Y2ZhMDI1ZjY4MzE&ctz=Asia/Colombo&hl=en>- >>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=Nm5uaXJhcGNwZHQyNjRqN3AwbTUyaXI0MWcgZGV2QHdzbzIub3Jn&rst=3&tok=MTYjaGlyYW55YUB3c28yLmNvbTIzNmQyNGNhNTg0NjZiYzQ5OTdkZWExNjFjZTY4Y2ZhMDI1ZjY4MzE&ctz=Asia/Colombo&hl=en>- >>> No<https://www.google.com/calendar/event?action=RESPOND&eid=Nm5uaXJhcGNwZHQyNjRqN3AwbTUyaXI0MWcgZGV2QHdzbzIub3Jn&rst=2&tok=MTYjaGlyYW55YUB3c28yLmNvbTIzNmQyNGNhNTg0NjZiYzQ5OTdkZWExNjFjZTY4Y2ZhMDI1ZjY4MzE&ctz=Asia/Colombo&hl=en> >>> * **more options >>> »<https://www.google.com/calendar/event?action=VIEW&eid=Nm5uaXJhcGNwZHQyNjRqN3AwbTUyaXI0MWcgZGV2QHdzbzIub3Jn&tok=MTYjaGlyYW55YUB3c28yLmNvbTIzNmQyNGNhNTg0NjZiYzQ5OTdkZWExNjFjZTY4Y2ZhMDI1ZjY4MzE&ctz=Asia/Colombo&hl=en> >>> >>> Invitation from Google Calendar <https://www.google.com/calendar/> >>> >>> You are receiving this courtesy email at the account [email protected] >>> you are an attendee of this event. >>> >>> To stop receiving future notifications for this event, decline this >>> event. Alternatively you can sign up for a Google account at >>> https://www.google.com/calendar/ and control your notification settings >>> for your entire calendar. >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Thanks, >> Denis >> ---------------------------------------------------------- >> *Denis Weerasiri* >> Senior Software Engineer >> Integration Technologies Team, WSO2 Inc.; http://wso2.com, >> *email: denis <http://goog_277208233/>** [AT] wso2.com <http://wso2.com/> >> * >> *phone: +94117639629 >> * >> *site: >> **https://sites.google.com/site/ddweerasiri/*<https://sites.google.com/site/ddweerasiri/> >> *blog: **http://ddweerasiri.blogspot.com*<http://ddweerasiri.blogspot.com/> >> * >> twitter: **http://twitter.com/ddweerasiri*<http://twitter.com/ddweerasiri> >> * >> linked-in: >> **http://lk.linkedin.com/in/ddweerasiri*<http://lk.linkedin.com/in/ddweerasiri> >> >> > > > -- > Hiranya Jayathilaka > Senior Technical Lead; > WSO2 Inc.; http://wso2.org > E-mail: [email protected]; Mobile: +94 77 633 3491 > Blog: http://techfeast-hiranya.blogspot.com > -- /sumedha +94 773017743
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
