Improvements suggested at the code review
- Make the configuration of deployment synchronizer commented out by
default in carbon.xml
- Improvements to the UI
fix the button row
- When initializing a singleton, make it a private static final field that
is initialized with the class.
- In the RepositoryConfigParameter class,
properly document the fields.
try using an Enum instead of the integer variable to decide the type of
the parameter.
add additional fields; mask (to identify password fields), maxlength of
textfield.
Setting the order is not necessary
- In SVNDeploymentSynchronizerComponent#activate() method, check and throw
an error if all first three checks fail.
- Implement the RepositoryReferenceHolder as an OSGI service.
- Within the UI source, use only generic variable names, strings in
condition checks instead of names specific to particular deployment types
(et. svn, git etc.)
- Generate the table header names dynamically
JIRA issue: https://wso2.org/jira/browse/CARBON-13022
Thanks,
Ishan.
On Wed, May 2, 2012 at 10:55 AM, Nuwan Dias <[email protected]> wrote:
> more details
> »<https://www.google.com/calendar/event?action=VIEW&eid=bGpobDdoNWNoMmk2ZTRqaGoyZHJhNnNmMjQgaXNoYW5Ad3NvMi5jb20&tok=MTUjbnV3YW5kQHdzbzIuY29tZDgwY2M3OTA3M2M0MzZjZjdmM2I5NGNmM2Y3NWM4Y2Q5NDZiYTAxZg&ctz=Asia/Colombo&hl=en>
> [Integration TG] Weekly Code Review - Deployment Synchronizer Improvements
> *When*
> Wed May 2 2pm – 3pm Colombo
> *Where*
> LK #58 5th Floor - Meeting room
> (map<http://maps.google.lk/maps?q=LK+%2358+5th+Floor+-+Meeting+room&hl=en>
> )
> *Calendar*
> [email protected]
> *Who*
> •
> Nuwan Dias - organizer
> •
> Ishan Jayawardena
> •
> Miyuru Wanninayaka
> •
> Hiranya Jayathilaka
> •
> [email protected]
> •
> Kasun Indrasiri
> •
> Vijayaratha Vijayasingam
>
> Going?
> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=bGpobDdoNWNoMmk2ZTRqaGoyZHJhNnNmMjQgaXNoYW5Ad3NvMi5jb20&rst=1&tok=MTUjbnV3YW5kQHdzbzIuY29tZDgwY2M3OTA3M2M0MzZjZjdmM2I5NGNmM2Y3NWM4Y2Q5NDZiYTAxZg&ctz=Asia/Colombo&hl=en>-
> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=bGpobDdoNWNoMmk2ZTRqaGoyZHJhNnNmMjQgaXNoYW5Ad3NvMi5jb20&rst=3&tok=MTUjbnV3YW5kQHdzbzIuY29tZDgwY2M3OTA3M2M0MzZjZjdmM2I5NGNmM2Y3NWM4Y2Q5NDZiYTAxZg&ctz=Asia/Colombo&hl=en>-
> No<https://www.google.com/calendar/event?action=RESPOND&eid=bGpobDdoNWNoMmk2ZTRqaGoyZHJhNnNmMjQgaXNoYW5Ad3NvMi5jb20&rst=2&tok=MTUjbnV3YW5kQHdzbzIuY29tZDgwY2M3OTA3M2M0MzZjZjdmM2I5NGNmM2Y3NWM4Y2Q5NDZiYTAxZg&ctz=Asia/Colombo&hl=en>
> * **more options
> »<https://www.google.com/calendar/event?action=VIEW&eid=bGpobDdoNWNoMmk2ZTRqaGoyZHJhNnNmMjQgaXNoYW5Ad3NvMi5jb20&tok=MTUjbnV3YW5kQHdzbzIuY29tZDgwY2M3OTA3M2M0MzZjZjdmM2I5NGNmM2Y3NWM4Y2Q5NDZiYTAxZg&ctz=Asia/Colombo&hl=en>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this email at the account [email protected] because you
> are subscribed for invitations on calendar [email protected].
>
> To stop receiving these notifications, please log in to
> https://www.google.com/calendar/ and change your notification settings
> for this calendar.
>
--
Ishan Jayawardena
Software Engineer
WSO2, Inc. http://wso2.com/
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
