On Wed, May 30, 2012 at 5:19 PM, Nuwan Dias <nuw...@wso2.com> wrote: > > > On Wed, May 30, 2012 at 12:37 PM, Kasun Gajasinghe <kas...@wso2.com>wrote: > >> >> >> On Wed, May 30, 2012 at 10:38 AM, Nuwan Dias <nuw...@wso2.com> wrote: >> >>> Hi Kasun, >>> >>> The flag is not checked at the CarbonDeploymentSchedulerTask level. It >>> is checked within the update method of >>> the DeploymentSynchronizerServiceImpl (which is the implementation of >>> the DeploymentSynchronizer interface). >>> >>> >> Do we need to check AutoCheckout inside the said #update method? I think >> this newly added check is unnecessary and prevents the doInitialSyncUp >> invocation. Ultimately, doInitialSyncUp method does this one time checkout >> of the code. >> >> Is there a specific reason for adding this conditional check? >> > > Yes. Without this check, checkout attempts will be made even when the > autoCheckOut flag is false. The same has been done for commit. The reason > for doing so is that the CarbonDeploymentSchedulerTask does not check for > dep-sync configuration before calling the update and commit methods. > Therefore, if a commit or update is attempted when autoCheckIn or > autoCheckOut is false, it will result in exceptions being thrown. > > Yes, I understand the reason. Shall we better position it such that #doInitialSyncUp doesn't get invoked because of this? That method does is "flags-aware". How about something like the attached patch? Would that address the issue? Please note that I haven't tested this! :)
Do you agree that we must run #doInitialSyncUp no matter what the flags are set to? --KasunG See https://wso2.org/jira/browse/CARBON-13077 > > Thanks, > >> >> --KasunG >> >> >>> The CarbonDeploymentSchedulerTask does not check for any configuration >>> parameters and AFAIK, it will run even when dep-sync is disabled. >>> >>> Thanks, >>> NuwanD. >>> >>> >>> On Wed, May 30, 2012 at 10:24 AM, Kasun Gajasinghe <kas...@wso2.com>wrote: >>> >>>> Hi Nuwan, >>>> >>>> If you look at the >>>> method CarbonDeploymentSchedulerTask#deploymentSyncUpdate, it performs an >>>> update ignoring the autocheckout flag. May be code is broken with the >>>> recent changes >>>> --KasunG >>>> >>>> >>>> On Wed, May 30, 2012 at 8:30 AM, Nuwan Dias <nuw...@wso2.com> wrote: >>>> >>>>> No, this occurs when we enable the dep-sync via the server >>>>> configuration (as reported in the jira). The reason for the issue is the >>>>> DeploymentSynchronizerServiceImpl executes the update function only if the >>>>> autoCheckOut flag is true. I believe we should execute the update function >>>>> at server start-up regardless of the autoCheckOut flag (If dep-sync is >>>>> enabled). >>>>> >>>>> Thanks, >>>>> NuwanD. >>>>> >>>>> >>>>> On Wed, May 30, 2012 at 7:55 AM, Kasun Gajasinghe <kas...@wso2.com>wrote: >>>>> >>>>>> >>>>>> >>>>>> On Wed, May 30, 2012 at 7:57 AM, Hiranya Jayathilaka < >>>>>> hira...@wso2.com> wrote: >>>>>> >>>>>>> In the initial implementation I did, the synchronizer would run one >>>>>>> checkout/update at the startup regardless of the configuration. Is this >>>>>>> not >>>>>>> the case anymore? >>>>>>> >>>>>>> >>>>>> This *is* the case when the server start-up. I believe Nuwan is >>>>>> talking about enabling the depsync via ui. >>>>>> >>>>>> Regards, >>>>>> --KasunG >>>>>> >>>>>> >>>>>>> Sent from my iPhone >>>>>>> >>>>>>> On May 29, 2012, at 9:41 PM, Nuwan Dias <nuw...@wso2.com> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, May 29, 2012 at 5:49 PM, Afkham Azeez < <az...@wso2.com> >>>>>>> az...@wso2.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, May 29, 2012 at 5:36 PM, Nuwan Dias < <nuw...@wso2.com> >>>>>>>> nuw...@wso2.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Resolved the issue stating that this is not a bug. Will enhance >>>>>>>>> the UI so that autoCheckOut will automatically be enabled if >>>>>>>>> autoCheckIn is >>>>>>>>> enabled. >>>>>>>>> >>>>>>>>> >>>>>>>> Rather, what you should do is, if autoCheckin is on, regardless of >>>>>>>> the autoCheckout parameter, you must do the checking out. i.e. >>>>>>>> autoCheckout >>>>>>>> is ignored if autoCheckin is ON. It is not a UI only thing. Please >>>>>>>> improve >>>>>>>> the depsync code to handle this. We must minimize user errors. >>>>>>>> >>>>>>> >>>>>>> Understood, will do the necessary changes. >>>>>>> >>>>>>> Thanks, >>>>>>> NuwanD. >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> >>>>>>>>> On Tue, May 29, 2012 at 5:28 PM, Charitha Kankanamge >>>>>>>>> <<chari...@wso2.com> >>>>>>>>> chari...@wso2.com> wrote: >>>>>>>>> >>>>>>>>>> On Tue, May 29, 2012 at 5:26 PM, Afkham Azeez < <az...@wso2.com> >>>>>>>>>> az...@wso2.com> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Tue, May 29, 2012 at 5:02 PM, Charitha Kankanamge >>>>>>>>>>> <<chari...@wso2.com> >>>>>>>>>>> chari...@wso2.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Nuwan, >>>>>>>>>>>> I raised the same question in "[Dev] WSO2 Carbon Beta Packs >>>>>>>>>>>> for QA" thread sometime back but did not get a reply hence >>>>>>>>>>>> reported the jira. >>>>>>>>>>>> >>>>>>>>>>>> "Should the admin node be started with both auto-commit and >>>>>>>>>>>> auto-checkout set to true?" >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Yes, obviously. Think of SVN. Is it possible to commit to an SVN >>>>>>>>>>> repo if you have not checked out first? >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> :) correct. >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Tue, May 29, 2012 at 4:24 PM, Nuwan Dias < <nuw...@wso2.com> >>>>>>>>>>>> nuw...@wso2.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> In the issue at <https://wso2.org/jira/browse/CARBON-13108> >>>>>>>>>>>>> https://wso2.org/jira/browse/CARBON-13108, it has been >>>>>>>>>>>>> reported that a CHECKOUT_BEFORE_CHECK_IN error occurs when using >>>>>>>>>>>>> the >>>>>>>>>>>>> Registry based deployment synchronization in WRITE_ONLY mode >>>>>>>>>>>>> (autoCheckOut=false, autoCheckIn=true). This error is caused due >>>>>>>>>>>>> to the >>>>>>>>>>>>> CheckInCommand failing to find the meta files directory which is >>>>>>>>>>>>> normally >>>>>>>>>>>>> created during the first registry checkout. >>>>>>>>>>>>> >>>>>>>>>>>>> Is running a node in WRITE_ONLY mode logical? If so, how >>>>>>>>>>>>> should we address this issue? >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Nuwan Dias >>>>>>>>>>>>> >>>>>>>>>>>>> Software Engineer - WSO2, Inc. >>>>>>>>>>>>> Integration Technologies Team >>>>>>>>>>>>> email : <nuw...@wso2.com>nuw...@wso2.com >>>>>>>>>>>>> Phone : +94 777 775 729 >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> _______________________________________________ >>>>>>>>>>>> Dev mailing list >>>>>>>>>>>> <Dev@wso2.org>Dev@wso2.org >>>>>>>>>>>> <http://wso2.org/cgi-bin/mailman/listinfo/dev> >>>>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Afkham Azeez* >>>>>>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>>>>>>>> Member; Apache Software Foundation; <http://www.apache.org/> >>>>>>>>>>> http://www.apache.org/ >>>>>>>>>>> * <http://www.apache.org/>** >>>>>>>>>>> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >>>>>>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>>>>>>>>> twitter: >>>>>>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>>>>>>>>> * >>>>>>>>>>> linked-in: ** <http://lk.linkedin.com/in/afkhamazeez> >>>>>>>>>>> http://lk.linkedin.com/in/afkhamazeez* >>>>>>>>>>> * >>>>>>>>>>> * >>>>>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Nuwan Dias >>>>>>>>> >>>>>>>>> Software Engineer - WSO2, Inc. >>>>>>>>> Integration Technologies Team >>>>>>>>> email : <nuw...@wso2.com>nuw...@wso2.com >>>>>>>>> Phone : +94 777 775 729 >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Afkham Azeez* >>>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>>>>> Member; Apache Software Foundation; <http://www.apache.org/> >>>>>>>> http://www.apache.org/ >>>>>>>> * <http://www.apache.org/>** >>>>>>>> email: **az...@wso2.com* <az...@wso2.com>* cell: +94 77 3320919 >>>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>>>>>> twitter: >>>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>>>>>> * >>>>>>>> linked-in: ** <http://lk.linkedin.com/in/afkhamazeez> >>>>>>>> http://lk.linkedin.com/in/afkhamazeez* >>>>>>>> * >>>>>>>> * >>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Nuwan Dias >>>>>>> >>>>>>> Software Engineer - WSO2, Inc. >>>>>>> Integration Technologies Team >>>>>>> email : <nuw...@wso2.com>nuw...@wso2.com >>>>>>> Phone : +94 777 775 729 >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> Dev@wso2.org >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> Dev@wso2.org >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Kasun Gajasinghe* >>>>>> Software Engineer; >>>>>> Development Technologies Team, WSO2 Inc.; http://wso2.com , >>>>>> *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813* >>>>>> *linked-in: *http://lk.linkedin.com/in/gajasinghe* >>>>>> * >>>>>> *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>* >>>>>> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>* >>>>>> * >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Nuwan Dias >>>>> >>>>> Software Engineer - WSO2, Inc. >>>>> Integration Technologies Team >>>>> email : nuw...@wso2.com >>>>> Phone : +94 777 775 729 >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Kasun Gajasinghe* >>>> Software Engineer; >>>> Development Technologies Team, WSO2 Inc.; http://wso2.com , >>>> *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813* >>>> *linked-in: *http://lk.linkedin.com/in/gajasinghe* >>>> * >>>> *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>* >>>> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>* >>>> * >>>> >>>> >>> >>> >>> -- >>> Nuwan Dias >>> >>> Software Engineer - WSO2, Inc. >>> Integration Technologies Team >>> email : nuw...@wso2.com >>> Phone : +94 777 775 729 >>> >>> >> >> >> -- >> *Kasun Gajasinghe* >> Software Engineer; >> Development Technologies Team, WSO2 Inc.; http://wso2.com , >> *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813* >> *linked-in: *http://lk.linkedin.com/in/gajasinghe* >> * >> *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>* >> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>* >> * >> >> > > > -- > Nuwan Dias > > Software Engineer - WSO2, Inc. > Integration Technologies Team > email : nuw...@wso2.com > Phone : +94 777 775 729 > > -- *Kasun Gajasinghe* Software Engineer; Development Technologies Team, WSO2 Inc.; http://wso2.com , *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813* *linked-in: *http://lk.linkedin.com/in/gajasinghe* * *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>* twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>* *
depsync-initialsync-fix.patch
Description: Binary data
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
