Hi Dimuthu, If there aren't any integration test failures reported by any products (in addition to the ones that are already been reported on builder), I don't see any reason to why this would cause any issues. But, someone actually has to run that before committing and validate. Especially those issues that came during the last cycle needs to be validated.
Thanks, Senaka. On Mon, Jun 4, 2012 at 6:51 PM, Dimuthu Leelarathne <[email protected]>wrote: > Hi Azeez, > > AFAIK, what Dushan did was different to this patch. Dushan removed the > whole SCR plugin instead of removing the version part. I had an offline > chat with AmilaS and he said the version is there because it is copied from > some other pom.xml and not because it is required. > > We'll be committing the fixes after running full integration tests. I > suppose we can go ahead after running with all integration tests. > thanks, > dimuthu > > > On Fri, Jun 1, 2012 at 6:21 PM, Afkham Azeez <[email protected]> wrote: > >> Did you try to run a full build with integration tests after doing these >> changes? >> >> >> On Fri, Jun 1, 2012 at 6:20 PM, Afkham Azeez <[email protected]> wrote: >> >>> Don't remove this. Dushan did this sometime back & it caused the entire >>> build to fail. We need to investigate & find the proper fix for this. >>> >>> >>> On Fri, Jun 1, 2012 at 12:21 PM, Maheshika Goonetilleke < >>> [email protected]> wrote: >>> >>>> Hi all >>>> >>>> I'm in the process of delete the following from the pom.xml as >>>> it conflicts while updating the sonar. >>>> >>>> ex: https://wso2.org/jira/secure/attachment/19017/patch_event.txt >>>> >>>> - <version>1.0.10</version> >>>> - <executions> >>>> - <execution> >>>> - <id>generate-scr-scrdescriptor</id> >>>> - <goals> >>>> - <goal>scr</goal> >>>> - </goals> >>>> - </execution> >>>> - </executions> >>>> >>>> Following Jira issue is created ; >>>> >>>> https://wso2.org/jira/browse/CARBON-13161 >>>> >>>> Appreciate if you could check and confirm if this is necessary prior to >>>> any changes been committed. >>>> >>>> -- >>>> >>>> Thanks & Best Regards, >>>> >>>> Maheshika Goonetilleke >>>> Engineering Process Coordinator >>>> WSO2 Inc >>>> >>>> www.wso2.com/ >>>> >>>> M : 0773 596707 >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com >>> Member; Apache Software Foundation; http://www.apache.org/ >>> * <http://www.apache.org/>** >>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>** >> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Dimuthu Leelarathne > Technical Lead > > WSO2, Inc. (http://wso2.com) > email: [email protected] > > > Lean . Enterprise . Middleware > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Senaka Fernando* Member - Integration Technologies Management Committee; Technical Lead; WSO2 Inc.; http://wso2.com* Member; Apache Software Foundation; http://apache.org E-mail: senaka AT wso2.com **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 Linked-In: http://linkedin.com/in/senakafernando *Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
