Hi, Please find the notes from the code review below: Participants: Miyuru, Asela, Dushan, Suresh, Hasini. Reviewed components : ActiveDirectroyUserStoreManager and modified parts of ReadOnlyLDAPUserStoreManager & ReadWriteLDAPUserStoreManager
Suggested improvements: - Update the comments in the source code to adhere to new names - Improve null check and empty string check - Set default values if not configured - Validate configuration parameter values if possible - such as ldap url - Identify only the mandatory configuration parameters and halt server startup if they are not provided in checkRequiredUserStoreConfigurations method - Give user account type as a configurable parameter - in ActiveDirectoryUserStoreManager - If user addition failed, send the relevant error code to UI along with the custom error message - Remove the user entry from AD if password modification step is failed in addUser method. - Format the code according to WSO2 code formatting. Thanks, Hasini. On Thu, Jul 12, 2012 at 10:50 PM, Suresh Attanayaka <[email protected]> wrote: > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=cGhmZTIwbWUwcHRkaWdqYnVycDB1Zjl0MnMgaGFzaW5pQHdzbzIuY29t&tok=MTUjc3VyZXNoQHdzbzIuY29tY2RiMTIwOWUwZmM4NzI5NzE3NjZiNDRkMDRiY2Q4MTFhYzM5NGE0MQ&ctz=Asia/Colombo&hl=en> > User Management Code Review > *When* > Fri Jul 13 1:30pm – 2:30pm Colombo > *Where* > 5th Floor , #58 (map<http://maps.google.lk/maps?q=5th+Floor+,+%2358&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > Suresh Attanayaka - organizer > • > Asela Pathberiya > • > Prabath Siriwardana > • > Kasun Indrasiri > • > Thilina Buddhika > • > Johann Nallathamby > • > [email protected] > • > Hasini Gunasinghe > > Going? > ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=cGhmZTIwbWUwcHRkaWdqYnVycDB1Zjl0MnMgaGFzaW5pQHdzbzIuY29t&rst=1&tok=MTUjc3VyZXNoQHdzbzIuY29tY2RiMTIwOWUwZmM4NzI5NzE3NjZiNDRkMDRiY2Q4MTFhYzM5NGE0MQ&ctz=Asia/Colombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=cGhmZTIwbWUwcHRkaWdqYnVycDB1Zjl0MnMgaGFzaW5pQHdzbzIuY29t&rst=3&tok=MTUjc3VyZXNoQHdzbzIuY29tY2RiMTIwOWUwZmM4NzI5NzE3NjZiNDRkMDRiY2Q4MTFhYzM5NGE0MQ&ctz=Asia/Colombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=cGhmZTIwbWUwcHRkaWdqYnVycDB1Zjl0MnMgaGFzaW5pQHdzbzIuY29t&rst=2&tok=MTUjc3VyZXNoQHdzbzIuY29tY2RiMTIwOWUwZmM4NzI5NzE3NjZiNDRkMDRiY2Q4MTFhYzM5NGE0MQ&ctz=Asia/Colombo&hl=en> > * **more options > »<https://www.google.com/calendar/event?action=VIEW&eid=cGhmZTIwbWUwcHRkaWdqYnVycDB1Zjl0MnMgaGFzaW5pQHdzbzIuY29t&tok=MTUjc3VyZXNoQHdzbzIuY29tY2RiMTIwOWUwZmM4NzI5NzE3NjZiNDRkMDRiY2Q4MTFhYzM5NGE0MQ&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
