Hi
Yes, your suggestion is correct, I will do required changers and will
introduce SequenceMediatorFactory instead of invoking
MediatorService service = MediatorStore.getInstance().
getMediatorService(sequenceElement);
cheers
Dushan
On Tue, Jul 17, 2012 at 10:58 AM, Hiranya Jayathilaka <[email protected]>wrote:
> I don't think this fix is correct. It's introducing an unnecessary compile
> time dependency between synapse-config-admin and sequence editor. Why don't
> you use the SequenceMediatorFactory class from Synapse directly?
>
> Thanks,
> Hiranya
>
>
> On Thu, Jul 12, 2012 at 3:52 PM, <[email protected]> wrote:
>
>> Author: dushan
>> Date: Thu Jul 12 06:22:20 2012
>> New Revision: 132727
>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=132727
>>
>> Log:
>> Properties can be created with names containing special characters. But
>> Such properties cannot be used in some Xpath expressions.
>> https://wso2.org/jira/browse/ESBJAVA-1052
>>
>>
>> Modified:
>>
>>
>> carbon/platform/trunk/components/synapse-config-admin/org.wso2.carbon.mediation.configadmin/src/main/java/org/wso2/carbon/mediation/configadmin/ConfigurationValidator.java
>>
>> Modified:
>> carbon/platform/trunk/components/synapse-config-admin/org.wso2.carbon.mediation.configadmin/src/main/java/org/wso2/carbon/mediation/configadmin/ConfigurationValidator.java
>> URL:
>> http://wso2.org/svn/browse/wso2/carbon/platform/trunk/components/synapse-config-admin/org.wso2.carbon.mediation.configadmin/src/main/java/org/wso2/carbon/mediation/configadmin/ConfigurationValidator.java?rev=132727&r1=132726&r2=132727&view=diff
>>
>> ==============================================================================
>> ---
>> carbon/platform/trunk/components/synapse-config-admin/org.wso2.carbon.mediation.configadmin/src/main/java/org/wso2/carbon/mediation/configadmin/ConfigurationValidator.java
>> (original)
>> +++
>> carbon/platform/trunk/components/synapse-config-admin/org.wso2.carbon.mediation.configadmin/src/main/java/org/wso2/carbon/mediation/configadmin/ConfigurationValidator.java
>> Thu Jul 12 06:22:20 2012
>> @@ -27,6 +27,9 @@
>> import org.apache.synapse.core.axis2.ProxyService;
>> import org.apache.synapse.endpoints.Endpoint;
>> import org.apache.synapse.endpoints.WSDLEndpoint;
>> +import org.wso2.carbon.mediator.service.MediatorService;
>> +import org.wso2.carbon.mediator.service.MediatorStore;
>> +import org.wso2.carbon.mediator.service.builtin.SequenceMediator;
>>
>> import javax.xml.namespace.QName;
>> import java.io.IOException;
>> @@ -62,6 +65,8 @@
>> validateProxyService(child, errors);
>> } else if
>> (XMLConfigConstants.ENDPOINT_ELT.equals(child.getQName())) {
>> validateEndpoint(child, errors);
>> + }else
>> if(XMLConfigConstants.SEQUENCE_ELT.equals(child.getQName())){
>> + validateSequence(child,errors);
>> }
>> }
>> }
>> @@ -72,6 +77,16 @@
>> return null;
>> }
>>
>> + private void validateSequence(OMElement
>> sequenceElement,List<ValidationError> errors) {
>> + try{
>> + MediatorService service =
>> MediatorStore.getInstance().getMediatorService(sequenceElement);
>> + SequenceMediator sequence = (SequenceMediator)
>> service.getMediator();
>> + sequence.build(sequenceElement);
>> + }catch (Exception e) {
>> + errors.add(newValidationError(sequenceElement,
>> e.getMessage()));
>> + }
>> + }
>> +
>> private void validateProxyService(OMElement proxyElement,
>> List<ValidationError> errors) {
>> try {
>> ProxyService proxy =
>> ProxyServiceFactory.createProxy(proxyElement, new Properties());
>> _______________________________________________
>> Commits mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/commits
>>
>
>
>
> --
> Hiranya Jayathilaka
> Senior Technical Lead;
> WSO2 Inc.; http://wso2.org
> E-mail: [email protected]; Mobile: +94 77 633 3491
> Blog: http://techfeast-hiranya.blogspot.com
>
--
Dushan Abeyruwan
*Senior Software Engineer*
*Integration Technologies Team*
*WSO2 Inc. http://wso2.com/*
*Mobile:(+94)714408632*
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
