ProxyObserver.serviceUpdate() behavior on Hot update is buggy. It deletes proxy xml during hot update and in the same time persistence manager persists new configuration to file system.
In happy path ( which seems always happened until last build) * Synapse picks updated proxy artifact * proxy observer deletes proxy xml file from file system * Mediation persistence manager persists proxy to file system Since everything happens in split second, we won't see file deletion and re creation. Seems a recent change in somewhere changed speed of threads and now * Synapse picks updated proxy artifact * Mediation persistence manager persists proxy to file system ( might be removing of registry persistence speeded PM thread) * proxy observer deletes proxy xml file from file system So end result will be missing artifact on file system Even in previous builds, buggy behavior might appear based on thread switching which might be cause for sudden disappearance of proxy services on tests done on last week. And even missing proxy services during CAR update Correct fix is, proxy observer should not touch proxy xml during hot update. On Fri, Aug 31, 2012 at 4:33 PM, Kasun Indrasiri <[email protected]> wrote: > Looks like we have exploited a bug in hot update logic. In debug mode, the > very same issue can be reproduced in all milestone builds and even in 4.0.3 > release. We have tested some possible local fixes which seems to resolve > the issue. Will commit them after a complete end to end test on proxy > service deployment logic. > > > On Fri, Aug 31, 2012 at 12:37 AM, Kasun Indrasiri <[email protected]> wrote: > >> In fact, this is common to all the proxy service hot updates. If we save >> an existing proxy service from the file system, it will disappear. >> I believe, this is a bug that occurs due to a very recent change, because >> I cannot reproduce this on either M3 or M4. We will investigate further. >> >> >> On Fri, Aug 31, 2012 at 12:03 AM, Kasun Indrasiri <[email protected]> wrote: >> >>> >>> >>> On Thu, Aug 30, 2012 at 11:35 PM, Kasun Gajasinghe <[email protected]>wrote: >>> >>>> The issue is here - https://wso2.org/jira/browse/ESBJAVA-1556 >>>> This is a blocker. >>>> >>>> I noticed this on the latest ESB pack got from Miyuru today. While >>>> issues like wrong xml syntax in a proxy xml were handled safely, it failed >>>> to handle some scenarios. Here's one. >>>> >>>> Create any Passthrough proxy. Say, proxy1 >>>> Now, the config file proxy1.xml will be at its relevant location. >>>> Now, open it, and remove the "trace" attribute in the root xml node. >>>> The ESB will say it got successfully deployed [1], but in fact, that >>>> file was deleted. >>>> >>>> This makes inconsistency in a clustered setup where the worker nodes >>>> are not supposed to perform write operation like this in the axis2 repo >>>> directory. >>>> >>>> >>> I also can reproduce this issue with the following warning. >>> >>> [2012-08-30 23:50:46,181] WARN - MediationPersistenceManager Mediation >>> persistence manager is either not initialized or not in the 'accepting' >>> mode. Ignoring the save request. >>> >>> Also, the number of active services shows wrong values and varies from >>> time to time. >>> 15 active services. 7 deployed service >>> group(s).<https://localhost:9443/carbon/service-mgt/service_groups.jsp> >>> (where I only have 7 services deployed) >>> >>> >>>> [1] >>>> osgi> [2012-08-30 23:09:06,984] INFO - ProxyService Stopped the proxy >>>> service : p10 >>>> [2012-08-30 23:09:06,995] INFO - ProxyObserver Deleted the proxy >>>> service : p10 >>>> [2012-08-30 23:09:06,996] INFO - ProxyService Building Axis service for >>>> Proxy service : p10 >>>> [2012-08-30 23:09:06,996] INFO - ProxyService Adding service p10 to the >>>> Axis2 configuration >>>> [2012-08-30 23:09:07,001] INFO - DeploymentInterceptor Deploying Axis2 >>>> service: p10 {super-tenant} >>>> [2012-08-30 23:09:07,028] INFO - ProxyService Successfully created the >>>> Axis2 service for Proxy service : p10 >>>> [2012-08-30 23:09:07,029] INFO - ProxyServiceDeployer ProxyService >>>> named 'p10' has been update from file : >>>> /home/kasun/wso2/products/packs-2012-Aug-30/wso2esb-4.5.0/repository/deployment/server/synapse-configs/default/proxy-services/p10.xml >>>> >>>> >>>> -- >>>> *Kasun Gajasinghe* >>>> Software Engineer; >>>> Development Technologies Team, WSO2 Inc.; http://wso2.com , >>>> *email: **kasung AT spamfree wso2.com** cell: **+94 (77) 678-0813* >>>> *linked-in: *http://lk.linkedin.com/in/gajasinghe* >>>> * >>>> *blog: **http://blog.kasunbg.org* <http://blog.kasunbg.org>* >>>> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>* >>>> * >>>> >>>> >>> >>> >>> -- >>> Kasun Indrasiri >>> Associate Technical Lead >>> WSO2, Inc.; http://wso2.com >>> lean.enterprise.middleware >>> >>> cell: +94 71 536 4128 >>> Blog : http://kasunpanorama.blogspot.com/ >>> >> >> >> >> -- >> Kasun Indrasiri >> Associate Technical Lead >> WSO2, Inc.; http://wso2.com >> lean.enterprise.middleware >> >> cell: +94 71 536 4128 >> Blog : http://kasunpanorama.blogspot.com/ >> > > > > -- > Kasun Indrasiri > Associate Technical Lead > WSO2, Inc.; http://wso2.com > lean.enterprise.middleware > > cell: +94 71 536 4128 > Blog : http://kasunpanorama.blogspot.com/ > -- Thanks, Miyuru
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
