On Thu, Sep 6, 2012 at 5:07 PM, Ashansa Perera <[email protected]> wrote:
> Review notes > > Avoid using "ui.execute", use repository url and read/write permission > Use https when using basic auth > Change the hardcoded repo version '0' to HEAD > Use constants than String literals > Define a ENUM for repository types > When creating the working directory, use UUID than using the current time > When logging errors use log.error(message,e) than just logging a message > When required, throw exceptions than just logging > (if failed to delete the workingDir, if repository provider is not found, > etc ) > > Use String than StringBuilder outside loops > String concatenation is really fast and encouraged using a StringBuilder, though it's not thread safe(it's a rare case). http://vanillajava.blogspot.com/2012/08/java-memes-which-refuse-to-die.html Rajika > Util package should be come under 'internal' > Register repository providers in their own package > > Do not store username/password as variables > Do not log in as apache user to create repository > Have a comment on why we cache the hashed password > > Have more comments > Format code > Use meaningful variable names > > Please add if anything is missing > > On Thu, Sep 6, 2012 at 8:08 AM, Ajanthan Balachandran > <[email protected]>wrote: > >> This event has been changed. >> more details >> »<https://www.google.com/calendar/event?action=VIEW&eid=aGdydmNia2NpcnU5bTF0NHF2bjRpaWxuMzAgYXNoYW5zYUB3c28yLmNvbQ&tok=MTcjYWphbnRoYW5Ad3NvMi5jb21iYTUxNzQ3YmRjY2Q5MTMxOGEzNTYzM2FlNzFkZmQ3ZjE0NTlhMGFj&ctz=Asia/Colombo&hl=en> >> App Factory Repository Management Component Code review >> *When* >> Thu Sep 6 2:30pm – 3:30pm Colombo >> *Where* >> *Changed: *LK #59 2nd Floor Room >> (map<http://maps.google.lk/maps?q=LK+%2359+2nd+Floor+Room&hl=en> >> ) >> *Calendar* >> [email protected] >> *Who* >> • >> [email protected] - organizer >> • >> Selvaratnam Uthaiyashankar >> • >> Thilini Ishaka >> • >> Achala Aponso >> • >> Dilshan Edirisuriya >> • >> Ashansa Perera >> • >> [email protected] >> • >> Ramith Jayasinghe >> • >> Dimuthu Leelarathne >> >> Going? >> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=aGdydmNia2NpcnU5bTF0NHF2bjRpaWxuMzAgYXNoYW5zYUB3c28yLmNvbQ&rst=1&tok=MTcjYWphbnRoYW5Ad3NvMi5jb21iYTUxNzQ3YmRjY2Q5MTMxOGEzNTYzM2FlNzFkZmQ3ZjE0NTlhMGFj&ctz=Asia/Colombo&hl=en>- >> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=aGdydmNia2NpcnU5bTF0NHF2bjRpaWxuMzAgYXNoYW5zYUB3c28yLmNvbQ&rst=3&tok=MTcjYWphbnRoYW5Ad3NvMi5jb21iYTUxNzQ3YmRjY2Q5MTMxOGEzNTYzM2FlNzFkZmQ3ZjE0NTlhMGFj&ctz=Asia/Colombo&hl=en>- >> No<https://www.google.com/calendar/event?action=RESPOND&eid=aGdydmNia2NpcnU5bTF0NHF2bjRpaWxuMzAgYXNoYW5zYUB3c28yLmNvbQ&rst=2&tok=MTcjYWphbnRoYW5Ad3NvMi5jb21iYTUxNzQ3YmRjY2Q5MTMxOGEzNTYzM2FlNzFkZmQ3ZjE0NTlhMGFj&ctz=Asia/Colombo&hl=en> >> * **more options >> »<https://www.google.com/calendar/event?action=VIEW&eid=aGdydmNia2NpcnU5bTF0NHF2bjRpaWxuMzAgYXNoYW5zYUB3c28yLmNvbQ&tok=MTcjYWphbnRoYW5Ad3NvMi5jb21iYTUxNzQ3YmRjY2Q5MTMxOGEzNTYzM2FlNzFkZmQ3ZjE0NTlhMGFj&ctz=Asia/Colombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this email at the account [email protected] because you >> are subscribed for updated invitations on calendar [email protected]. >> >> To stop receiving these notifications, please log in to >> https://www.google.com/calendar/ and change your notification settings >> for this calendar. >> > > > > -- > Thanks & Regards, > > Ashansa Perera > Software Engineer > WSO2, Inc > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
