Hi, FYI. I have removed the changes done at Rampart level due to following reasons:
1. It has introduced a regression issue in secure communication in ESB with non-secured proxy --> secured service scenario as discussed in another thread. (Issue could be overcome using send mediator in released packs, but if send mediator is not present, the issue appears) 2. Changes at Rampart level introduced only a slight performance improvement. (the majority of the improvement was achieved from axis2 level change which Azeez did) Will add the new rampart version to 4.0.2 patch release. Thanks, Hasini. On Tue, Sep 4, 2012 at 11:47 PM, Hasini Gunasinghe <[email protected]> wrote: > Attaching the modifications at Rampart handlers level which caused slight > improvement. > Please review and commit. > > We can also consider removing rampart module (i.e security phase) from > global phase in a future release so that rampart handlers will not be > invoked for each service call. > > Thanks, > Hasini. > > > On Tue, Sep 4, 2012 at 4:55 PM, Afkham Azeez <[email protected]> wrote: > >> Just by making the following change we were able to see a performance >> improvement of close to 20% !!! >> >> Index: src/org/apache/axis2/description/AxisModule.java >> =================================================================== >> --- src/org/apache/axis2/description/AxisModule.java (revision 141042) >> +++ src/org/apache/axis2/description/AxisModule.java (working copy) >> @@ -129,8 +129,17 @@ >> * >> * @return the archive name of the module >> */ >> + private String archiveName; >> + >> public String getArchiveName() { >> - return version == null ? name : (name + "-" + version); >> + if (archiveName == null){ >> + if(version == null){ >> + archiveName = name; >> + } else { >> + archiveName = name + "-" + version; >> + } >> + } >> + return archiveName; >> } >> >> On Tue, Sep 4, 2012 at 2:27 PM, Afkham Azeez <[email protected]> wrote: >> >>> This is a simple echo service which has not been secured. In the in >>> flow, the overhead caused by the rampart handlers is 8% & in the out flow >>> the overhead is 12%. So, we can improve performance by 20% just by >>> optimizing this bit of code. >>> >>> Azeez >>> >>> >>> On Tue, Sep 4, 2012 at 2:23 PM, Prabath Siriwardena <[email protected]>wrote: >>> >>>> What is the security policy you used here..? >>>> >>>> Thanks & regards, >>>> -Prabath >>>> >>>> >>>> On Tue, Sep 4, 2012 at 2:20 PM, Afkham Azeez <[email protected]> wrote: >>>> >>>>> Rampart handlers are causing much higher overhead in the outflow. See >>>>> attached screenshot. >>>>> >>>>> >>>>> >>>>> On Tue, Sep 4, 2012 at 2:16 PM, Hasini Gunasinghe <[email protected]>wrote: >>>>> >>>>>> Will look into this. >>>>>> >>>>>> Thanks, >>>>>> Hasini. >>>>>> >>>>>> On Tue, Sep 4, 2012 at 2:06 PM, Afkham Azeez <[email protected]> wrote: >>>>>> >>>>>>> See attached jprofiler screenshot. >>>>>>> >>>>>>> The main culprit seems to be the isEngaged method call which is >>>>>>> repeatedly building the module name. The fix should be simple, we could >>>>>>> remember the module name. Prabath et. al. please take this up urgently. >>>>>>> >>>>>>> -- >>>>>>> *Afkham Azeez* >>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>>>> * <http://www.apache.org/>** >>>>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>>>>> twitter: >>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>>>>> * >>>>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>>>>> * >>>>>>> * >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Dev mailing list >>>>>>> [email protected] >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Afkham Azeez* >>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>> * <http://www.apache.org/>** >>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>>>> twitter: >>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>>>> * >>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>>>> * >>>>> * >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Prabath >>>> >>>> Mobile : +94 71 809 6732 >>>> >>>> http://blog.facilelogin.com >>>> http://RampartFAQ.com >>>> >>>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com >>> Member; Apache Software Foundation; http://www.apache.org/ >>> * <http://www.apache.org/>** >>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>** >> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> * >> * >> *Lean . Enterprise . Middleware* >> >> >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
