On Sat, Oct 27, 2012 at 6:25 AM, Selvaratnam Uthaiyashankar <
[email protected]> wrote:

> Hi,
>
> Check the following API (in 3.2.2 branch.. haven't checked in 4.0.0 branch)
> SecretResolver org.wso2.securevault.SecretResolverFactory.create(OMElement
> configuration, boolean isCapLetter)
>
>
> why do we need the parameter "isCapLetter"? If it is true, it is searching
> for an element "SecureVault" and if false, it is searching for
> "secureVault" element. However, this is not a userlevel parameter. This API
> does not look good :).
>
>
!!! yes, that is an implementation detail, and should never be part os the
API!



> Can we remove that parameter? If we need to have backward compatibility,
> we can search for the element "SecureVault" and if it is not there search
> for element "secureVault".
>
> Regards,
> Shankar
>
> --
> S.Uthaiyashankar
> Director, Cloud Solutions
> WSO2 Inc.
> http://wso2.com/ - "lean . enterprise . middleware"
>
> Phone: +94 714897591
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/
* <http://www.apache.org/>**
email: **[email protected]* <[email protected]>* cell: +94 77 3320919
blog: **http://blog.afkham.org* <http://blog.afkham.org>*
twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
*
linked-in: **http://lk.linkedin.com/in/afkhamazeez*
*
*
*Lean . Enterprise . Middleware*
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to