One quick improvement we can do is, if it takes more than x ms to initialize a CarbonContext, we can print a log4j warning. This will give an early indication of performance issues.
Azeez On Mon, Dec 17, 2012 at 12:23 AM, Senaka Fernando <[email protected]> wrote: > Hi Azeez, > > Yes we need to do a proper and lasting fix as in the last round of API > improvements. However, as the impact of these changes are cross cutting we > will need sometime to validate the fixes and make required changes in > components etc. > > Thanks, > Senaka. > > On Mon, Dec 17, 2012 at 12:11 AM, Afkham Azeez <[email protected]> wrote: > >> >> >> On Sun, Dec 16, 2012 at 10:39 PM, Muhammed Shariq <[email protected]>wrote: >> >>> Hi Senaka, >>> >>> Thanks for the detailed explanation .. lesson learnt - don't ever mess >>> with the CarbonContext! :D ... (was fun studying the code base and messing >>> with it nonetheless ;) .. ) >>> >>> >> It also shows that there are major issues in CC related code & it is very >> fragile. We need to do another round of reviewing & fix it properly. The >> last round dealt mainly with cleaning up the API. Now it is time to look at >> the implementation & clean it up. >> >>> >>> On Sat, Dec 15, 2012 at 10:40 PM, Senaka Fernando <[email protected]>wrote: >>> >>>> equence. The current sequence assumes that "*null == >>>> currentCarbonContext*" will happen at times, when the CarbonContext >>>> should not exist on the thread, which will then return the one on the >>>> >>> >>> >>> >>> -- >>> Thanks, >>> Shariq. >>> Phone: +94 777 202 225 >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>** >> email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * >> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >> >> * >> * >> *Lean . Enterprise . Middleware* >> >> > > > -- > * <http://wso2con.com/> > * > * > > Senaka Fernando* > Member - Integration Technologies Management Committee; > Technical Lead; WSO2 Inc.; http://wso2.com* > Member; Apache Software Foundation; http://apache.org > > E-mail: senaka AT wso2.com > **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 > Linked-In: http://linkedin.com/in/senakafernando > > * > Lean . Enterprise . Middleware > > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **[email protected]* <[email protected]>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
