Hi all, Yes. UM and Registry were by-products of WSO2 Registry, and once introduced into Carbon, they were split into two. During the process, there were situations where some code was written in a way that the two were in separable. And, for such an extended Registry implementation called UserRegistry (which has Registry API + getUsername, getTenantId, getUserRealm) was introduced. Our platform has evolved a lot since this was done, and we now have the CarbonContext, which combines these two. So, in order to fix this and get rid of usage/need of UserRegistry outside the kernel, we should:
1. If the UserRegistry was obtained from CarbonContext, change it to Registry and use the CarbonContext for Username and Realm. 2. If the Additional implementation methods are not used, simply change it to Registry instead of UserRegistry. 3. If it does not fall into the above 2 categories, start a discussion to clarify and fix. Lets get going with kernel and clean it up and then proceed with components. But please make sure to run all product integration tests before committing any changes. And if this is trunk, make sure you can build trunk with integration tests (of products and not kernel, since kernel is the least impacted by these changes) before touching anything. If that cannot be done, please escalate and get it fixed ASAP. Or else it will be a much greater nightmare compared to last fix we did to revert some changes in the CarbonContext resolution logic. Thanks, Senaka. On Thu, Jan 24, 2013 at 5:54 AM, Pradeep Fernando <[email protected]> wrote: > hi, > > FYI, > > had an offline chat with senakal. Seems like its there because of some > legacy reasons. Claims that methods such as getUserRealm() is not part of > the registry API. we might be able to get the same, by referring to the > carbon context. > > > > > On Wed, Jan 23, 2013 at 6:32 AM, Pradeep Fernando <[email protected]>wrote: > >> >> >> Hi Ajith/Senaka >> >> While going through the kernel code, found out that we are using >> UserRegistry as a the reference type within api methods in kernel. >> >> eg: in TenantAxisConfigurator >> >> Why we depend on ConcreteClasses here ? What are the repercussions if i >> move them to Registry interface type.? - One thing i noticed is that i >> cant get UserRealm out from Registry API. >> >> thanks, >> --Pradeep >> >> >> > > > -- > *Pradeep Fernando* > Member, Management Committee - Platform & Cloud Technologies > Senior Software Engineer;WSO2 Inc.; http://wso2.com > > blog: http://pradeepfernando.blogspot.com > m: +94776603662 > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- * <http://wso2con.com/> * * Senaka Fernando* Member - Integration Technologies Management Committee; Technical Lead; WSO2 Inc.; http://wso2.com* Member; Apache Software Foundation; http://apache.org E-mail: senaka AT wso2.com **P: +1 408 754 7388; ext: 51736*; *M: +94 77 322 1818 Linked-In: http://linkedin.com/in/senakafernando *Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
