Hi Here is the summery of code review noted. following changes are required in future
1). Change the api(method names) of the EnvironmentBuilder to improve userbility 2). Remove product specific method names and pass a parameter(Like product name) to a method to get the product configuration from api 3). Rename the class ManageEnvironment according to java convention 4). use xml file for user and tenant list instead of text file to describe user levels and permissions properly 5). Introduce generic methods to setting product configuration in EnvironmentBuilder 6). Remove Setter classes and introduced one generic class to set product configuraion 7). Refactor utility package names. there are some utility packages in util package 8). Remove DBManagerClasses specified for particular database like MySqlDatabaseManager 9). keep static and dynamic configuration separately (product configuration and sessionCookie) 10). change getUser() method parameter to proper one which describe user level instead of passing a pre-defined number Thanks Nuwanw On Tue, Jan 22, 2013 at 7:15 PM, Dharshana Warusavitharana < [email protected]> wrote: > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=c2VuZmFydW5jZnFwZmE4ZHQ1bGhhbWllN2sgbnV3YW53QHdzbzIuY29t&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQyNTBmN2E3OGQ3ZjA1ODQ4MDE5YmViYzFmYTEzNWE3YjA4NmYyZDA&ctz=Asia/Colombo&hl=en> > Code review - Automation Framework, Environment Builder > Automation Framework , Environment Builder Code Review > Crusible link is available on [1]. > > [1]. > http://wso2.org/crucible/cru/WTF001-7<http://www.google.com/url?q=http%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FWTF001-7&ust=1358869536329000&usg=AFQjCNG1C4Cbgb51sRLkp1omKSBmGsD6jA> > > Thank You, > Dharshana. > > *When* > ********Mon Jan 28, 2013 2:30pm – 3:30pm Colombo > *Where* > LK #59 2nd Floor Room > (map<http://maps.google.lk/maps?q=LK+%2359+2nd+Floor+Room&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > Dharshana Warusavitharana - organizer > • > Chamara Silva > • > Amila Maha Arachchi > • > Pradeep Fernando > • > Randika Ratnayake > • > Nuwan Wimalasekara > • > Sameera Jayasoma > • > [email protected] > • > Amila Suriarachchi > • > Krishantha Samaraweera > • > Damitha Kumarage > • > Dimuthu De Lanerolle > > Going? > ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=c2VuZmFydW5jZnFwZmE4ZHQ1bGhhbWllN2sgbnV3YW53QHdzbzIuY29t&rst=1&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQyNTBmN2E3OGQ3ZjA1ODQ4MDE5YmViYzFmYTEzNWE3YjA4NmYyZDA&ctz=Asia/Colombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=c2VuZmFydW5jZnFwZmE4ZHQ1bGhhbWllN2sgbnV3YW53QHdzbzIuY29t&rst=3&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQyNTBmN2E3OGQ3ZjA1ODQ4MDE5YmViYzFmYTEzNWE3YjA4NmYyZDA&ctz=Asia/Colombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=c2VuZmFydW5jZnFwZmE4ZHQ1bGhhbWllN2sgbnV3YW53QHdzbzIuY29t&rst=2&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQyNTBmN2E3OGQ3ZjA1ODQ4MDE5YmViYzFmYTEzNWE3YjA4NmYyZDA&ctz=Asia/Colombo&hl=en> > * **more options > »<https://www.google.com/calendar/event?action=VIEW&eid=c2VuZmFydW5jZnFwZmE4ZHQ1bGhhbWllN2sgbnV3YW53QHdzbzIuY29t&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQyNTBmN2E3OGQ3ZjA1ODQ4MDE5YmViYzFmYTEzNWE3YjA4NmYyZDA&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Nuwan Wimalasekara Software Engineer - Test Automation WSO2, Inc.: http://wso2.com lean. enterprise. middleware phone: +94 71 668 4620
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
