Hi Isabelle, Pradeep,
On Fri, Feb 22, 2013 at 3:15 PM, Isabelle Mauny <[email protected]> wrote: > Dileepa, > > Does that mean that the entry will only be there if we've been able to > validate the connection to it ? > Yes, it will be added only if the repository is valid and available. > When are we validating this , each time we start the server ? > Default repository is not loaded at server-startup, but in feature-manager index.jsp [1] when we load feature-manager UI. (This is where we load all repositories currently added). Here I do a service-call to load the default-repository, and at the BE, it calls RepositoryUtils[1] addRepository() which will add the repository if it's not added already. When adding a repository P2 validates the given repository URL and if it can't connect to the repository, it throws a ProvisioningException, if that's the case the repo will not be added to the list of available repositories. Thanks, Dileepa [1] https://svn.wso2.org/repos/wso2/carbon/kernel/trunk/core/feature-manager/org.wso2.carbon.feature.mgt.ui/src/main/resources/web/feature-mgt/index.jsp [2] https://svn.wso2.org/repos/wso2/carbon/kernel/trunk/core/feature-manager/org.wso2.carbon.feature.mgt.core/src/main/java/org/wso2/carbon/feature/mgt/core/util/RepositoryUtils.java > Isabelle. > __________________________________________________ > > *Isabelle Mauny > *Director, Product Management; WSO2, Inc.; http://wso2.com/ > email: [email protected] - mobile (Spain) : +34 616050684 - mobile (Sri > Lanka) +94 (0)774777663 > > * > * > > On Feb 21, 2013, at 8:52 PM, Dileepa Jayakody wrote: > > > > On Wed, Feb 20, 2013 at 5:13 PM, Dileepa Jayakody <[email protected]>wrote: > >> >> >> On Wed, Feb 20, 2013 at 4:31 PM, Pradeep Fernando <[email protected]>wrote: >> >>> I dont think we should load the repository during startup. Provisioning >>> is not a requirement for server startup. The default URL appearing in the >>> feature repository textbox is good enought IMHO. >>> >>> Yes, I see the point. I'll just update the sample URL text in feature >> manager UI accordingly. >> > > On second thought; as per the initial requirement of having a default > per-configured feature repository with carbon, just having the repo-url > defined in the carbon.xml appear as the sample URL text wouldn't be enough > I think. > So I loaded the per-configured repo in feature-manager UI when listing > available repositories. > Since adding a pre-defined repository is not mandatory for feature-manager > functionality, if any error occurs while trying to load the predefined repo > (say it's not available or hosted) error will be ignored and the repo-url > will not be added to the list. > > Thanks, > Dileepa > >> >> Thanks, >> Dileepa >> >>> --Pradeep >>> >>> >>> On Wed, Feb 20, 2013 at 4:26 PM, Dileepa Jayakody <[email protected]>wrote: >>> >>>> >>>> >>>> On Wed, Feb 20, 2013 at 11:18 AM, Pradeep Fernando <[email protected]>wrote: >>>> >>>>> Since we are giving carbon.version during the product build time, how >>>>> about having, >>>>> >>>>> http://dist.wso2.org/p2/carbon/releases/${carbon.version} >>>>> <http://dist.wso2.org/p2/carbon/releases/4.0.5> >>>>> >>>>> as the default. Maven filters will replace the value. >>>>> >>>> +1. >>>> Also if the repository isn't hosted/available, I think we should not >>>> give an error at startup trying to load the given repository, and continue >>>> startup without a default repository. >>>> >>>> Having said that, i don't see anything wrong with your approach as >>>>> well, just want to avoid configs if possible. >>>>> >>>> >>>>> --Pradeep >>>>> >>>>> >>>>> On Wed, Feb 20, 2013 at 1:43 AM, Dileepa Jayakody <[email protected]>wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> Configuring a default feature repository in Carbon has been a >>>>>> requirement for sometime now. >>>>>> >>>>>> We can do this by having an entry in carbon.xml like below and load >>>>>> the given repo by default in feature manager; >>>>>> >>>>>> <FeatureRepository> >>>>>> <RepositoryName>default repository</RepositoryName> >>>>>> <RepositoryURL>http://dist.wso2.org/p2/carbon/releases/4.0.5 >>>>>> </RepositoryURL> >>>>>> </FeatureRepository> >>>>>> >>>>>> I have done the necessary changes locally, is it good to commit this >>>>>> to trunk now and make it available in future releases? >>>>>> >>>>>> Thanks, >>>>>> Dileepa >>>>>> -- >>>>>> Dileepa Jayakody, >>>>>> Software Engineer, WSO2 Inc. >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> Mobile : +94777-857616 >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Pradeep Fernando* >>>>> Member, Management Committee - Platform & Cloud Technologies >>>>> Senior Software Engineer;WSO2 Inc.; http://wso2.com >>>>> >>>>> blog: http://pradeepfernando.blogspot.com >>>>> m: +94776603662 >>>>> >>>> >>>> >>>> >>>> -- >>>> Dileepa Jayakody, >>>> Software Engineer, WSO2 Inc. >>>> Lean . Enterprise . Middleware >>>> >>>> Mobile : +94777-857616 >>>> >>> >>> >>> >>> -- >>> *Pradeep Fernando* >>> Member, Management Committee - Platform & Cloud Technologies >>> Senior Software Engineer;WSO2 Inc.; http://wso2.com >>> >>> blog: http://pradeepfernando.blogspot.com >>> m: +94776603662 >>> >> >> >> >> -- >> Dileepa Jayakody, >> Software Engineer, WSO2 Inc. >> Lean . Enterprise . Middleware >> >> Mobile : +94777-857616 >> > > > > -- > Dileepa Jayakody, > Software Engineer, WSO2 Inc. > Lean . Enterprise . Middleware > > Mobile : +94777-857616 > > > -- Dileepa Jayakody, Software Engineer, WSO2 Inc. Lean . Enterprise . Middleware Mobile : +94777-857616
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
