Great progress. Lets have another review once all these done. thanks, Amila.
On Tue, Mar 12, 2013 at 11:11 PM, Dharshana Warusavitharana < [email protected]> wrote: > Hi, > > Please find inline progress statemets. > > - In NodeReader class, read the platform first and then get the nodes. > -Done > - endPointElment in NOdeReader class should be renamed to improve > readability.- Done > - Use proper names in cluster.xml file - nodelist should be changed. -- > This is changeable product Constant- ProductConstants- NODE_FILE_NAME > - careful about idea warnings. -- Fixed + FingBugs > - Remove IS_PRIMARY variable in NodeReader class. -- Done > - Use proper variable and class names that is self explanatory. > ----Further checking on this--- > - Remove legacy codes in EnvironmentBuider class. - Depreciated Class > no longer bind with the main code. > > > Thank You, > Dharshana. > > > On Thu, Feb 28, 2013 at 3:34 PM, Krishantha Samaraweera < > [email protected]> wrote: > >> Code review notes. >> >> - In NodeReader class, read the platform first and then get the nodes. >> - endPointElment in NOdeReader class should be renamed to improve >> readability. >> - Use proper names in cluster.xml file - nodelist should be changed. >> - careful about idea warnings. >> - Remove IS_PRIMARY variable in NodeReader class. >> - Use proper variable and class names that is self explanatory. >> - Remove legacy codes in EnvironmentBuider class. >> >> Thanks, >> Krishantha. >> >> On Wed, Feb 27, 2013 at 5:17 PM, Dharshana Warusavitharana < >> [email protected]> wrote: >> >>> more details >>> »<https://www.google.com/calendar/event?action=VIEW&eid=dGJlNmI3dWpjcWZwdmlwcmw2OGllaTg0bzAga3Jpc2hhbnRoYUB3c28yLmNvbQ&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQxMDY0ZDcyNmEyMDE5MTI2ZjI5NjI4N2Y1YmY3ZTkwYjkzMzcwYTQ&ctz=Asia/Colombo&hl=en> >>> Invitation: Code review - Automation Framework ,Context provider API >>> Code review , Reviewing the overall code layout of new implementation of >>> the Environment builder module in Clarity Framework. >>> Please find the crucible project from [1]. >>> >>> [1]. >>> http://wso2.org/crucible/cru/WTF001-9#<http://www.google.com/url?q=http%3A%2F%2Fwso2.org%2Fcrucible%2Fcru%2FWTF001-9%23&ust=1361972857067000&usg=AFQjCNFsS1vRMRpHQj4PZrOlneP3DtruHQ> >>> >>> Thank You, >>> Dharshana. >>> >>> *When* >>> ********Thu Feb 28, 2013 1:30pm – 2:30pm Colombo >>> *Where* >>> LK #59 2nd Floor Room >>> (map<http://maps.google.lk/maps?q=LK+%2359+2nd+Floor+Room&hl=en> >>> ) >>> *Calendar* >>> [email protected] >>> *Who* >>> • >>> Dharshana Warusavitharana - organizer >>> • >>> Chamara Silva >>> • >>> Amila Maha Arachchi >>> • >>> Randika Ratnayake >>> • >>> Pradeep Fernando >>> • >>> Nuwan Wimalasekara >>> • >>> Sameera Jayasoma >>> • >>> [email protected] >>> • >>> Amila Suriarachchi >>> • >>> Krishantha Samaraweera >>> • >>> Dimuthu De Lanerolle >>> • >>> Damitha Kumarage >>> >>> Going? >>> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=dGJlNmI3dWpjcWZwdmlwcmw2OGllaTg0bzAga3Jpc2hhbnRoYUB3c28yLmNvbQ&rst=1&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQxMDY0ZDcyNmEyMDE5MTI2ZjI5NjI4N2Y1YmY3ZTkwYjkzMzcwYTQ&ctz=Asia/Colombo&hl=en>- >>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=dGJlNmI3dWpjcWZwdmlwcmw2OGllaTg0bzAga3Jpc2hhbnRoYUB3c28yLmNvbQ&rst=3&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQxMDY0ZDcyNmEyMDE5MTI2ZjI5NjI4N2Y1YmY3ZTkwYjkzMzcwYTQ&ctz=Asia/Colombo&hl=en>- >>> No<https://www.google.com/calendar/event?action=RESPOND&eid=dGJlNmI3dWpjcWZwdmlwcmw2OGllaTg0bzAga3Jpc2hhbnRoYUB3c28yLmNvbQ&rst=2&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQxMDY0ZDcyNmEyMDE5MTI2ZjI5NjI4N2Y1YmY3ZTkwYjkzMzcwYTQ&ctz=Asia/Colombo&hl=en> >>> * **more options >>> »<https://www.google.com/calendar/event?action=VIEW&eid=dGJlNmI3dWpjcWZwdmlwcmw2OGllaTg0bzAga3Jpc2hhbnRoYUB3c28yLmNvbQ&tok=MTkjZGhhcnNoYW5hd0B3c28yLmNvbWQxMDY0ZDcyNmEyMDE5MTI2ZjI5NjI4N2Y1YmY3ZTkwYjkzMzcwYTQ&ctz=Asia/Colombo&hl=en> >>> >>> Invitation from Google Calendar <https://www.google.com/calendar/> >>> >>> You are receiving this email at the account [email protected] because >>> you are subscribed for invitations on calendar [email protected]. >>> >>> To stop receiving these notifications, please log in to >>> https://www.google.com/calendar/ and change your notification settings >>> for this calendar. >>> >> >> > > > -- > > Dharshana Warusavitharana > Software Engineer , Test Automation > WSO2 Inc. http://wso2.com > email : [email protected] <[email protected]> > cell : +94772202595 > blog : http://dharshanaw.blogspot.com > > lean . enterprise . middleware > -- *Amila Suriarachchi* Software Architect WSO2 Inc. ; http://wso2.com lean . enterprise . middleware phone : +94 71 3082805
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
