On Fri, Mar 22, 2013 at 9:12 AM, Isuru Perera <[email protected]> wrote:
> > > > On Fri, Mar 22, 2013 at 3:42 AM, Nirmal Fernando <[email protected]> wrote: > >> Hi IsuruP, >> >> I don't think we should mandate the "displayName" element. This adds more >> pain to the person who configures. I was against adding more elements to >> the cartridge xml file , unless they are really necessary. >> > >> So my suggestion: >> >> Make "displayName" optional, and change the code accordingly, so that if >> some one doesn't specify a "displayName", we use cartridge "type" as the >> display name. >> > > displayName element is already optional. But display name is required for > CLI and UI. That's a way we can give a meaningful name to the cartridge. I > think this is what we agreed during JIRA reviews. But as you said, we can > display type if the displayName element is missing. > > >> On Wed, Mar 20, 2013 at 9:17 PM, Nirmal Fernando <[email protected]> wrote: >> >>> Patch to CC looks good, only minor improvement would be to change the >>> "multiTenant" attribute to "isMultiTenant". >>> >> >> Also the above suggestion, to make it more intuitive for the user. >> > > I think the attribute "multiTenant" is more appropriate than > "isMultiTenant". Doesn't it imply a boolean value when we say > "multi-tenant"? > It may imply. But a much better practice is to use isMultiTenant. In our code bases we try to adhere to that pattern as much as possible (it improves readability of the code). > > >> >>> And in this revision I can't see the test resources ? Did you guys >>> forget to commit them? >>> >>> >>> On Wed, Mar 20, 2013 at 9:06 PM, Isuru Perera <[email protected]> wrote: >>> >>>> :) >>>> >>>> Check this revision. >>>> http://wso2.org/svn/browse/wso2?revision=168577&view=revision >>>> >>>> >>>> On Thu, Mar 21, 2013 at 9:35 AM, Nirmal Fernando <[email protected]>wrote: >>>> >>>>> >>>>> >>>>> >>>>> On Wed, Mar 20, 2013 at 9:04 PM, Isuru Perera <[email protected]> wrote: >>>>> >>>>>> Yes. Schema files were updated and I tested in my local VM with >>>>>> earlier Beta-1 packs. >>>>>> >>>>> >>>>> Cool. >>>>> >>>>>> But we couldn't test with new packs yet. >>>>>> >>>>>> >>>>>> On Thu, Mar 21, 2013 at 9:30 AM, Nirmal Fernando <[email protected]>wrote: >>>>>> >>>>>>> >>>>>>> Did you all change the relevant XML schema files? And documentation >>>>>>> should also need to be updated. >>>>>>> >>>>>>> >>>>>>> On Wed, Mar 20, 2013 at 8:55 PM, Isuru Perera <[email protected]>wrote: >>>>>>> >>>>>>>> Yes. Reka committed those files yesterday. >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Mar 21, 2013 at 9:17 AM, Nirmal Fernando >>>>>>>> <[email protected]>wrote: >>>>>>>> >>>>>>>>> Are those committed? >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Mar 20, 2013 at 5:55 PM, Isuru Perera <[email protected]>wrote: >>>>>>>>> >>>>>>>>>> Yes Nirmal. >>>>>>>>>> >>>>>>>>>> There are changes in CC component >>>>>>>>>> On Mar 21, 2013 4:44 AM, "Nirmal Fernando" <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi IsuruP, >>>>>>>>>>> >>>>>>>>>>> This patch implies that there's a code change in CC side. Am I >>>>>>>>>>> right? >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Wed, Mar 20, 2013 at 12:01 PM, Isuru Perera >>>>>>>>>>> <[email protected]>wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi all, >>>>>>>>>>>> >>>>>>>>>>>> Apply patch from >>>>>>>>>>>> https://svn.wso2.org/repos/wso2/carbon/platform/branches/4.1.0/build/stratos2/setup/cartridges >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Isuru Perera >>>>>>>>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ >>>>>>>>>>>> Lean . Enterprise . Middleware >>>>>>>>>>>> >>>>>>>>>>>> Twitter: http://twitter.com/chrishantha | LinkedIn: >>>>>>>>>>>> http://lk.linkedin.com/in/chrishantha/ >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> Thanks & regards, >>>>>>>>>>> Nirmal >>>>>>>>>>> >>>>>>>>>>> Software Engineer- Platform Technologies Team, WSO2 Inc. >>>>>>>>>>> Mobile: +94715779733 >>>>>>>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>>>>>>> >>>>>>>>>>> <http://nirmalfdo.blogspot.com/> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Thanks & regards, >>>>>>>>> Nirmal >>>>>>>>> >>>>>>>>> Software Engineer- Platform Technologies Team, WSO2 Inc. >>>>>>>>> Mobile: +94715779733 >>>>>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>>>>> >>>>>>>>> <http://nirmalfdo.blogspot.com/> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Isuru Perera >>>>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ >>>>>>>> Lean . Enterprise . Middleware >>>>>>>> >>>>>>>> Twitter: http://twitter.com/chrishantha | LinkedIn: >>>>>>>> http://lk.linkedin.com/in/chrishantha/ >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & regards, >>>>>>> Nirmal >>>>>>> >>>>>>> Software Engineer- Platform Technologies Team, WSO2 Inc. >>>>>>> Mobile: +94715779733 >>>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>>> >>>>>>> <http://nirmalfdo.blogspot.com/> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Isuru Perera >>>>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> Twitter: http://twitter.com/chrishantha | LinkedIn: >>>>>> http://lk.linkedin.com/in/chrishantha/ >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Thanks & regards, >>>>> Nirmal >>>>> >>>>> Software Engineer- Platform Technologies Team, WSO2 Inc. >>>>> Mobile: +94715779733 >>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>> >>>>> <http://nirmalfdo.blogspot.com/> >>>>> >>>> >>>> >>>> >>>> -- >>>> Isuru Perera >>>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/ >>>> Lean . Enterprise . Middleware >>>> >>>> Twitter: http://twitter.com/chrishantha | LinkedIn: >>>> http://lk.linkedin.com/in/chrishantha/ >>>> >>> >>> >>> >>> -- >>> >>> Thanks & regards, >>> Nirmal >>> >>> Software Engineer- Platform Technologies Team, WSO2 Inc. >>> Mobile: +94715779733 >>> Blog: http://nirmalfdo.blogspot.com/ >>> >>> <http://nirmalfdo.blogspot.com/> >>> >> >> >> >> -- >> >> Thanks & regards, >> Nirmal >> >> Software Engineer- Platform Technologies Team, WSO2 Inc. >> Mobile: +94715779733 >> Blog: http://nirmalfdo.blogspot.com/ >> >> <http://nirmalfdo.blogspot.com/> >> > > > > -- > Isuru Perera > Senior Software Engineer | WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > Twitter: http://twitter.com/chrishantha | LinkedIn: > http://lk.linkedin.com/in/chrishantha/ > -- *Amila Maharachchi* Technical Lead Member, Management Committee - Cloud & Platform TG WSO2, Inc.; http://wso2.com Blog: http://maharachchi.blogspot.com Mobile: +94719371446
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
