On Tue, Apr 30, 2013 at 11:22 PM, Krishantha Samaraweera < [email protected]> wrote:
> Please find code review notes below. > > 1. strato.test property need to be removed from automation.properties > 2. Use product as the execution environment rather using integration. > 3. Remove product list from automation.properties > 4. In instance.xml use name attribute instead of ID > 5. In instance.xml under Ib tag use following attributes. > <instance name = "worker"> > <instance name = "manager"> > 6. getNode should be changed as getInstance or getEngagedEnvronment. > 7. In GroupContext class don't use arraylist/concrete types > > Thanks, > Krishantha. > > On Mon, Apr 29, 2013 at 2:20 PM, Dharshana Warusavitharana < > [email protected]> wrote: > >> Hi All, >> Please find Crucible review project from [1]. >> >> [1].http://wso2.org/crucible/cru/WTF001-12 >> >> Thank You, >> Dharshana >> >> >> On Fri, Apr 26, 2013 at 2:05 PM, Krishantha Samaraweera < >> [email protected]> wrote: >> >>> more details >>> »<https://www.google.com/calendar/event?action=VIEW&eid=bzR0MGRuYzNrZ2IxdnNicXE4cm81NHNxZ2cgZGhhcnNoYW5hd0B3c28yLmNvbQ&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbTA5MWYyNWFjYWFmYWNiNDc0MmU3ZWQ2OTNlMTgwOTVhOGRjYWRmYmY&ctz=Asia/Colombo&hl=en> >>> Code review - New Context provider API of Automation Framework >>> Code review to finalize the new context provider API. We will >>> demonstrate usage of new framework API by demonstrating test cases written >>> for different test execution platforms. >>> >>> Will send the crucible link later. >>> *When* >>> ********Tue Apr 30, 2013 2:30pm – 3:30pm Colombo >>> *Where* >>> LK #58 4th Floor Meeting room >>> (map<http://maps.google.lk/maps?q=LK+%2358+4th+Floor+Meeting+room&hl=en> >>> ) >>> *Calendar* >>> [email protected] >>> *Who* >>> • >>> Krishantha Samaraweera - organizer >>> • >>> Amila Maha Arachchi >>> • >>> Dharshana Warusavitharana >>> • >>> Pradeep Fernando >>> • >>> Randika Ratnayake >>> • >>> [email protected] >>> • >>> Amila Suriarachchi >>> • >>> Nuwan Wimalasekara >>> • >>> Dimuthu De Lanerolle >>> >>> Going? >>> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=bzR0MGRuYzNrZ2IxdnNicXE4cm81NHNxZ2cgZGhhcnNoYW5hd0B3c28yLmNvbQ&rst=1&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbTA5MWYyNWFjYWFmYWNiNDc0MmU3ZWQ2OTNlMTgwOTVhOGRjYWRmYmY&ctz=Asia/Colombo&hl=en>- >>> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=bzR0MGRuYzNrZ2IxdnNicXE4cm81NHNxZ2cgZGhhcnNoYW5hd0B3c28yLmNvbQ&rst=3&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbTA5MWYyNWFjYWFmYWNiNDc0MmU3ZWQ2OTNlMTgwOTVhOGRjYWRmYmY&ctz=Asia/Colombo&hl=en>- >>> No<https://www.google.com/calendar/event?action=RESPOND&eid=bzR0MGRuYzNrZ2IxdnNicXE4cm81NHNxZ2cgZGhhcnNoYW5hd0B3c28yLmNvbQ&rst=2&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbTA5MWYyNWFjYWFmYWNiNDc0MmU3ZWQ2OTNlMTgwOTVhOGRjYWRmYmY&ctz=Asia/Colombo&hl=en> >>> * **more options >>> »<https://www.google.com/calendar/event?action=VIEW&eid=bzR0MGRuYzNrZ2IxdnNicXE4cm81NHNxZ2cgZGhhcnNoYW5hd0B3c28yLmNvbQ&tok=MTkja3Jpc2hhbnRoYUB3c28yLmNvbTA5MWYyNWFjYWFmYWNiNDc0MmU3ZWQ2OTNlMTgwOTVhOGRjYWRmYmY&ctz=Asia/Colombo&hl=en> >>> >>> Invitation from Google Calendar <https://www.google.com/calendar/> >>> >>> You are receiving this email at the account [email protected] because >>> you are subscribed for invitations on calendar [email protected]. >>> >>> To stop receiving these notifications, please log in to >>> https://www.google.com/calendar/ and change your notification settings >>> for this calendar. >>> >> >> >> >> -- >> >> Dharshana Warusavitharana >> Software Engineer , Test Automation >> WSO2 Inc. http://wso2.com >> email : [email protected] <[email protected]> >> cell : +94772202595 >> blog : http://dharshanaw.blogspot.com >> >> lean . enterprise . middleware >> > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
