Hi Ravi, On Tue, Apr 16, 2013 at 2:46 PM, Sagara Gunathunga <sag...@wso2.com> wrote:
> > > > > On Tue, Apr 16, 2013 at 1:08 PM, Ravi Undupitiya <r...@wso2.com> wrote: > >> Hello, >> >> >> I'm trying to move the multipart/from-data builder to work without the >> use of Servlets so that this format can be used in the regular transports. >> >> To do this, I implemented a class of the apache commons-fileupload >> RequestContext which requires the following: >> >> 1.) Raw input stream. >> 2.) Content length. >> 3.) Charset encoding. >> >> I had an offline chat with Sagara regarding this and he recommended we >> set 2 and 3 inside the transports and that builders are meant to look up >> this information using the message context. >> > > Other than the issue you are trying fix there is another design problem > with above builder class, it use some HTTPServlet specific codes within the > builder class which result into builder only usable with Servlet transport > only. Basically Builders/Formatters are independent from any transport. As > I mentioned following should be the correct approach. > > 1. Remove those Servlet specific ( or any other transport specific) code > from above builder class instead builder methods should try to get above 3 > properties from MC if not found them on MC throw an exception. You don't > need to introduce new class for this. > > 2. Underline transport should read above 2 or 3 values from transport > headers and should write to MC so that builder can use those values. > > You need to test your modifications for both NHTTP and Servlet > transports. Also make sure to merge this change to current active branch > as well. > Have we committed these changes to current branch? > > > Thanks ! > > >> >> So to start, I will add 2 and 3 to the message context inside the Axis2 >> HTTP transport. >> >> Please advise if there are any problems with what is proposed above. >> >> >> >> Thanks, >> Ravi >> >> -- >> *Ravi Undupitiya* >> Software Engineer; WSO2 Inc.; http://wso2.com >> * >> * >> *E-mail: r...@wso2.com >> **M: **+94 772 930 712* >> * >> *Lean . Enterprise . Middleware >> > > > > -- > Sagara Gunathunga > > Technical Lead; WSO2, Inc.; http://wso2.com > V.P Apache Web Services; http://ws.apache.org/ > Linkedin; http://www.linkedin.com/in/ssagara > Blog ; http://ssagara.blogspot.com > > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
