On Mon, May 20, 2013 at 2:41 PM, <[email protected]> wrote:

> Author: [email protected]
> Date: Mon May 20 14:41:07 2013
> New Revision: 172852
> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=172852
>
> Log:
> refactoring group management agent resetting part
>
> Modified:
>
>  
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/builder/TopologySyncher.java
>
>  
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/group/mgt/GroupMgtAgentBuilder.java
>
> Modified:
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/builder/TopologySyncher.java
> URL:
> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/builder/TopologySyncher.java?rev=172852&r1=172851&r2=172852&view=diff
>
> ==============================================================================
> ---
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/builder/TopologySyncher.java
>        (original)
> +++
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/builder/TopologySyncher.java
>        Mon May 20 14:41:07 2013
> @@ -94,7 +94,7 @@
>                  if(!currentServiceConfigs.contains(oldServiceConfig)){
>                      // if the ServiceConfiguration is not there any more
> in the latest topology
>
>  lbConfig.removeServiceConfiguration(oldServiceConfig.getDomain(),
> oldServiceConfig.getSubDomain());
> -
>  GroupMgtAgentBuilder.removeGroupMgtAgent(oldServiceConfig.getDomain(),
> oldServiceConfig.getSubDomain());
> +
>  GroupMgtAgentBuilder.resetGroupMgtAgent(oldServiceConfig.getDomain(),
> oldServiceConfig.getSubDomain());
>                  }
>              }
>          }
>
> Modified:
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/group/mgt/GroupMgtAgentBuilder.java
> URL:
> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/group/mgt/GroupMgtAgentBuilder.java?rev=172852&r1=172851&r2=172852&view=diff
>
> ==============================================================================
> ---
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/group/mgt/GroupMgtAgentBuilder.java
> (original)
> +++
> carbon/platform/branches/4.1.0/components/load-balancer/lb-endpoint/org.wso2.carbon.lb.endpoint/4.1.3/src/main/java/org/wso2/carbon/lb/endpoint/group/mgt/GroupMgtAgentBuilder.java
> Mon May 20 14:41:07 2013
> @@ -41,7 +41,7 @@
>          }
>      }
>
> -    public static void removeGroupMgtAgent(String domain, String
> subDomain) {
> +    public static void resetGroupMgtAgent(String domain, String
> subDomain) {
>
>          ClusteringAgent clusteringAgent =
>
>  ConfigHolder.getInstance().getAxisConfiguration().getClusteringAgent();
> @@ -53,7 +53,7 @@
>          // checks the existence.
>          if (clusteringAgent.getGroupManagementAgent(domain, subDomain) !=
> null) {
>
> -            clusteringAgent.removeGroupManagementAgent(domain, subDomain);
> +            clusteringAgent.resetGroupManagementAgent(domain, subDomain);
>

This can be easily changed to;
clusteringAgent.getGroupManagementAgent(domain, subDomain).reset();

clusteringAgent.getGroupManagementAgent(domain, subDomain) can be stored in
a variable to avoid a double map lookup.


>
>              log.info("Group management agent of cluster domain: " +
>                  domain + " and sub domain: " + subDomain+" is removed.");
> _______________________________________________
> Commits mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/commits
>



-- 
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/
* <http://www.apache.org/>**
email: **[email protected]* <[email protected]>* cell: +94 77 3320919
blog: **http://blog.afkham.org* <http://blog.afkham.org>*
twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
*
linked-in: **http://lk.linkedin.com/in/afkhamazeez*
*
*
*Lean . Enterprise . Middleware*
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to