Hi, Some methods may have been used by third parties.. for eg: we can access these methods (UserStoreManager, etc) via osgi services within webapps. We need to think about that aspect also. I'm not saying we shouldn't remove. But we need to think if that would be used and if there is no other way to do that for third parties..
thanks, On Thu, Jul 11, 2013 at 2:25 PM, Amila Maha Arachchi <[email protected]>wrote: > > > > On Thu, Jul 11, 2013 at 12:47 PM, Amila Suriarachchi <[email protected]>wrote: > >> >> >> >> On Thu, Jul 11, 2013 at 10:29 AM, Amila Maha Arachchi <[email protected]>wrote: >> >>> Hi Asela, >>> >>> >>> On Thu, Jul 11, 2013 at 10:06 AM, Asela Pathberiya <[email protected]>wrote: >>> >>>> Hi All, >>>> >>>> I am not sure why we are keeping following method in the API... Sorry, >>>> if i have missed any thing.... If there are on any usage, we can remove >>>> them... >>>> >>>> 1. String[] getAllSecondaryRoles() >>>> >>>> Why we need only the roles of secondary user store? >>>> >>>> 2. int getTenantId(String username) >>>> >>>> Once user is authenticated, we knows the tenant Id. Else why we need >>>> to get the tenant id of a user who is not in its tenant space ? >>>> >>> >>> There are places which we need to get the tenant id of a particular >>> tenant by providing the tenant domain. In this case, tenant is not logged >>> in. So, this is useful. >>> >> >> This method is getting the tenant id from user name. Always from the >> user name we should be able to derive the tenant domain. For tenant domain >> we can get the tenant id. Anyway this is not required at user store api >> level. >> > > Aah yes. Didnt notice it was the username. Yes, getting the tenant id by > providing tenant domain is enough. > >> >> thanks, >> Amila. >> >>> >>> Regards, >>> AmilaM. >>> >>>> >>>> 3. int getUserId(String username) >>>> >>>> What is the use of user id? It seems to this is auto increment value >>>> of UM_USER table >>>> >>>> 4. int getTenantId() >>>> >>>> I guess, tenant Id is not need to expose via user store manager API, >>>> it is available with carbon context >>>> >>>> Thanks, >>>> Asela. >>>> >>>> -- >>>> Thanks & Regards, >>>> Asela >>>> >>>> Mobile : +94 777 625 933 >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Amila Maharachchi* >>> Senior Technical Lead >>> WSO2, Inc.; http://wso2.com >>> >>> Blog: http://maharachchi.blogspot.com >>> Mobile: +94719371446 >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Amila Suriarachchi* >> >> Software Architect >> WSO2 Inc. ; http://wso2.com >> lean . enterprise . middleware >> >> phone : +94 71 3082805 >> > > > > -- > *Amila Maharachchi* > Senior Technical Lead > WSO2, Inc.; http://wso2.com > > Blog: http://maharachchi.blogspot.com > Mobile: +94719371446 > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - [email protected] <[email protected]> mobile - 071 56 91 321
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
