Please find the code review notes for App Server integration test cases. Will update the crucible project once we sort out the problem with project indexing.
CommodityQuoteTestCase 1. Use proper class name in log initialization. 2. Don't use abbreviations or short names for variables, method names etc.. 3. Use test prefix for all test methods. 4. Use a static variable to hold service name. 5. Get the OM element of the response and assert rather getting child elements. 6. Include descriptive message in each assert statement. 7. Build the payload rather using hard coded request xml. 8. User AxiomUtils to convert string to OM instead of StXOMBuilder 9. Throw correct exception rather throwing EXCEPTION class in private methods. ThrottlingTestCase 1. Read local IP though java - InetAddress.getLocalHost() or NetworkInterface.getNetworkInterfaces() 2. Improve test case to check throttling policy engagement. 3. Disable throttling policy attached to service at the end of the tests. 4. User constants variables to hold IP/DOMAIN. 5. Don't use expected exception, catch the exception and assert for specific value. 6. User simple asserts rather asserting whole response from server. 7. Don't assert inside private methods, do it inside test methods. 8. Rename private methods - invokeService instead of Callservice 9. DenyDomain test case - set dummy domain instead of setting IP. 10. User meaningful variable names 11. To check Maximum Concurrent Accesses use LB_SERVICE instead of using echo service - LB_SERVICE is designed to test the concurrent access attempts 12. Change the logic used for testing prohibit time interval 13. Expected exception should be used carefully, don't continue the code after the code line which throws expected exception. Thanks, Krishantha. On Thu, Jul 18, 2013 at 5:10 PM, Dimuthu De Lanerolle <[email protected]>wrote: > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=MW8zbGtjNTk1ajdpbnZ0dWxlcmloajQ4dmsga3Jpc2hhbnRoYUB3c28yLmNvbQ&tok=MTcjZGltdXRodWRAd3NvMi5jb20zYWUzMjRmZGRlMDRlMDhjZDE3MDBhNWU0MTljMzUyMzUwNjE2ZmU3&ctz=Asia/Colombo&hl=en> > Code Review - AS > Please find the crucible link on [1] for AS code review > [1] > http://wso2.org/crucible/project/PROD002<https://www.google.com/url?q=http%3A%2F%2Fwso2.org%2Fcrucible%2Fproject%2FPROD002&ust=1374154803203000&usg=AFQjCNHuDK9NaM7XGQUyuAwunQvbqhLhiA> > *When* > ********Wed Jul 24, 2013 2:30pm – 3:30pm Colombo > *Where* > LK #58 5th Floor - Meeting room > (map<http://maps.google.lk/maps?q=LK+%2358+5th+Floor+-+Meeting+room&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > Dimuthu De Lanerolle - organizer > • > Dharshana Warusavitharana > • > Randika Ratnayake > • > [email protected] > • > Nuwan Wimalasekara > • > Krishantha Samaraweera > > Going? > ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=MW8zbGtjNTk1ajdpbnZ0dWxlcmloajQ4dmsga3Jpc2hhbnRoYUB3c28yLmNvbQ&rst=1&tok=MTcjZGltdXRodWRAd3NvMi5jb20zYWUzMjRmZGRlMDRlMDhjZDE3MDBhNWU0MTljMzUyMzUwNjE2ZmU3&ctz=Asia/Colombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=MW8zbGtjNTk1ajdpbnZ0dWxlcmloajQ4dmsga3Jpc2hhbnRoYUB3c28yLmNvbQ&rst=3&tok=MTcjZGltdXRodWRAd3NvMi5jb20zYWUzMjRmZGRlMDRlMDhjZDE3MDBhNWU0MTljMzUyMzUwNjE2ZmU3&ctz=Asia/Colombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=MW8zbGtjNTk1ajdpbnZ0dWxlcmloajQ4dmsga3Jpc2hhbnRoYUB3c28yLmNvbQ&rst=2&tok=MTcjZGltdXRodWRAd3NvMi5jb20zYWUzMjRmZGRlMDRlMDhjZDE3MDBhNWU0MTljMzUyMzUwNjE2ZmU3&ctz=Asia/Colombo&hl=en> > * **more options > »<https://www.google.com/calendar/event?action=VIEW&eid=MW8zbGtjNTk1ajdpbnZ0dWxlcmloajQ4dmsga3Jpc2hhbnRoYUB3c28yLmNvbQ&tok=MTcjZGltdXRodWRAd3NvMi5jb20zYWUzMjRmZGRlMDRlMDhjZDE3MDBhNWU0MTljMzUyMzUwNjE2ZmU3&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because > you are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
