POX sec handler is not needed in the ELB
On Mon, Jul 29, 2013 at 11:12 AM, Piyum Fernando <[email protected]> wrote: > > > > On Mon, Jul 29, 2013 at 9:53 AM, Sameera Jayasoma <[email protected]>wrote: > >> I am reverting this patch for now. >> > > +1 for now. > But we need to look in to ELB. Above fix is kind of important and that > ensures the expected behaviour of POX security handler. > > Thanks. > > >> Sameera. >> >> >> On Mon, Jul 29, 2013 at 7:48 AM, Sameera Jayasoma <[email protected]>wrote: >> >>> Guys, this patch has broken ELB. ESB may also be affected. Please review >>> this commit and fix. >>> >>> Thanks, >>> Sameera. >>> >>> >>> On Thu, Jul 25, 2013 at 7:09 PM, <[email protected]> wrote: >>> >>>> Author: [email protected] >>>> Date: Thu Jul 25 19:09:31 2013 >>>> New Revision: 179033 >>>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=179033 >>>> >>>> Log: >>>> fixing IDENTITY-1161, patch provided by Piyum >>>> >>>> Modified: >>>> >>>> >>>> carbon/platform/trunk/components/security/org.wso2.carbon.security.mgt/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java >>>> >>>> Modified: >>>> carbon/platform/trunk/components/security/org.wso2.carbon.security.mgt/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java >>>> URL: >>>> http://wso2.org/svn/browse/wso2/carbon/platform/trunk/components/security/org.wso2.carbon.security.mgt/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java?rev=179033&r1=179032&r2=179033&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> carbon/platform/trunk/components/security/org.wso2.carbon.security.mgt/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java >>>> (original) >>>> +++ >>>> carbon/platform/trunk/components/security/org.wso2.carbon.security.mgt/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java >>>> Thu Jul 25 19:09:31 2013 >>>> @@ -91,9 +91,10 @@ >>>> } >>>> >>>> String basicAuthHeader = getBasicAuthHeaders(msgCtx); >>>> + >>>> //this handler only intercepts >>>> if (!(msgCtx.isDoingREST() || isSOAPWithoutSecHeader(msgCtx)) >>>> || >>>> - !msgCtx.getIncomingTransportName().equals("https") || >>>> (basicAuthHeader == null)) { >>>> + !msgCtx.getIncomingTransportName().equals("https")) { >>>> return InvocationResponse.CONTINUE; >>>> } >>>> >>>> _______________________________________________ >>>> Commits mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/commits >>>> >>> >>> >>> >>> -- >>> Sameera Jayasoma, >>> Architect, >>> >>> WSO2, Inc. (http://wso2.com) >>> email: [email protected] >>> blog: http://sameera.adahas.org >>> twitter: https://twitter.com/sameerajayasoma >>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >>> >>> Lean . Enterprise . Middleware >>> >> >> >> >> -- >> Sameera Jayasoma, >> Architect, >> >> WSO2, Inc. (http://wso2.com) >> email: [email protected] >> blog: http://sameera.adahas.org >> twitter: https://twitter.com/sameerajayasoma >> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >> >> Lean . Enterprise . Middleware >> > > > > -- > Piyum Fernando > Software Engineer > > Mobile: +94 77 22 93 880 > Home: +94 31 22 75 715 > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>** email: **[email protected]* <[email protected]>* cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org>* twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez* * * *Lean . Enterprise . Middleware*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
