*Code review notes for Event Formatter*
Participants : Mohan, Suho, Anjana, Lasantha, Rajeev, Inosh, Malith, Gihan
- EventSource interface - Method getStreamNames should be renamed
getStreamId.
- Information icon in UI to give a sample XML output mapping.
- NotDeployed rename to Inactive
- getNotDeployedEventFormatterConfigurationFiles: Return the file name
as a String
- Consider converting configuration object instance to XML at front-end
itself and send it to back end.
- Comments for interface methods.
- Check whether CarbonUtil methods are there for reading files directly.
Don't use custom implementations of our own
- For error messages use ('"<msg>:" + e.getMessage() , e) type of
syntax.
- Any literal constants : Define as constants in a common place and use.
- Return a source list for getEventSource method. Not a single event
source.
- Move common methods to abstract class in EventFormatter
- Come up with a better solution for factory class that builds the
formatter specific parts. Don't keep a reference inside configuration.
- EventFormatterFactory should be MapperFactory and do only mapping
specific stuff.
- Bring validations to a common place whenever possible.
@Suho,Mohan,Rajeev: Please add if i've missed anything.
Thanks,
Lasantha
On 9 August 2013 11:23, Mohanadarshan Vivekanandalingam <[email protected]>wrote:
> more details
> »<https://www.google.com/calendar/event?action=VIEW&eid=Z2IzYW1kN3JmaW8xcHJ1dWozZWhybHBvNm8gbGFzYW50aGFAd3NvMi5jb20&tok=MTQjbW9oYW5Ad3NvMi5jb21jZmZjNjExODUwZjVlZTNjZmE5MjUyYjk4MWE3MTk4ZjQ2NDFjYmY1&ctz=Asia/Colombo&hl=en_GB>
> Code Review - Event Builder & Event Formatter
> Crucible project can be found at
> http://wso2.org/crucible/project/WTC001<https://www.google.com/url?q=http%3A%2F%2Fwso2.org%2Fcrucible%2Fproject%2FWTC001&ust=1376034839369000&usg=AFQjCNHR5wlJ5sMO84K_1Zby3ckNFk_nYg>
> *When*
> ********Mon 12 Aug 2013 14:30 – 17:30 Colombo
> *Where*
> LK #58 4th Floor Meeting room
> (map<http://maps.google.lk/maps?q=LK+%2358+4th+Floor+Meeting+room&hl=en-GB>
> )
> *Calendar*
> [email protected]
> *Who*
> •
> Mohanadarshan Vivekanandalingam- organiser
> •
> Lasantha Fernando
> •
> Malith Dhanushka
> •
> Dunith Dhanushka
> •
> Balakrishnan Gokulakrishnan
> •
> Sriskandarajah Suhothayan
> •
> Ayashkantha Ramasinghe
> •
> Rajeev Sampath
> •
> Deepthi Peiris
> •
> Maninda Edirisooriya
> •
> Gihan Anuruddha
> •
> [email protected]
> •
> Sinthuja Ragendran
> •
> Inosh Goonewardena
> •
> Anjana Fernando
>
> Going?
> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=Z2IzYW1kN3JmaW8xcHJ1dWozZWhybHBvNm8gbGFzYW50aGFAd3NvMi5jb20&rst=1&tok=MTQjbW9oYW5Ad3NvMi5jb21jZmZjNjExODUwZjVlZTNjZmE5MjUyYjk4MWE3MTk4ZjQ2NDFjYmY1&ctz=Asia/Colombo&hl=en_GB>-
> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=Z2IzYW1kN3JmaW8xcHJ1dWozZWhybHBvNm8gbGFzYW50aGFAd3NvMi5jb20&rst=3&tok=MTQjbW9oYW5Ad3NvMi5jb21jZmZjNjExODUwZjVlZTNjZmE5MjUyYjk4MWE3MTk4ZjQ2NDFjYmY1&ctz=Asia/Colombo&hl=en_GB>-
> No<https://www.google.com/calendar/event?action=RESPOND&eid=Z2IzYW1kN3JmaW8xcHJ1dWozZWhybHBvNm8gbGFzYW50aGFAd3NvMi5jb20&rst=2&tok=MTQjbW9oYW5Ad3NvMi5jb21jZmZjNjExODUwZjVlZTNjZmE5MjUyYjk4MWE3MTk4ZjQ2NDFjYmY1&ctz=Asia/Colombo&hl=en_GB>
> * **more options
> »<https://www.google.com/calendar/event?action=VIEW&eid=Z2IzYW1kN3JmaW8xcHJ1dWozZWhybHBvNm8gbGFzYW50aGFAd3NvMi5jb20&tok=MTQjbW9oYW5Ad3NvMi5jb21jZmZjNjExODUwZjVlZTNjZmE5MjUyYjk4MWE3MTk4ZjQ2NDFjYmY1&ctz=Asia/Colombo&hl=en_GB>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this email at the account [email protected] because you
> are subscribed for invitations on calendar [email protected].
>
> To stop receiving these notifications, please log in to
> https://www.google.com/calendar/ and change your notification settings
> for this calendar.
>
--
*Lasantha Fernando*
Software Engineer - Data Technologies Team
WSO2 Inc. http://wso2.com
email: [email protected]
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
