Some of these comments can be entered in crucible IMO.
On Tue, Aug 13, 2013 at 11:57 AM, Lakmali Baminiwatta <[email protected]>wrote: > Hi All, > > Please find the review notes. > > Do the tier permission validation in APIStoreHostobject @addSubscription > as well, to handle direct Store API calls. > > Replace logic of comparison between current roles and defined roles with > Lists.retainAll(Collection<?> c) . > > For displaying default permissions, retrieve the everyone role name from > > ServiceReferenceHolder.getInstance().getRealmService().getBootstrapRealmConfiguration().getEveryOneRoleName(); > > Add a help tip to roles input. > > Keep denied tiers of the user in session > > Do a role validation in when defining Tier Permissions > > Add a new user permission and make Tier Permission page visible to users > with that permission only. > > Thanks, > Lakmali > > > On 8 August 2013 13:51, Nuwan Dias <[email protected]> wrote: > >> more details >> »<https://www.google.com/calendar/event?action=VIEW&eid=MnVraWNsaW5xdTRuOGVyaWVmZGk1bDZrYjggbGFrbWFsaUB3c28yLmNvbQ&tok=MTUjbnV3YW5kQHdzbzIuY29tY2JmMDFkNTkwYmY2OTVkYTBlZDAwYjQ0Mzk3N2UyYTFkZWY3NDhlNA&ctz=Asia/Colombo&hl=en> >> API Manager Code Review - Tier - User Permission Integration >> Public JiRA - >> https://wso2.org/jira/browse/APIMANAGER-1419<https://www.google.com/url?q=https%3A%2F%2Fwso2.org%2Fjira%2Fbrowse%2FAPIMANAGER-1419&ust=1375957266588000&usg=AFQjCNG30S08D4GcNeFI06xzERhTQT76Cw> >> *When* >> ********Fri Aug 9, 2013 2pm – 3pm Colombo >> *Where* >> LK #58 4th floor board room >> (map<http://maps.google.lk/maps?q=LK+%2358+4th+floor+board+room&hl=en> >> ) >> *Calendar* >> [email protected] >> *Who* >> • >> Nuwan Dias - organizer >> • >> Lakmali Baminiwatta >> • >> Ruwan Yatawara >> • >> Lalaji Sureshika >> • >> Vijayaratha Vijayasingam >> • >> Sanjeewa Malalgoda >> • >> [email protected] >> • >> Sumedha Rubasinghe >> • >> Dinusha Senanayaka >> • >> Amila De Silva >> >> Going? >> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=MnVraWNsaW5xdTRuOGVyaWVmZGk1bDZrYjggbGFrbWFsaUB3c28yLmNvbQ&rst=1&tok=MTUjbnV3YW5kQHdzbzIuY29tY2JmMDFkNTkwYmY2OTVkYTBlZDAwYjQ0Mzk3N2UyYTFkZWY3NDhlNA&ctz=Asia/Colombo&hl=en>- >> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=MnVraWNsaW5xdTRuOGVyaWVmZGk1bDZrYjggbGFrbWFsaUB3c28yLmNvbQ&rst=3&tok=MTUjbnV3YW5kQHdzbzIuY29tY2JmMDFkNTkwYmY2OTVkYTBlZDAwYjQ0Mzk3N2UyYTFkZWY3NDhlNA&ctz=Asia/Colombo&hl=en>- >> No<https://www.google.com/calendar/event?action=RESPOND&eid=MnVraWNsaW5xdTRuOGVyaWVmZGk1bDZrYjggbGFrbWFsaUB3c28yLmNvbQ&rst=2&tok=MTUjbnV3YW5kQHdzbzIuY29tY2JmMDFkNTkwYmY2OTVkYTBlZDAwYjQ0Mzk3N2UyYTFkZWY3NDhlNA&ctz=Asia/Colombo&hl=en> >> * **more options >> »<https://www.google.com/calendar/event?action=VIEW&eid=MnVraWNsaW5xdTRuOGVyaWVmZGk1bDZrYjggbGFrbWFsaUB3c28yLmNvbQ&tok=MTUjbnV3YW5kQHdzbzIuY29tY2JmMDFkNTkwYmY2OTVkYTBlZDAwYjQ0Mzk3N2UyYTFkZWY3NDhlNA&ctz=Asia/Colombo&hl=en> >> >> Invitation from Google Calendar <https://www.google.com/calendar/> >> >> You are receiving this email at the account [email protected] because you >> are subscribed for invitations on calendar [email protected]. >> >> To stop receiving these notifications, please log in to >> https://www.google.com/calendar/ and change your notification settings >> for this calendar. >> > > > > -- > Lakmali Baminiwatta* > * > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > mobile: +94 71 2335936 > blog : lakmali.com > * > * > -- /sumedha m: +94 773017743 b : bit.ly/sumedha
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
