Hi, Following is the summary of suggestions given during the code review.
1. Rename EventBuilderStreamJunction as the Manager and StreamEventDispatcher as the Junction 2. Making DtoConvertible as abstract DtoConverter 3. Make BasicDtoConverter to be a generic converter 4. In InputMapper remove mapping creation from interface (move to the constructor), make processInputEvent return an array and make createExportedStreamDefinition return an attribute array. 5. For XmlMappingTestCase, use EventBuilder instead of the mapping 6. Refactoring EventBuilderAdminService – remove unnecessary methods 7. Change onAddDefinition(StreamDefinition) in BasicEventListener to take an Attribute array instead. @Lasantha please add anything missing here. Thanks Rajeev On Mon, Aug 19, 2013 at 3:03 PM, Lasantha Fernando <[email protected]>wrote: > This event has been changed. > more details > »<https://www.google.com/calendar/event?action=VIEW&eid=ZGl2a24yazAwY2Vrb2QzZjQxNnY1NmY3NDggcmFqZWV2c0B3c28yLmNvbQ&tok=MTcjbGFzYW50aGFAd3NvMi5jb21jNWNkZjI1ZjdjMGM3MDRiODZjMmVkYzgwYjQxN2I1YWMyNDY5NGU1&ctz=Asia/Colombo&hl=en> > Code Review - Event Builder > Code review for event builder component > > Crucible Project: > http://wso2.org/crucible/project/WTC001<https://www.google.com/url?q=http%3A%2F%2Fwso2.org%2Fcrucible%2Fproject%2FWTC001&ust=1376912001277000&usg=AFQjCNGZim3SdSR0kVliJi3IG9D2VD0qDA> > *When* > *Changed: *********Mon Aug 19, 2013 4pm – 5:30pm Colombo > *Where* > LK #58 4th Floor Meeting room > (map<http://maps.google.lk/maps?q=LK+%2358+4th+Floor+Meeting+room&hl=en> > ) > *Calendar* > [email protected] > *Who* > • > Lasantha Fernando - organizer > • > Sinthuja Ragendran > • > Malith Dhanushka > • > Ayashkantha Ramasinghe > • > Balakrishnan Gokulakrishnan > • > Maninda Edirisooriya > • > Dunith Dhanushka > • > Inosh Goonewardena > • > Mohanadarshan Vivekanandalingam > • > [email protected] > • > Anjana Fernando > • > Gihan Anuruddha > • > Rajeev Sampath > • > Sriskandarajah Suhothayan > > Going? > ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=ZGl2a24yazAwY2Vrb2QzZjQxNnY1NmY3NDggcmFqZWV2c0B3c28yLmNvbQ&rst=1&tok=MTcjbGFzYW50aGFAd3NvMi5jb21jNWNkZjI1ZjdjMGM3MDRiODZjMmVkYzgwYjQxN2I1YWMyNDY5NGU1&ctz=Asia/Colombo&hl=en>- > Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=ZGl2a24yazAwY2Vrb2QzZjQxNnY1NmY3NDggcmFqZWV2c0B3c28yLmNvbQ&rst=3&tok=MTcjbGFzYW50aGFAd3NvMi5jb21jNWNkZjI1ZjdjMGM3MDRiODZjMmVkYzgwYjQxN2I1YWMyNDY5NGU1&ctz=Asia/Colombo&hl=en>- > No<https://www.google.com/calendar/event?action=RESPOND&eid=ZGl2a24yazAwY2Vrb2QzZjQxNnY1NmY3NDggcmFqZWV2c0B3c28yLmNvbQ&rst=2&tok=MTcjbGFzYW50aGFAd3NvMi5jb21jNWNkZjI1ZjdjMGM3MDRiODZjMmVkYzgwYjQxN2I1YWMyNDY5NGU1&ctz=Asia/Colombo&hl=en> > * **more options > »<https://www.google.com/calendar/event?action=VIEW&eid=ZGl2a24yazAwY2Vrb2QzZjQxNnY1NmY3NDggcmFqZWV2c0B3c28yLmNvbQ&tok=MTcjbGFzYW50aGFAd3NvMi5jb21jNWNkZjI1ZjdjMGM3MDRiODZjMmVkYzgwYjQxN2I1YWMyNDY5NGU1&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for updated invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Rajeev Sampath Senior Software Engineer WSO2, Inc.; http://www.wso2.com. Mobile:* +94716265766 *
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
