Hi,

The code review participants: Azeez, Anjana, PrabathA, Gihan, Inosh,
Malith, Chanika, Maninda, Dunith.

* The "ClusteredTaskManagerFactory", should simply throw a RuntimeException
(IllegalStateException).
* Hazelcast can lead to a split brain scenario, where the leader election
procedure can result in two leaders in the system. The docs has to contain
a mention about this unlikely situation where, the same task can be
scheduled twice in two different nodes, and the logic inside the task needs
to detect this situation. Or else, if the operation done inside the task is
anyway idempotent, it is OK.

Cheers,
Anjana.


On Fri, Aug 23, 2013 at 2:41 PM, Anjana Fernando <[email protected]> wrote:

>  more details 
> »<https://www.google.com/calendar/event?action=VIEW&eid=OGFrcGU3b292bmJmOXZqYmgwdWszMWV1c2cgZGV2QHdzbzIub3Jn&tok=MTUjYW5qYW5hQHdzbzIuY29tYjdlNGNkMWFiOGNmMDAxZWIwZWM2YzE5ZWQ3MTY5OGRiZTUzNWE2YQ&ctz=Asia/Colombo&hl=en>
> Code Review - NTask Hazelcast Integration
> *When*
> ********Fri Aug 23, 2013 4:30pm – 5pm Colombo
> *Where*
> #20, 1'st Floor, Conf Room 
> (map<http://maps.google.lk/maps?q=%2320,+1'st+Floor,+Conf+Room&hl=en>
> )
> *Calendar*
> [email protected]
> *Who*
>  •
> [email protected] - organizer
> •
> Malith Dhanushka
> •
> Prabath Abeysekera
> •
> Afkham Azeez
> •
> Dunith Dhanushka
> •
> Maninda Edirisooriya
> •
> Chanika Geeganage
> •
> Gihan Anuruddha
> •
> [email protected]
> •
> Inosh Goonewardena
> •
> Ayashkantha Ramasinghe
>
> Going?   
> ***Yes<https://www.google.com/calendar/event?action=RESPOND&eid=OGFrcGU3b292bmJmOXZqYmgwdWszMWV1c2cgZGV2QHdzbzIub3Jn&rst=1&tok=MTUjYW5qYW5hQHdzbzIuY29tYjdlNGNkMWFiOGNmMDAxZWIwZWM2YzE5ZWQ3MTY5OGRiZTUzNWE2YQ&ctz=Asia/Colombo&hl=en>-
> Maybe<https://www.google.com/calendar/event?action=RESPOND&eid=OGFrcGU3b292bmJmOXZqYmgwdWszMWV1c2cgZGV2QHdzbzIub3Jn&rst=3&tok=MTUjYW5qYW5hQHdzbzIuY29tYjdlNGNkMWFiOGNmMDAxZWIwZWM2YzE5ZWQ3MTY5OGRiZTUzNWE2YQ&ctz=Asia/Colombo&hl=en>-
> No<https://www.google.com/calendar/event?action=RESPOND&eid=OGFrcGU3b292bmJmOXZqYmgwdWszMWV1c2cgZGV2QHdzbzIub3Jn&rst=2&tok=MTUjYW5qYW5hQHdzbzIuY29tYjdlNGNkMWFiOGNmMDAxZWIwZWM2YzE5ZWQ3MTY5OGRiZTUzNWE2YQ&ctz=Asia/Colombo&hl=en>
> *    **more options 
> »<https://www.google.com/calendar/event?action=VIEW&eid=OGFrcGU3b292bmJmOXZqYmgwdWszMWV1c2cgZGV2QHdzbzIub3Jn&tok=MTUjYW5qYW5hQHdzbzIuY29tYjdlNGNkMWFiOGNmMDAxZWIwZWM2YzE5ZWQ3MTY5OGRiZTUzNWE2YQ&ctz=Asia/Colombo&hl=en>
>
> Invitation from Google Calendar <https://www.google.com/calendar/>
>
> You are receiving this courtesy email at the account [email protected] because
> you are an attendee of this event.
>
> To stop receiving future notifications for this event, decline this event.
> Alternatively you can sign up for a Google account at
> https://www.google.com/calendar/ and control your notification settings
> for your entire calendar.
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Anjana Fernando*
Technical Lead
WSO2 Inc. | http://wso2.com
lean . enterprise . middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to