This patch has broken the RESTful service invocations  deployed in tenants
in AS. e.g.

https://wso2.org/jira/browse/CARBON-14390

curl -v  -k -X GET
http://localhost:9763/services/t/jayasoma.org/echo/echoInt?in=12
curl -v  -k -X POST -d "in=12"
http://localhost:9763/services/t/jayasoma.org/echo/echoInt

Hence I am reverting this patch. Specially the following change.

-        String httpMethod = (String) mainInMsgContext.getProperty(
HTTPConstants.HTTP_METHOD);
+        String httpMethod = (String) mainInMsgContext.getProperty(
Constants.Configuration.HTTP_METHOD);

Thanks,
Sameera.




On Thu, Jul 4, 2013 at 11:45 AM, Amila Suriarachchi <[email protected]> wrote:

> I have applied the patch in wrong way. Will fix that.
>
> thanks,
> Amila.
>
>
> On Thu, Jul 4, 2013 at 7:55 AM, Amila Suriarachchi <[email protected]> wrote:
>
>>
>>
>>
>> On Wed, Jul 3, 2013 at 8:33 AM, Afkham Azeez <[email protected]> wrote:
>>
>>>
>>>
>>>
>>> On Wed, Jul 3, 2013 at 6:43 PM, <[email protected]> wrote:
>>>
>>>> Author: [email protected]
>>>> Date: Wed Jul  3 18:43:39 2013
>>>> New Revision: 177123
>>>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=177123
>>>>
>>>> Log:
>>>> applied the patch of CARBON-14087
>>>>
>>>> Modified:
>>>>
>>>>  
>>>> carbon/kernel/trunk/core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/multitenancy/MultitenantMessageReceiver.java
>>>>
>>>> Modified:
>>>> carbon/kernel/trunk/core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/multitenancy/MultitenantMessageReceiver.java
>>>> URL:
>>>> http://wso2.org/svn/browse/wso2/carbon/kernel/trunk/core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/multitenancy/MultitenantMessageReceiver.java?rev=177123&r1=177122&r2=177123&view=diff
>>>>
>>>> ==============================================================================
>>>> ---
>>>> carbon/kernel/trunk/core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/multitenancy/MultitenantMessageReceiver.java
>>>>       (original)
>>>> +++
>>>> carbon/kernel/trunk/core/org.wso2.carbon.core/src/main/java/org/wso2/carbon/core/multitenancy/MultitenantMessageReceiver.java
>>>>       Wed Jul  3 18:43:39 2013
>>>> @@ -339,7 +339,7 @@
>>>>          MultitenantRESTServlet restServlet = new
>>>> MultitenantRESTServlet(
>>>>                  tenantConfigCtx, requestUri, tenant);
>>>>
>>>> -        String httpMethod = (String)
>>>> mainInMsgContext.getProperty(HTTPConstants.HTTP_METHOD);
>>>> +        String httpMethod = (String)
>>>> mainInMsgContext.getProperty(Constants.Configuration.HTTP_METHOD);
>>>>          try {
>>>>              if
>>>> (httpMethod.equals(Constants.Configuration.HTTP_METHOD_GET)) {
>>>>                  restServlet.doGet(request, response);
>>>> @@ -347,7 +347,8 @@
>>>>                  restServlet.doPost(request, response);
>>>>              } else if
>>>> (httpMethod.equals(Constants.Configuration.HTTP_METHOD_PUT)) {
>>>>                  restServlet.doPut(request, response);
>>>> -            } else if
>>>> (httpMethod.equals(Constants.Configuration.HTTP_METHOD_DELETE)) {
>>>> +            } else if
>>>> (httpMethod.equals(Constants.Configuration.HTTP_METHOD_DELETE) ||
>>>> +                       httpMethod.equals("OPTIONS")) {
>>>>                  restServlet.doDelete(request, response);
>>>>
>>>
>>> Why do we delete if OPTIONS is received?
>>>
>>
>> Sorry I did not look at the content but applied the patch Nuwan has send
>> in this thread "Patching the 4.1.0 Kernel". Will talk to him and do the
>> correct thing.
>>
>> thanks,
>> Amila.
>>
>>>
>>>
>>>>              } else {
>>>>                  // TODO: throw exception: Invalid verb
>>>> _______________________________________________
>>>> Commits mailing list
>>>> [email protected]
>>>> http://wso2.org/cgi-bin/mailman/listinfo/commits
>>>>
>>>
>>>
>>>
>>> --
>>> *Afkham Azeez*
>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>> Member; Apache Software Foundation; http://www.apache.org/
>>> * <http://www.apache.org/>**
>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>> *
>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>> *
>>> *
>>> *Lean . Enterprise . Middleware*
>>>
>>
>>
>>
>> --
>> *Amila Suriarachchi*
>>
>> Software Architect
>> WSO2 Inc. ; http://wso2.com
>> lean . enterprise . middleware
>>
>> phone : +94 71 3082805
>>
>
>
>
> --
> *Amila Suriarachchi*
>
> Software Architect
> WSO2 Inc. ; http://wso2.com
> lean . enterprise . middleware
>
> phone : +94 71 3082805
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Sameera Jayasoma,
Architect,

WSO2, Inc. (http://wso2.com)
email: [email protected]
blog: http://sameera.adahas.org
twitter: https://twitter.com/sameerajayasoma
flickr: http://www.flickr.com/photos/sameera-jayasoma/collections

Lean . Enterprise . Middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to