On Thu, Aug 29, 2013 at 10:04 AM, Sanjeewa Malalgoda <[email protected]>wrote:
> > > > On Thu, Aug 29, 2013 at 8:48 AM, Sanjeewa Malalgoda <[email protected]>wrote: > >> >> >> >> On Thu, Aug 29, 2013 at 8:36 AM, Prabatha <[email protected]> wrote: >> >>> >>> >>> On Aug 29, 2013, at 8:28, Prabatha <[email protected]> wrote: >>> >>> Hi Sanjeewa, >>> >>> On Aug 29, 2013, at 8:06, Chanika Geeganage <[email protected]> wrote: >>> >>> Yes, please apply those patches. Sorry for the inconvenience. >>> >>> >>> On Thu, Aug 29, 2013 at 8:00 AM, Sanjeewa Malalgoda >>> <[email protected]>wrote: >>> >>>> >>>> >>>> >>>> On Wed, Aug 28, 2013 at 10:58 PM, Lalaji Sureshika <[email protected]>wrote: >>>> >>>>> Hi, >>>>> >>>>> When digging to the $subject,we found that there was a version change >>>>> happened in poi orbit bundle [from 3.5.0.wso2v1 -> 3.9.0.wso2v1] >>>>> yesterday. >>>>> In newly added poi orbit bundle[3.9.0.wso2v1],it's exporting the >>>>> commons-codec package,which is exporting same >>>>> by commons-codec_1.4.0.wso2v1.jar bundle. With earlier existed poi orbit >>>>> bundle[3.5.0.wso2v1] ,this commons-codec package wasn't exported. >>>>> >>>> Exporting commons codec as a private package seems correct solution for >>>> this. So all other jars will use it from commons-codec_1.4.0.wso2v1. AFAIU >>>> we do not need to export that package from poi. >>>> >>> >>> +1. Further, this might have occurred as a result of not excluding the >>> dependencies that might have been transitively downloaded while creating >>> the orbit bundle. If the same stuff is already exposed by the >>> commons-codec_1.4.0.wso2v1 and if that is compatible with the latest poi >>> version, we might probably be able to exclude that package altogether and >>> let it have its dependencies at runtime, I believe. WDYT? >>> >>> >>> Because, as you might already know, even though if we make it a private >>> package, the sources resides in that package get copied into the target >>> jar, though they don't get exposed. So, it might probably be a good idea to >>> get rid of those redundancies >>> >> +1 We do not need to have those classes in target jar. AFAIU those >> packages will not be copied to target jar if we made them private. I will >> double check and update thread. >> > Yes even if we made it private classes will be there so exclude is the > correct solution as we do not want to have them inside jar. Thanks for > pointing it. > Cool. No prob! Cheers, Prabath > > Thanks, > sanjeewa. > >> >> Thanks, >> Sanjeewa. >> >>> >>> >>> Cheers, >>> Prabath. >>> >>> >>> >>> Cheers, >>> Prabath >>> >>> >>>> Thanks, >>>> sanjeewa. >>>> >>>>> >>>>> Once we removed exporting the commons-codec package from poi orbit >>>>> bundle,we could get rid of the server startup issue. >>>>> >>>>> @DSS team-I have attached the patch with this mail.Can you let us >>>>> know,if there are any other issues by removing exporting this common-codec >>>>> package from poi bundle?Else we'll continue commiting the fix as this is a >>>>> blocker for us. >>>>> >>>>> Thanks; >>>>> >>>>> >>>>> >>>>> -- >>>>> Lalaji Sureshika >>>>> WSO2, Inc.; http://wso2.com/ >>>>> email: [email protected]; cell: +94 71 608 6811 >>>>> blog: http://lalajisureshika.blogspot.com >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> * >>>> * >>>> *Sanjeewa Malalgoda* >>>> Senior Software Engineer >>>> WSO2 Inc. >>>> Mobile : +94713068779 >>>> >>>> <http://sanjeewamalalgoda.blogspot.com/>blog >>>> :http://sanjeewamalalgoda.blogspot.com/<http://sanjeewamalalgoda.blogspot.com/> >>>> >>>> >>>> >>> >>> >>> -- >>> Best Regards.. >>> >>> Chanika Geeganage >>> Software Engineer >>> WSO2, Inc.; http://wso2.com >>> >>> Mobile: +94773522586 >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> * >> * >> *Sanjeewa Malalgoda* >> Senior Software Engineer >> WSO2 Inc. >> Mobile : +94713068779 >> >> <http://sanjeewamalalgoda.blogspot.com/>blog >> :http://sanjeewamalalgoda.blogspot.com/<http://sanjeewamalalgoda.blogspot.com/> >> >> >> > > > -- > * > * > *Sanjeewa Malalgoda* > Senior Software Engineer > WSO2 Inc. > Mobile : +94713068779 > > <http://sanjeewamalalgoda.blogspot.com/>blog > :http://sanjeewamalalgoda.blogspot.com/<http://sanjeewamalalgoda.blogspot.com/> > > > -- Prabath Abeysekara Associate Technical Lead, Data TG. WSO2 Inc. Email: [email protected] Mobile: +94774171471
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
