On Mon, Sep 2, 2013 at 3:24 PM, Isuru Udana <[email protected]> wrote:
>
>
>
> On Mon, Sep 2, 2013 at 3:19 PM, Kasun Indrasiri <[email protected]> wrote:
>
>>
>>
>>
>> On Mon, Sep 2, 2013 at 2:53 PM, Miyuru Wanninayaka <[email protected]>wrote:
>>
>>> I can remember that in old ESB versions, we do a regex matching for
>>> proxy bypass list.
>>> So we can define wildcard notations for bypass like 10.100.*
>>>
>>> But in current code it's just a string matching
>>>
>>> As per latest synapse branch its doing regex matching.
>> public HttpHost selectProxy(final HttpHost target) {
>> if (this.proxy != null) {
>> for (String proxyByPassEntry : this.proxyBypass) {
>> if
>> (target.getHostName().toLowerCase(Locale.US).*matches*(proxyByPassEntry))
>> {
>> return null;
>> }
>> }
>> }
>> return this.proxy;
>> }
>>
>
> It looks like for every request we are doing a string matching when proxy
> is enabled, which is not the optimum way to do this.
> We have to change this logic to something similar to what we had in
> previous synapse versions.
>
+1
>
>
>>
>> org.apache.synapse.transport.http.conn.ProxyConfig
>>>
>>> public HttpHost selectProxy(final HttpHost target) {
>>> if (this.proxy != null) {
>>> if
>>> (!this.proxyBypass.contains(target.getHostName().toLowerCase(Locale.US))) {
>>> return this.proxy;
>>> }
>>> }
>>> return null;
>>> }
>>>
>>> What should be the correct behavior?
>>>
>>> --
>>> Miyuru Wanninayaka
>>> Technical Lead
>>> WSO2 Inc. : http://wso2.com
>>>
>>> Mobile : +94 77 209 9788
>>> Blog : http://miyurudw.blogspot.com
>>> Flickr : http://www.flickr.com/photos/miyuru_daminda
>>>
>>
>>
>>
>> --
>> Kasun Indrasiri
>> Software Architect
>> WSO2, Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> cell: +94 71 536 4128
>> Blog : http://kasunpanorama.blogspot.com/
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Isuru Udana*
> *
> *
> Senior *
> Software Engineer
> *
> WSO2 Inc.; http://wso2.com
> email: [email protected] cell: +94 77 3791887
> blog: http://mytecheye.blogspot.com/
> twitter: http://twitter.com/isudana
>
--
Kasun Indrasiri
Software Architect
WSO2, Inc.; http://wso2.com
lean.enterprise.middleware
cell: +94 71 536 4128
Blog : http://kasunpanorama.blogspot.com/
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev
