Hi Harshana,

I had few problems with my subscription to commits list. I think that was
the problem.
Please find the content of the commit mail below.

Author: [email protected]
Date: 2013-08-24 22:09:11 +0530 (Sat, 24 Aug 2013)
New Revision: 182953

Modified:
   carbon/platform/branches/4.2.
0/components/security/org.wso2.carbon.security.mgt/4.2.0/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java
Log:
Solving WSAS-1473

Modified:
carbon/platform/branches/4.2.0/components/security/org.wso2.carbon.security.mgt/4.2.0/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java
===================================================================
---
carbon/platform/branches/4.2.0/components/security/org.wso2.carbon.security.mgt/4.2.0/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java
   2013-08-24 16:31:48 UTC (rev 182952)
+++
carbon/platform/branches/4.2.0/components/security/org.wso2.carbon.security.mgt/4.2.0/src/main/java/org/wso2/carbon/security/pox/POXSecurityHandler.java
   2013-08-24 16:39:11 UTC (rev 182953)
@@ -156,18 +156,20 @@
             }catch (Exception e){}//ignore

             if(scenarioID == null){
-                SecurityConfigAdmin securityAdmin = new
SecurityConfigAdmin(msgCtx.
-
 getConfigurationContext().getAxisConfiguration());
-                SecurityScenarioData data =
securityAdmin.getCurrentScenario(service.getName());
-                if(data != null){
-                    scenarioID = data.getScenarioId();
-                    try {
-                        Parameter param = new Parameter();
-
 param.setName(SecurityConstants.SCENARIO_ID_PARAM_NAME);
-                        param.setValue(scenarioID);
-                        service.addParameter(param);
-                    } catch (AxisFault axisFault) {
-                        log.error("Error while adding Scenario ID
parameter",axisFault);
+                synchronized (this){
+                    SecurityConfigAdmin securityAdmin = new
SecurityConfigAdmin(msgCtx.
+
 getConfigurationContext().getAxisConfiguration());
+                    SecurityScenarioData data =
securityAdmin.getCurrentScenario(service.getName());
+                    if(data != null){
+                        scenarioID = data.getScenarioId();
+                        try {
+                            Parameter param = new Parameter();
+
 param.setName(SecurityConstants.SCENARIO_ID_PARAM_NAME);
+                            param.setValue(scenarioID);
+                            service.addParameter(param);
+                        } catch (AxisFault axisFault) {
+                            log.error("Error while adding Scenario ID
parameter",axisFault);
+                        }
                     }
                 }
             }


Thanks.



On Sat, Sep 14, 2013 at 5:41 AM, Harshana Martin <[email protected]> wrote:

> Hi Piyum,
>
> What was the fix for the issue? I cannot locate a commit mail for this
> particular issue.
>
> I got the same with ELB 2.0.3 as well.
>
> Thanks and Regrads,
> Harshana
>
>
> On Fri, Aug 23, 2013 at 12:05 AM, Piyum Fernando <[email protected]> wrote:
>
>> Hi Ishan,
>>
>> We fixed the issue mentioned in WSAS-1473.
>>
>> I will have a look in to this again.
>>
>> Thanks.
>>
>>
>>
>>
>> On Fri, Aug 23, 2013 at 12:25 PM, Ishan Jayawardena <[email protected]>wrote:
>>
>>> Hi Kasun,
>>> I experienced a related issue while running the integration tests.
>>> Please see the log below.
>>> In this case I am trying to send multiple requests to an HTTPS endpoint
>>> in parallel. According to the jira ticket a patch seems to have been
>>> applied but I get this error in the latest build. Any idea?
>>>
>>> ==============
>>>
>>> [2013-08-23 11:47:14,882] ERROR - SecurityConfigAdmin Error while
>>> reading persisted data
>>> org.wso2.carbon.core.persistence.PersistenceException: A transaction is
>>> already started for this service group. Nested transactions are no longer
>>> supported in this persistence model - StockQuoteProxy
>>>  at
>>> org.wso2.carbon.core.persistence.file.ServiceGroupFilePersistenceManager.beginTransaction(ServiceGroupFilePersistenceManager.java:71)
>>> at
>>> org.wso2.carbon.security.config.SecurityConfigAdmin.getCurrentScenario(SecurityConfigAdmin.java:207)
>>>  at
>>> org.wso2.carbon.security.pox.POXSecurityHandler.invoke(POXSecurityHandler.java:161)
>>> at org.apache.axis2.engine.Phase.invokeHandler(Phase.java:340)
>>>  at org.apache.axis2.engine.Phase.invoke(Phase.java:313)
>>> at org.apache.axis2.engine.AxisEngine.invoke(AxisEngine.java:261)
>>>  at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:167)
>>> at
>>> org.apache.synapse.transport.passthru.ServerWorker.processEntityEnclosingRequest(ServerWorker.java:404)
>>>  at
>>> org.apache.synapse.transport.passthru.ServerWorker.run(ServerWorker.java:184)
>>> at
>>> org.apache.axis2.transport.base.threads.NativeWorkerPool$1.run(NativeWorkerPool.java:172)
>>>  at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>>> at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>>>  at java.lang.Thread.run(Thread.java:662)
>>> [2013-08-23 11:47:14,884] ERROR - AxisEngine System error
>>> org.apache.axis2.AxisFault: System error
>>>  at
>>> org.wso2.carbon.security.pox.POXSecurityHandler.invoke(POXSecurityHandler.java:260)
>>> at org.apache.axis2.engine.Phase.invokeHandler(Phase.java:340)
>>>  at org.apache.axis2.engine.Phase.invoke(Phase.java:313)
>>> at org.apache.axis2.engine.AxisEngine.invoke(AxisEngine.java:261)
>>>  at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:167)
>>> at
>>> org.apache.synapse.transport.passthru.ServerWorker.processEntityEnclosingRequest(ServerWorker.java:404)
>>>  at
>>> org.apache.synapse.transport.passthru.ServerWorker.run(ServerWorker.java:184)
>>> at
>>> org.apache.axis2.transport.base.threads.NativeWorkerPool$1.run(NativeWorkerPool.java:172)
>>>  at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>>> at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>>>  at java.lang.Thread.run(Thread.java:662)
>>> Caused by: org.wso2.carbon.security.SecurityConfigException:
>>> readingSecurity
>>> at
>>> org.wso2.carbon.security.config.SecurityConfigAdmin.getCurrentScenario(SecurityConfigAdmin.java:253)
>>>  at
>>> org.wso2.carbon.security.pox.POXSecurityHandler.invoke(POXSecurityHandler.java:161)
>>> ... 10 more
>>> [2013-08-23 11:47:14,886] ERROR - ServerWorker Error processing POST
>>> request for : /services/StockQuoteProxy
>>> org.apache.axis2.AxisFault: System error
>>> at
>>> org.wso2.carbon.security.pox.POXSecurityHandler.invoke(POXSecurityHandler.java:260)
>>> at org.apache.axis2.engine.Phase.invokeHandler(Phase.java:340)
>>>  at org.apache.axis2.engine.Phase.invoke(Phase.java:313)
>>> at org.apache.axis2.engine.AxisEngine.invoke(AxisEngine.java:261)
>>>  at org.apache.axis2.engine.AxisEngine.receive(AxisEngine.java:167)
>>> at
>>> org.apache.synapse.transport.passthru.ServerWorker.processEntityEnclosingRequest(ServerWorker.java:404)
>>>  at
>>> org.apache.synapse.transport.passthru.ServerWorker.run(ServerWorker.java:184)
>>> at
>>> org.apache.axis2.transport.base.threads.NativeWorkerPool$1.run(NativeWorkerPool.java:172)
>>>  at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>>> at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>>>  at java.lang.Thread.run(Thread.java:662)
>>> Caused by: org.wso2.carbon.security.SecurityConfigException:
>>> readingSecurity
>>> at
>>> org.wso2.carbon.security.config.SecurityConfigAdmin.getCurrentScenario(SecurityConfigAdmin.java:253)
>>>  at
>>> org.wso2.carbon.security.pox.POXSecurityHandler.invoke(POXSecurityHandler.java:161)
>>> ... 10 more
>>>
>>>
>>>
>>>
>>>
>>> On Tue, Aug 13, 2013 at 9:00 PM, Kasun Gajasinghe <[email protected]>wrote:
>>>
>>>> Hi,
>>>>
>>>> I've been going through this issue [1] where I noticed that we are
>>>> having a massive performance issue with POX security where each POX
>>>> requests do a file system read!! What happens is that, POXSecurityHandler
>>>> tries to determine whether the current security scenario of a service is UT
>>>> or not. For that, it calls the SecurityConfigAdmin#getCurrentScenario which
>>>> reads the relevant service metafile, and further executes an xpath to get
>>>> this info.
>>>>
>>>> Is there a better way to get the current security scenario of a service?
>>>>
>>>> [1] https://wso2.org/jira/browse/WSAS-1473
>>>>
>>>> Thanks,
>>>> KasunG
>>>>
>>>> --
>>>> *Kasun Gajasinghe*
>>>> Software Engineer;
>>>> Development Technologies Team, WSO2 Inc.; http://wso2.com
>>>>
>>>>
>>>>  ,
>>>> *email: **kasung AT spamfree wso2.com
>>>>
>>>>
>>>> ** cell: **+94 (77) 678-0813*
>>>> *linked-in: *http://lk.linkedin.com/in/gajasinghe
>>>>
>>>>
>>>> *
>>>> *
>>>> *blog: **http://kasunbg.org* <http://kasunbg.org>
>>>>
>>>>
>>>> *
>>>> twitter: **http://twitter.com/kasunbg* <http://twitter.com/kasunbg>
>>>>
>>>>
>>>> *
>>>> *
>>>>
>>>> _______________________________________________
>>>> Dev mailing list
>>>> [email protected]
>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>
>>>>
>>>
>>> Thanks,
>>> --
>>> Ishan Jayawardena
>>>
>>>
>>> _______________________________________________
>>> Dev mailing list
>>> [email protected]
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Piyum Fernando
>> Software Engineer
>>
>> Mobile: +94 77 22 93 880
>> Home:  +94 31 22 75 715
>>
>> _______________________________________________
>> Dev mailing list
>> [email protected]
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> Harshana Martin
> Associate Technical Lead
> WSO2 Inc. : http://wso2.com
>
> Mobile: +94 775 998 115
> Profile: https://www.google.com/profiles/harshana05
> Blog: http://harshana05.blogspot.com
> Twitter: http://twitter.com/harshana05
>
>


-- 
Piyum Fernando
Software Engineer

Mobile: +94 77 22 93 880
Home:  +94 31 22 75 715
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to