+1 for cleaning as and when we see - my only worry being we should not break anything - so can we update the tests also as we go ?
On Thu, Sep 19, 2013 at 11:23 AM, Harsha Thirimanna <[email protected]>wrote: > +1 , yes, it is good. > On Sep 19, 2013 9:45 AM, "Danushka Fernando" <[email protected]> wrote: > >> Hi Shiro >> I am not going to clean up everything. And also I am not proposing to >> cleanup in one day or one time. I proposed that when we saw something >> unused find-out is it really unused and remove it. In jaggery side we can >> do a grep from appmgt folder and find out where it is referred and we can >> decide whether it is used or not. If we don't do it at-least this way this >> code is going to be much more unreadable. >> About integration tests, they are not updated to multitenanted AF AFAIK. >> But yeah we need to make sure we are not going to cause any regressions. >> Thats why we needs to findout it is really unused. When it comes to jaggery >> its not a big issue to find out the usages. WDYT? >> >> Thanks & Regards >> Danushka Fernando >> Software Engineer >> WSO2 inc. http://wso2.com/ >> Mobile : +94716332729 >> >> >> On Thu, Sep 19, 2013 at 6:42 AM, Shiroshica Kulatilake <[email protected]>wrote: >> >>> Hi Danushka, >>> >>> Do you have the integration tests up and running ? If so the correct way >>> would be to run these before any changes - see whether all is ok and then >>> start the clean up - step by step running the integration tests after each >>> step- so that we don't add any regressions. We also need to have a >>> guarantee that the tests are covering all the scenarios - otherwise there >>> is no point in using them as a benchmark. >>> >>> I'm +1 for cleaning BUT we are also time constrained to get the features >>> done and stabilizing the pack - prioritizing what needs to be done first >>> and how to approach this without affecting the timelines need to be >>> considered. So if we can't guarantee against regressions - not now. >>> >>> Thank you, >>> Shiro >>> >>> >>> On Thu, Sep 19, 2013 at 2:23 AM, Ramith Jayasinghe <[email protected]>wrote: >>> >>>> yea. thats cool. >>>> >>>> >>>> On Thu, Sep 19, 2013 at 2:16 AM, Danushka Fernando >>>> <[email protected]>wrote: >>>> >>>>> Hi, >>>>> In our jaggery app (appmgt) there are lot of unused codes. These makes >>>>> it difficult to change something. So shall we remove these unused codes >>>>> when we found one? >>>>> >>>>> Thanks & Regards >>>>> Danushka Fernando >>>>> Software Engineer >>>>> WSO2 inc. http://wso2.com/ >>>>> Mobile : +94716332729 >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Ramith Jayasinghe >>>> Technical Lead >>>> WSO2 Inc., http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> E: [email protected] >>>> P: +94 776715671 >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Shiroshica Kulatilake >>> >>> Architect, >>> WSO2, Inc. http://wso2.com/ >>> Phone: +94 776523867 >>> >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> -- Shiroshica Kulatilake Architect, WSO2, Inc. http://wso2.com/ Phone: +94 776523867
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
