Hi Sagara, It wasn't clear what the other two commits were, so I left those out. I'll look into merging those.
What should we do if the code is too out of sync (since the version we are patching is quite old), IIRC one of those commits was fixing a regression issue and seemed to be out of sync with the version we're using. Thanks On Mon, Sep 23, 2013 at 11:13 PM, Sagara Gunathunga <[email protected]> wrote: > > > > On Mon, Sep 23, 2013 at 4:43 AM, Sameera Jayasoma <[email protected]>wrote: > >> Hi Sagara, >> >> Can you please review this patch? >> > > > @Ravi, > > Why do you have take only part of the fix from AXIOM-443 ? This may solve > only specific visible issue but as you can read from AXIOM-443 comments we > need complete fix to provide full support for IBM JRE. IMO if there is no > specific reason then apply the full patch to local branch. (Generally when > merging from Apache branch to out local branch don't merge part of a patch > that may cause lot of incompatibilities in future) > > @Sameera > > Since we are merging from Apache trunk there can't be any technical issue > with the fix let's just make sure we can pass test cases. > > Thanks ! > > Thanks ! > >> >> Thanks, >> Sameera. >> >> >> On Mon, Sep 23, 2013 at 11:31 AM, Vanjikumaran Sivajothy >> <[email protected]>wrote: >> >>> @ravi >>> >>> Thank you for your patch. >>> >>> @sameera >>> This is critical issue on IBM JRE 1.7! >>> >>> Please good enough to apply the patch to resolve this issue. >>> >>> Thank you, >>> Best regards, >>> vanji >>> >>> >>> >>> On Mon, Sep 23, 2013 at 11:26 AM, Ravi Undupitiya <[email protected]> wrote: >>> >>>> Hi Vanji, >>>> >>>> >>>> I exported the patch from AXIOM-443 and it solved this issue. There's a >>>> patch attached to [1]. >>>> >>>> [1] https://wso2.org/jira/browse/ESBJAVA-2462 >>>> >>>> >>>> On Fri, Sep 20, 2013 at 9:25 AM, Vanjikumaran Sivajothy <[email protected] >>>> > wrote: >>>> >>>>> Hi Carbon team, >>>>> >>>>> Please assist us to resolve [1] by applying patch in [2]. This >>>>> is pretty urgent, because esb is not starting at all in AIX 7.1, IBM >>>>> JDK 1.7 environment. >>>>> >>>>> >>>>> [1]https://wso2.org/jira/browse/ESBJAVA-2462 >>>>> [2]https://issues.apache.org/jira/browse/AXIOM-443 >>>>> >>>>> Quick action highly appreciate to solve the problem and thank you in >>>>> advance. >>>>> >>>>> -- >>>>> Sivajothy Vanjikumaran >>>>> *Senior Software Engineer* >>>>> *Integration Technologies Team* >>>>> *WSO2 Inc. http://wso2.com/* >>>>> *Mobile:(+94)777219209** >>>>> *[image: Facebook] <https://www.facebook.com/vanjikumaran> [image: >>>>> Twitter] <https://twitter.com/vanjikumaran> [image: >>>>> LinkedIn]<http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> >>>>> [image: >>>>> Blogger] <http://vanjikumaran.blogspot.com/> [image: >>>>> SlideShare]<http://www.slideshare.net/vanjikumaran> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Ravi Undupitiya* >>>> Software Engineer; WSO2 Inc.; http://wso2.com >>>> * >>>> * >>>> *E-mail: [email protected] >>>> **M: **+94 772 930 712* >>>> * >>>> *Lean . Enterprise . Middleware >>>> >>> >>> >>> >>> -- >>> Sivajothy Vanjikumaran >>> *Senior Software Engineer* >>> *Integration Technologies Team* >>> *WSO2 Inc. http://wso2.com/* >>> *Mobile:(+94)777219209** >>> *[image: Facebook] <https://www.facebook.com/vanjikumaran> [image: >>> Twitter] <https://twitter.com/vanjikumaran> [image: >>> LinkedIn]<http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> >>> [image: >>> Blogger] <http://vanjikumaran.blogspot.com/> [image: >>> SlideShare]<http://www.slideshare.net/vanjikumaran> >>> >> >> >> >> -- >> Sameera Jayasoma, >> Architect, >> >> WSO2, Inc. (http://wso2.com) >> email: [email protected] >> blog: http://sameera.adahas.org >> twitter: https://twitter.com/sameerajayasoma >> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >> Mobile: 0094776364456 >> >> >> Lean . Enterprise . Middleware >> > > > > -- > Sagara Gunathunga > > Senior Technical Lead; WSO2, Inc.; http://wso2.com > V.P Apache Web Services; http://ws.apache.org/ > Linkedin; http://www.linkedin.com/in/ssagara > Blog ; http://ssagara.blogspot.com > > -- *Ravi Undupitiya* Software Engineer; WSO2 Inc.; http://wso2.com * * *E-mail: [email protected] **M: **+94 772 930 712* * *Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
