Hi Ruwan, Yes. I too noticed this later. So your approach seems to be correct. Sorry for the noise. When I tried to build ESB in a clean repo, it was failing from many places. As you are aware of that ESB is releasing with chunk-03, you could have added the commented out features/components to chunk-03. However I have completed merging chunk 03 ESB related stuff to chunk-02 and verified both AM and ESB builds in clean repo. So the problem is sorted now.
Thanks. On Sun, Sep 29, 2013 at 8:05 PM, Ruwan Yatawara <[email protected]> wrote: > Hi Isuru, > > Extremely sorry about this, I was under the impression this was the way to > go about since it was how components were released with Chunk-01. This is > evident if you take a look at the "governance" component. With chunk-01, > only the "org.wso2.carbon.governance.api" was released. However, if you > look at the chunk-01 release pom, the whole of governance component is > listed, with the un-released components having been commented out in the > component parent pom (Pls refer commit : r184428 by Sameera). I believe > this is because the parent pom needs to be available at a later point of > the build. When going by this approiach In later chunk releases once the > commented out components are required, said components need to be listed > down as below in the chunk/compoentns pom, as the parent pom has already > been released. > > E.g. : > > <module>../../../components/governance/org.wso2.carbon.governance.api/4.2.1</module> > > <module>../../../components/governance/org.wso2.carbon.governance.registry.extensions/4.2.0</module> > > > <module>../../../components/governance/org.wso2.carbon.governance.registry.eventing/4.2.0</module> > > > Thanks and Regards, > > Ruwan Yatawara > > Software Engineer, > WSO2 Inc. > lean . enterprise . middleware > > email : [email protected] > mobile : +94 77 9110413 > blog : http://ruwansrants.blogspot.com/ > www: :http://wso2.com > > > > On Fri, Sep 27, 2013 at 11:08 PM, Isuru Udana <[email protected]> wrote: > >> Hi Ruwan, >> >> This is completely wrong way of removing not releasing >> components/features. There are many places you have followed this approach >> :( >> I am reverting all those commits. >> >> >> On Tue, Sep 24, 2013 at 10:47 AM, <[email protected]> wrote: >> >>> Author: [email protected] >>> Date: Tue Sep 24 10:47:30 2013 >>> New Revision: 186207 >>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=186207 >>> >>> Log: >>> removing features not released with chunk-02 >>> >>> Modified: >>> carbon/platform/branches/4.2.0/components/mediators/pom.xml >>> >>> Modified: carbon/platform/branches/4.2.0/components/mediators/pom.xml >>> URL: >>> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.2.0/components/mediators/pom.xml?rev=186207&r1=186206&r2=186207&view=diff >>> >>> ============================================================================== >>> --- carbon/platform/branches/4.2.0/components/mediators/pom.xml >>> (original) >>> +++ carbon/platform/branches/4.2.0/components/mediators/pom.xml Tue Sep >>> 24 10:47:30 2013 >>> @@ -34,10 +34,10 @@ >>> >>> <modules> >>> <module>target-mediator</module> >>> - <module>log</module> >>> - <module>send</module> >>> + <!--module>log</module> >>> + <module>send</module--> >>> <module>class</module> >>> - <module>calltemplate</module> >>> + <!--module>calltemplate</module> >>> <module>aggregate</module> >>> <module>clone</module> >>> <module>dblookup</module> >>> @@ -48,9 +48,9 @@ >>> <module>store</module> >>> <module>validate</module> >>> <module>xslt</module> >>> - <module>callout</module> >>> + <module>callout</module--> >>> <module>command</module> >>> - <module>dbreport</module> >>> + <!--module>dbreport</module> >>> <module>filter</module> >>> <module>iterate</module> >>> <module>rmsequence</module> >>> @@ -62,15 +62,15 @@ >>> <module>cache</module> >>> <module>in</module> >>> <module>out</module> >>> - <module>drop</module> >>> + <module>drop</module--> >>> <module>router</module> >>> <module>event</module> >>> - <module>entitlement</module> >>> + <!--module>entitlement</module> >>> <module>oauth</module> >>> <module>transaction</module> >>> - <module>rule</module> >>> + <module>rule</module--> >>> <!--module>autoscale</module--> >>> - <module>uiless</module> >>> + <!--module>uiless</module> >>> <module>enqueue</module> >>> <module>smooks</module> >>> <module>bam</module> >>> @@ -79,11 +79,11 @@ >>> <module>conditionalrouter</module> >>> <module>payloadFactory</module> >>> <module>ejb</module> >>> - <module>bean-mediator</module> >>> + <module>bean-mediator</module--> >>> <module>fastXSLT</module> >>> - <module>loopback</module> >>> + <!--module>loopback</module> >>> <module>respond</module> >>> - <module>call</module> >>> + <module>call</module--> >>> </modules> >>> >>> <dependencyManagement> >>> _______________________________________________ >>> Commits mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/commits >>> >> >> >> >> -- >> *Isuru Udana* >> * >> * >> Senior * >> Software Engineer >> * >> WSO2 Inc.; http://wso2.com >> email: [email protected] cell: +94 77 3791887 >> blog: http://mytecheye.blogspot.com/ >> twitter: http://twitter.com/isudana >> > > -- *Isuru Udana* * * Senior * Software Engineer * WSO2 Inc.; http://wso2.com email: [email protected] cell: +94 77 3791887 blog: http://mytecheye.blogspot.com/ twitter: http://twitter.com/isudana
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
