Hi Scott, I have applied your patch in to the Balana trunk.. Please see my comments in the jira [1]. I am really +1 for refactoring the things.... It would be great, if you can create patches for them by creating jiras. We can apply them in to the trunk. Again, thanks for your contribution.
[1] https://wso2.org/jira/browse/COMMONS-101 Thanks, Asela <https://wso2.org/jira/browse/COMMONS-101> On Fri, Oct 11, 2013 at 12:24 PM, Asela Pathberiya <[email protected]> wrote: > Hi Scott, > > Great...!!! Thanks a lot for your contribution. we will go through it and > apply in to the trunk.... > > Thanks, > Asela. > > > > On Wed, Oct 9, 2013 at 11:46 PM, Scott Came <[email protected]> wrote: > >> Thanks, Asela.**** >> >> ** ** >> >> JIRA created (https://wso2.org/jira/browse/COMMONS-101) with patch >> attached.**** >> >> ** ** >> >> In the source I noted some potential refactorings that we could do to >> reduce the amount of copied-and-pasted code, but my intention was to >> implement this with no changes to existing code. If the decision is to >> refactor things, I’m happy to look at doing that as a follow-on task. >> > **** >> >> >> >> Thanks.**** >> >> --Scott**** >> >> ** ** >> >> *From:* Asela Pathberiya [mailto:[email protected]] >> *Sent:* Tuesday, October 08, 2013 10:22 PM >> >> *To:* Scott Came >> *Cc:* [email protected] >> *Subject:* Re: [Dev] Balana policy source question**** >> >> ** ** >> >> ** ** >> >> Hi Scott, **** >> >> If you create an account in wso2.com [1]. Then you can login to jira >> account with those credentials. >> >> [1] https://wso2.com/user/register**** >> >> Thanks, >> Asela.**** >> >> ** ** >> >> On Wed, Oct 9, 2013 at 6:01 AM, Scott Came <[email protected]> wrote: >> **** >> >> Hi Asela. I have created an InMemoryPolicyFinderModule and an associated >> unit test. I can easily roll a patch for this and submit it.**** >> >> **** >> >> I hit the link [1] you referenced, but it looks like I need a JIRA >> account in order to create a ticket and post the patch. I looked around on >> the WSO2 site and could not see how to create an account. What is the next >> step?**** >> >> **** >> >> Thanks.**** >> >> --Scott**** >> >> **** >> >> *From:* Asela Pathberiya [mailto:[email protected]] >> *Sent:* Tuesday, October 01, 2013 10:08 AM >> *To:* Scott Came >> *Cc:* [email protected] >> *Subject:* Re: [Dev] Balana policy source question**** >> >> **** >> >> Hi Scott,**** >> >> Really welcome your ideas. Yes. Balana only have a sample implementation >> for file system based policies. As you know, WSO2 Identity Server uses >> Balana as XACML engine and Identity Server has own implementation for >> PolicyFinderModule. Sure... you could implement this for Balana... If >> policies are loading from different sources (file system, databases and so >> on...), it is easy to extend an in-memory finder module. You can create a >> ticket in here [1]**** >> >> under Balana component and provide a patch for trunk. **** >> >> >> [1] https://wso2.org/jira/browse/COMMONS**** >> >> Thanks, >> Asela.**** >> >> **** >> >> On Tue, Oct 1, 2013 at 4:06 AM, Scott Came <[email protected]> wrote: >> **** >> >> Unless I’m missing something, it looks like the only way to feed policies >> into the Balana PDP is to have them in files that reside in the filesystem. >> **** >> >> **** >> >> I’m wondering if any thought was given to allowing (somehow) in-memory >> DOM Documents to be passed in. I haven’t investigated in-depth yet, but I >> wonder if it would be possible to write a PolicyFinderModule implementation >> class that references an in-memory collection of policies…**** >> >> **** >> >> If this seems like a good idea, I’d be happy to attempt it…**** >> >> **** >> >> Thanks.**** >> >> --Scott**** >> >> **** >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev**** >> >> >> >> >> -- **** >> >> Thanks & Regards,**** >> >> Asela**** >> >> **** >> >> ATL**** >> >> Mobile : +94 777 625 933**** >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev**** >> >> >> >> >> -- **** >> >> Thanks & Regards,**** >> >> Asela**** >> >> ** ** >> >> ATL**** >> >> Mobile : +94 777 625 933**** >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Thanks & Regards, > Asela > > ATL > Mobile : +94 777 625 933 > -- Thanks & Regards, Asela ATL Mobile : +94 777 625 933
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
