Please check inline comments. On Thu, Oct 31, 2013 at 5:29 PM, Harsha Thirimanna <[email protected]> wrote:
> Hi, > > *Enable deploy only if there is a successful build* > https://wso2.org/jira/browse/APPFAC-1644 > We can get the lastSuccessfulBuild id from jenkins to given job. When we > click on the deploy button, we can check whether there is at least one > lastSuccessfulBuild id and if there are no one then show the message to the > user. > > Any suggestion about this ? > > Issue is proposing to disable the button when no successful builds are there. So 1. I thought we have removed lot of disabling buttons because this confuses the user. 2. If we disable buttons each time this page loads there will be lot of calls going to jenkins to check for successful builds to just disable the deploy button. And if we have 10 branches there there will be 10 calls for each page load. So without disabling the button its better to let the user click the button and popup a message saying there are no successful builds available. Please build first. This will reduce the unnecessary calls. WDYT? > *Enable the deploy button after it is deployed* > https://wso2.org/jira/browse/APPFAC-1645 > To do this we have to sync with deployed servers to check the deployment > status. Then there may be lot of calls to back end according to the above > suggestion. > Are there any other ways to do this ? > > We do the deploy as an async operation. However lets say we implement this. There are two concerns for me. 1. What happens at page reload. Does it re-enable? 2. What happens if deploy fails for some reason. User wont be able to deploy that branch again. And I think disabling buttons will confuses the user since user doesn't know when this button will be enabled. WDYT? > > thanks > > *Harsha Thirimanna* > Senior Software Engineer; WSO2, Inc.; http://wso2.com > * <http://www.apache.org/>** > email: **[email protected]* <[email protected]>* cell: +94 71 5186770** > twitter: **http://twitter.com/ <http://twitter.com/afkham_azeez>** > harshathirimann > linked-in: **http: <http://lk.linkedin.com/in/afkhamazeez>**// > www.linkedin.com/pub/harsha-thirimanna/10/ab8/122* > * > * > *Lean . Enterprise . Middleware* > * > * > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > Thanks & Regards Danushka Fernando Software Engineer WSO2 inc. http://wso2.com/ Mobile : +94716332729
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
