Hi Manisha, Yea. What I'm suggesting is to align our versioning scheme to match whats practised in Maven Echo system.
regards Ramith On Tue, Dec 10, 2013 at 1:42 AM, Manisha Gayathri <[email protected]> wrote: > Hi Ramith, > > When creating an application, a skeleton project is getting created with a > default version etc. Earlier the default version was created as > *<version>SNAPSHOT</version>* > > At this skeleton project if we do a mvn clean deploy it builds fine, but > with some warnings as follows: > [WARNING] Some problems were encountered while building the effective > model for org.wso2.af:app1:war:SNAPSHOT > [WARNING] 'version' uses an unsupported snapshot version format, should be > '*-SNAPSHOT' instead. @ line 7, column 12 > [WARNING] > [WARNING] It is highly recommended to fix these problems because they > threaten the stability of your build. > [WARNING] > [WARNING] For this reason, future Maven versions might no longer support > building such malformed projects. > > This has been reported by Chris in [1] as well. > To resolve this issue, I have added the string *default* as the version > of the skeleton project, which ultimately gets rid of the error. > > Also with regard to your comment on the version naming respective to the > environment, if the Dev and Test stages should have SNAPSHOT and the Prod > environment should get rid of the SNAPSOHT part, then internally the > version names should be changed at the promotion type, isn't it? > > [1]. https://wso2.org/jira/browse/APPFAC-720 > > Thanks > Manisha > > > On Mon, Dec 9, 2013 at 12:01 PM, Ramith Jayasinghe <[email protected]>wrote: > >> Shouldn't it be like: >> trunk-SNAPSHOT ? >> >> according to: >> >> http://stackoverflow.com/questions/5901378/what-exactly-is-a-maven-snapshot-and-why-do-we-need-it >> >> http://books.sonatype.com/mvnref-book/reference/pom-relationships-sect-pom-syntax.html >> http://www.tutorialspoint.com/maven/maven_snapshots.htm >> >> >> And to me it seems we are not really adhering the version-ing standards >> practised in maven world. >> For example: >> having a the final name of deploy-able artifact with 'SNAPSHOT' makes >> sense for dev, test stages, while 'Production' should not have that. >> For example, imagine the web application 'myapp' with version '2.0.0'. >> Then in my opinion it should be deployed with following names: >> >> Dev Stage : myapp-2.0.0-SNAPSHOT.war >> Test Stage : myapp-2.0.0-SNAPSHOT.war >> Production Stage : myapp-2.0.0.war >> >> Idea here is that, when in {Dev,Test} the version 2.0.0 is not released ( >> hence its a snapshot), and when it hits the production it can be considered >> as released (hence not a snapshot). >> >> Thoughts ? >> >> >> >> >> >> >> >> >> >> On Mon, Dec 9, 2013 at 11:38 AM, Janaka Ranabahu <[email protected]> wrote: >> >>> Hi Manjula, >>> >>> Could not recall the exact reason but have seen this in the commit log. >>> >>> @Manisha, >>> Would you be able to add some insight into this. >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> >>> *Log:changing the trunk's version from SNAPSHOT to default-SNAPSHOT to >>> avoid warnings Modified: >>> >>> carbon/platform/branches/4.1.0/products/appfactory/1.0.0/vmware/appfactory_deployment/resources/appfactory.xml >>> Modified: >>> carbon/platform/branches/4.1.0/products/appfactory/1.0.0/vmware/appfactory_deployment/resources/appfactory.xml >>> URL: >>> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.1.0/products/appfactory/1.0.0/vmware/appfactory_deployment/resources/appfactory.xml?rev=178038&r1=178037&r2=178038&view=diff >>> <http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.1.0/products/appfactory/1.0.0/vmware/appfactory_deployment/resources/appfactory.xml?rev=178038&r1=178037&r2=178038&view=diff> >>> ============================================================================== >>> --- >>> carbon/platform/branches/4.1.0/products/appfactory/1.0.0/vmware/appfactory_deployment/resources/appfactory.xml >>> (original) +++ >>> carbon/platform/branches/4.1.0/products/appfactory/1.0.0/vmware/appfactory_deployment/resources/appfactory.xml >>> Thu Jul 11 20:52:34 2013 @@ -463,7 +463,7 @@ <Property >>> name="Description">Web Application Archive file</Property> >>> <Property name="BuildJobTemplate">maven</Property> <Property >>> name="MavenArcheTypeRequest">-DarchetypeGroupId=org.wso2.carbon.appfactory.maven.webapparchetype >>> - -DarchetypeArtifactId=webapp-archetype >>> -DarchetypeVersion=1.0.0 -DgroupId=org.wso2.af >>> <http://org.wso2.af/> -Dversion=SNAPSHOT -DinteractiveMode=false + >>> -DarchetypeArtifactId=webapp-archetype -DarchetypeVersion=1.0.0 >>> -DgroupId=org.wso2.af >>> <http://org.wso2.af/> -Dversion=default-SNAPSHOT -DinteractiveMode=false >>> -DarchetypeCatalog=local </Property>* >>> >>> Thanks, >>> Janaka >>> >>> >>> On Mon, Dec 9, 2013 at 11:31 AM, Manjula Rathnayake >>> <[email protected]>wrote: >>> >>>> Hi all, >>>> >>>> Noticed below version in pom.xml. >>>> >>>> <groupId>org.wso2.af</groupId> >>>> <artifactId>foo</artifactId> >>>> * <version>default-SNAPSHOT</version>* >>>> <packaging>war</packaging> >>>> <name>foo</name> >>>> >>>> thank you. >>>> >>>> -- >>>> Manjula Rathnayaka >>>> Software Engineer >>>> WSO2, Inc. >>>> Mobile:+94 77 743 1987 >>>> >>> >>> >>> >>> -- >>> *Janaka Ranabahu* >>> Senior Software Engineer; WSO2 Inc.; http://wso2.com >>> >>> >>> * E-mail: [email protected] <http://wso2.com>**M: **+94 718370861 >>> <%2B94%20718370861>* >>> >>> Lean . Enterprise . Middleware >>> >> >> >> >> -- >> Ramith Jayasinghe >> Technical Lead >> WSO2 Inc., http://wso2.com >> lean.enterprise.middleware >> >> E: [email protected] >> P: +94 776715671 >> >> > > > -- > ~Regards > *Manisha Eleperuma* > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > > *blog: http://manisha-eleperuma.blogspot.com/ > <http://manisha-eleperuma.blogspot.com/>* > > -- Ramith Jayasinghe Technical Lead WSO2 Inc., http://wso2.com lean.enterprise.middleware E: [email protected] P: +94 776715671
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
