Hi all, Agree, We need to fix this. I am looking into this issue, with another issue where first request to a non loaded tenant, CarbonContext appname is not populated.
thank you. ---------- Forwarded message ---------- From: Janaka Ranabahu <[email protected]> Date: Thu, Dec 12, 2013 at 8:54 AM Subject: Re: Review and apply patch To: Ajanthan Balachandran <[email protected]> Cc: Manjula Rathnayake <[email protected]>, Shiroshica Kulatilake < [email protected]>, Dimuthu Leelarathne <[email protected]> Ajanthan, Manjula, Then it is a bug in the CC which must be fixed. Using a deprecated API method is not the solution. We need to check and identify whether we are using the correct dependencies and if so, then we must tell the Carbon team to fix this bug. Thanks, Janaka On Wed, Dec 11, 2013 at 9:49 PM, Ajanthan Balachandran <[email protected]>wrote: > She already raised concern about the issue.This was introduced by > manjulaR for purpose.As he explained in the code review some time > CarbonContext.getThreadLocalCarbonContext().getUsername() gives null > but at the same time CarbonContext.getCurrentContext().getUsername() > gives a valid username. > > On Wed, Dec 11, 2013 at 9:43 PM, Janaka Ranabahu <[email protected]> wrote: > > Hi Shiro, > > > > I have committed the patches in revision 193084. But the "currentUser = > > CarbonContext.getCurrentContext().getUsername();" in app_common.patch is > > wrong. We have deprecated that API and now it should be only > > "CarbonContext.getThreadLocalCarbonContext().getUsername();". Please > correct > > this. > > > > Thanks, > > Janaka > > > > > > On Wed, Dec 11, 2013 at 6:05 PM, Shiroshica Kulatilake <[email protected]> > > wrote: > >> > >> Hi, > >> > >> Please review and apply the patches mentioned in the last comment. > >> > >> https://wso2.org/jira/browse/APPFAC-1686 > >> > >> Thank you, > >> Shiro > >> > >> -- > >> Shiroshica Kulatilake > >> > >> Architect, > >> WSO2, Inc. http://wso2.com/ > >> Phone: +94 776523867 > > > > > > > > > > -- > > Janaka Ranabahu > > Senior Software Engineer; WSO2 Inc.; http://wso2.com > > > > E-mail: [email protected] > > M: +94 718370861 > > > > Lean . Enterprise . Middleware > > > > -- > ajanthan > -- > Ajanthan Balachandiran > Senior Software Engineer; > Solutions Technologies Team ;WSO2, Inc.; http://wso2.com/ > > email: [email protected]; cell: +94775581497 > blog: http://bkayts.blogspot.com/ > > Lean . Enterprise . Middleware > -- *Janaka Ranabahu* Senior Software Engineer; WSO2 Inc.; http://wso2.com * E-mail: [email protected] <http://wso2.com>**M: **+94 718370861 <%2B94%20718370861>* Lean . Enterprise . Middleware -- Manjula Rathnayaka Software Engineer WSO2, Inc. Mobile:+94 77 743 1987
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
