Hi Suho, I'm sorry to point out this issue at this stage but I think you need to provide two separate patches as follows.
1. First patch with original source code without any modification just to bring WSDL4J code under our source repo. 2. Separate patch only with your modification. If we combine above two into one patch we will never can identify what are the original code and what are the changes you have done etc. Thanks ! On Mon, Mar 24, 2014 at 1:56 PM, Sriskandarajah Suhothayan <[email protected]>wrote: > Thanks > Suho > > > On Mon, Mar 24, 2014 at 11:01 AM, Manoj Kumara <[email protected]> wrote: > >> Hi, >> >> I commented out that because it was referring to older version pom file. >> >> Corrected the version and added the fix with 198916. Sorry about the >> trouble. >> >> Thanks, >> Manoj >> >> >> *Manoj Kumara* >> Software Engineer >> WSO2 Inc. http://wso2.com/ >> *lean.enterprise.middleware* >> Mobile: +94713448188 >> >> >> On Sun, Mar 23, 2014 at 10:24 PM, Sriskandarajah Suhothayan < >> [email protected]> wrote: >> >>> I found the patch was not properly applied, where due to some reason the >>> parent element of the wsdl4j orbit has been commented out. >>> >>> >>> carbon/kernel/branches/4.2.0/patches/patch0006/dependencies/orbit/wsdl4j/1.6.2.wso2v4/pom.xml >>> >>> + <!--<parent>--> >>> + <!--<groupId>org.wso2.carbon</groupId>--> >>> + <!--<artifactId>carbon-kernel-dependents</artifactId>--> >>> + <!--<version>4.0.0</version>--> >>> + <!--<relativePath>../../../pom.xml</relativePath>--> >>> + <!--</parent>--> >>> >>> please reapply the patch correctly >>> >>> Thanks >>> Suho >>> >>> >>> On Sun, Mar 23, 2014 at 9:41 PM, Manoj Kumara <[email protected]> wrote: >>> >>>> Reverting this with r198904 due to build unstable on service stubs. >>>> Please have a look. >>>> >>>> Thanks, >>>> Manoj >>>> >>>> >>>> *Manoj Kumara* >>>> Software Engineer >>>> WSO2 Inc. http://wso2.com/ >>>> *lean.enterprise.middleware* >>>> Mobile: +94713448188 >>>> >>>> >>>> On Fri, Mar 21, 2014 at 5:14 PM, Sriskandarajah Suhothayan < >>>> [email protected]> wrote: >>>> >>>>> Thanks >>>>> >>>>> Suho >>>>> >>>>> >>>>> On Fri, Mar 21, 2014 at 5:06 PM, Manoj Kumara <[email protected]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Added to committed to patch0006 with r198836. >>>>>> >>>>>> Thanks, >>>>>> Manoj >>>>>> >>>>>> >>>>>> *Manoj Kumara* >>>>>> Software Engineer >>>>>> WSO2 Inc. http://wso2.com/ >>>>>> *lean.enterprise.middleware* >>>>>> Mobile: +94713448188 >>>>>> >>>>>> >>>>>> On Fri, Mar 21, 2014 at 4:39 PM, Sriskandarajah Suhothayan < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> There are no API changes from wsdl4j 1.6.2 to 1.6.3. Hence there >>>>>>> wont be any compatibility issues >>>>>>> >>>>>>> Suho >>>>>>> >>>>>>> >>>>>>> On Fri, Mar 21, 2014 at 3:04 PM, Manoj Kumara <[email protected]>wrote: >>>>>>> >>>>>>>> Hi Suho, >>>>>>>> >>>>>>>> Since this is an dependency version upgrade there can be API >>>>>>>> changes on the new version. Since the patch need to be compatible with >>>>>>>> all >>>>>>>> the 4.2.0 released products can you please check for any possible case. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Manoj >>>>>>>> >>>>>>>> >>>>>>>> *Manoj Kumara* >>>>>>>> Software Engineer >>>>>>>> WSO2 Inc. http://wso2.com/ >>>>>>>> *lean.enterprise.middleware* >>>>>>>> Mobile: +94713448188 >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Mar 21, 2014 at 2:34 PM, Sriskandarajah Suhothayan < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Adding_wsdl4J_fixes_to_the_kernel.patch contains all of them >>>>>>>>> >>>>>>>>> Suho >>>>>>>>> >>>>>>>>> >>>>>>>>> On Fri, Mar 21, 2014 at 1:59 PM, Manoj Kumara <[email protected]>wrote: >>>>>>>>> >>>>>>>>>> Hi Suho, >>>>>>>>>> >>>>>>>>>> Can you please attach only the diff relevant to your change plus >>>>>>>>>> changes on bin.xml. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Manoj >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> *Manoj Kumara* >>>>>>>>>> Software Engineer >>>>>>>>>> WSO2 Inc. http://wso2.com/ >>>>>>>>>> *lean.enterprise.middleware* >>>>>>>>>> Mobile: +94713448188 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Mar 21, 2014 at 12:50 PM, Sriskandarajah Suhothayan < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Please commit the path to resolve $Subject[1] >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> Suho >>>>>>>>>>> >>>>>>>>>>> [1]https://wso2.org/jira/browse/CARBON-14742 >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> *S. Suhothayan* >>>>>>>>>>> Associate Technical Lead, >>>>>>>>>>> *WSO2 Inc. *http://wso2.com >>>>>>>>>>> * <http://wso2.com/>* >>>>>>>>>>> lean . enterprise . middleware >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: >>>>>>>>>>> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/> >>>>>>>>>>> twitter: >>>>>>>>>>> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | >>>>>>>>>>> linked-in: >>>>>>>>>>> http://lk.linkedin.com/in/suhothayan >>>>>>>>>>> <http://lk.linkedin.com/in/suhothayan>* >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> *S. Suhothayan* >>>>>>>>> Associate Technical Lead, >>>>>>>>> *WSO2 Inc. *http://wso2.com >>>>>>>>> * <http://wso2.com/>* >>>>>>>>> lean . enterprise . middleware >>>>>>>>> >>>>>>>>> >>>>>>>>> *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: >>>>>>>>> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/> >>>>>>>>> twitter: >>>>>>>>> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | >>>>>>>>> linked-in: >>>>>>>>> http://lk.linkedin.com/in/suhothayan >>>>>>>>> <http://lk.linkedin.com/in/suhothayan>* >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> *S. Suhothayan* >>>>>>> Associate Technical Lead, >>>>>>> *WSO2 Inc. *http://wso2.com >>>>>>> * <http://wso2.com/>* >>>>>>> lean . enterprise . middleware >>>>>>> >>>>>>> >>>>>>> *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: >>>>>>> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/> >>>>>>> twitter: >>>>>>> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | >>>>>>> linked-in: >>>>>>> http://lk.linkedin.com/in/suhothayan >>>>>>> <http://lk.linkedin.com/in/suhothayan>* >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> *S. Suhothayan* >>>>> Associate Technical Lead, >>>>> *WSO2 Inc. *http://wso2.com >>>>> * <http://wso2.com/>* >>>>> lean . enterprise . middleware >>>>> >>>>> >>>>> *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: >>>>> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/> twitter: >>>>> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: >>>>> http://lk.linkedin.com/in/suhothayan >>>>> <http://lk.linkedin.com/in/suhothayan>* >>>>> >>>>> >>>> >>> >>> >>> -- >>> >>> *S. Suhothayan* >>> Associate Technical Lead, >>> *WSO2 Inc. *http://wso2.com >>> * <http://wso2.com/>* >>> lean . enterprise . middleware >>> >>> >>> *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: >>> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/> twitter: >>> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: >>> http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>* >>> >>> >> > > > -- > > *S. Suhothayan* > Associate Technical Lead, > *WSO2 Inc. *http://wso2.com > * <http://wso2.com/>* > lean . enterprise . middleware > > > *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: > http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/>twitter: > http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: > http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>* > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
