On Tue, Mar 25, 2014 at 1:25 PM, Malaka Silva <[email protected]> wrote:
> Hi Sagara, > > This is tested locally and fix is ok. > > Following is the pull request that needs to be merged. > When it come to GitHub merging who ever the merger should run it locally or within team level repo/builder before merging that is the protocol and that's not happen here. There is no any value if we bring any build system/procedure unless we follow it in our day to day life. Any one does not follow the correct procedure will loose their merge rights. Can you explain why there is no team level repo for Synapse ? Thanks ! > > https://github.com/wso2-dev/wso2-axis2/pull/3 > > Best Regards, > Malaka > > > On Tue, Mar 25, 2014 at 12:50 PM, Sagara Gunathunga <[email protected]>wrote: > >> >> >> Further I can't find your team level Synapse repo here [1] according our >> procedure you should merge changes to team level repo first and once they >> stable and in Done-Done status then you can merge to organisational level >> repo. As this already violated our procedure please revert Synapse changes >> ASAP. >> >> [1] - https://github.com/wso2-dev >> >> Thanks ! >> >> >> >> On Tue, Mar 25, 2014 at 12:43 PM, Sagara Gunathunga <[email protected]>wrote: >> >>> >>> >>> This is not the right way to merge changes, if your project change >>> depend on some other changes on upstream projects then you should have >>> apply them first before applying to your own project. In this case before >>> you merge did you build Synapse locally with the patch ? >>> >>> Thanks ! >>> >>> >>> On Tue, Mar 25, 2014 at 12:19 PM, Vanjikumaran Sivajothy <[email protected] >>> > wrote: >>> >>>> Hi dev, >>>> >>>> Please merge the pull request for carbon axis2 [1], We are getting >>>> build breaks in synapse [2]. >>>> >>>> >>>> Thank you, >>>> Best Regards >>>> >>>> [1]https://github.com/wso2/wso2-axis2/pulls >>>> >>>> [2] >>>> https://github.com/wso2/wso2-synapse/commit/3ee3c726a496288a6aec18b614852e23bc1e3409 >>>> >>>> -- >>>> Sivajothy Vanjikumaran >>>> *Senior Software Engineer* >>>> *Integration Technologies Team* >>>> *WSO2 Inc. http://wso2.com <http://wso2.com/>* >>>> *Mobile:(+94)777219209* >>>> *Mobile USA:**(+1)918 813 2403* >>>> [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: >>>> Twitter] <https://twitter.com/vanjikumaran> [image: >>>> LinkedIn]<http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> >>>> [image: >>>> Blogger] <http://vanjikumaran.blogspot.com/> [image: >>>> SlideShare]<http://www.slideshare.net/vanjikumaran> >>>> >>>> This communication may contain privileged or other >>>> confidential information and is intended exclusively for the addressee/s. >>>> If you are not the intended recipient/s, or believe that you may >>>> have received this communication in error, please reply to the >>>> sender indicating that fact and delete the copy you received and in >>>> addition, you should not print, copy, re-transmit, disseminate, or >>>> otherwise use the information contained in this communication. >>>> Internet communications cannot be guaranteed to be timely, secure, error >>>> or virus-free. The sender does not accept liability for any errors >>>> or omissions >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Sagara Gunathunga >>> >>> Senior Technical Lead; WSO2, Inc.; http://wso2.com >>> V.P Apache Web Services; http://ws.apache.org/ >>> Linkedin; http://www.linkedin.com/in/ssagara >>> Blog ; http://ssagara.blogspot.com >>> >>> >> >> >> -- >> Sagara Gunathunga >> >> Senior Technical Lead; WSO2, Inc.; http://wso2.com >> V.P Apache Web Services; http://ws.apache.org/ >> Linkedin; http://www.linkedin.com/in/ssagara >> Blog ; http://ssagara.blogspot.com >> >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > Best Regards, > > Malaka Silva > Senior Tech Lead > M: +94 777 219 791 > Tel : 94 11 214 5345 > Fax :94 11 2145300 > Skype : malaka.sampath.silva > LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 > Blog : http://mrmalakasilva.blogspot.com/ > > WSO2, Inc. > lean . enterprise . middleware > http://www.wso2.com/ > http://www.wso2.com/about/team/malaka-silva/<http://wso2.com/about/team/malaka-silva/> > > Save a tree -Conserve nature & Save the world for your future. Print this > email only if it is absolutely necessary. > -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
