Hi, Following points were discussed in the code review for JMX Monitoring for human tasks.
1. Include necessary interface in project class hierarchy. 2. Format the code and add doc comments to necessary classes.(ex. DeployedTasksMXBean) 3. Rename DeplyedTasks>>HTTasksStatusMonitor 4. Rename DeployedTasksMXBean class methods with meaningful names showAllTaskDefinitions getInstanceForTaskDefinitions getInstanceListForTaskState getTaskInstanceDetails 5. Add log.error to to display error messages 6. Null and empty check when get all tasks 7. Add license text for each class . 8. Find what is the best way to get tenant ids 9. Go through all the code and remove the unnecessary codes 10. Rename methods in HTQueryBuildHelperImpl class getTaskInstanceCountByState 11. Fix the Camel notation in declaring variables 12. Null check for task name 13. Add missing states in HtQueryCriteria class 14. Change the logic of separate task name over task definition and task instance using regex 15. Use Lists for Arrays 16. For UI need some jsp pages -- Regards, Waruna Lakshitha Jayaweera Software Engineer WSO2 Inc; http://wso2.com phone: +94713255198
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
