Few questions: 1. How much of an effect you get by this startup delay (I mean in seconds)? What will be the advantage of stoping this theme being copied? We know, once in production, we do not restart servers frequently. Even if we do so, there should be other servers to handle the traffic. So, if we take down an instance for maintenance, it shouldn't matter how long it takes to start IMO. 2. Does the theme-mgt bundle really needed for products now? This was useful when deployed in StratosLive. But do people really care about this? What we can gain from this feature is a very minimal change of the theme.
And I forgot to ask, what is the real problem you are trying to solve with this. You have mentioned the cause and the fix only. On Sun, Apr 20, 2014 at 12:09 PM, Eranda Sooriyabandara <[email protected]>wrote: > Hi Azeez, > I agree that it shouldn't be added to the carbon.xml, but at the current > moment we don't have a place to keep this value. Shall we go ahead with > this solution for C4 until we fix it properly in C5? > > thanks > Eranda > > > On Sat, Apr 19, 2014 at 8:31 PM, Afkham Azeez <[email protected]> wrote: > >> I don't like the idea of adding random stuff into the carbon.xml file. >> Anyway, with C5, we will not allow such things. So there should be a >> different way of getting this value. >> >> >> On Sat, Apr 19, 2014 at 5:03 AM, Eranda Sooriyabandara >> <[email protected]>wrote: >> >>> Hi All, >>> Currently we are loading super tenant themes to the registry in each >>> server startup, when the themes-mgt bundle start. Since this involves >>> registry calls this cause considerable startup delay. So here we are >>> proposing a configuration which we can enable to stop loading themes. >>> >>> Here is the configuration which we will be adding to the carbon.xml >>> >>> <ReloadThemes>true</ReloadThemes> >>> >>> There can be several cases, >>> >>> 1. Configuration is not in carbon.xml - This will consider this >>> configuration value as true and will reload the themes every time start >>> the >>> server >>> 2. Configuration value true - This will reload the themes every time >>> start the server >>> 3. Configuration value false - This will stop updating the themes >>> in registry every time start the server >>> 4. Configuration value other than true/false - This will consider >>> this configuration value as false and won't reload the themes. >>> 5. Theme not in the registry - If the theme which is in the file >>> system is not there in the registry, it will ignore the ReloadThemes >>> configuration value and add that theme to registry. >>> >>> Thoughts? >>> Patch attached. >>> >>> thanks >>> Eranda >>> >>> -- >>> >>> *Eranda Sooriyabandara *Senior Software Engineer; >>> Integration Technologies Team; >>> WSO2 Inc.; http://wso2.com >>> Lean . Enterprise . Middleware >>> >>> E-mail: eranda AT wso2.com >>> Mobile: +94 716 472 816 >>> Linked-In: http://www.linkedin.com/in/erandasooriyabandara >>> Blog: http://emsooriyabandara.blogspot.com/ >>> >>> >>> >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>* >> *email: **[email protected]* <[email protected]> >> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: * >> *http://blog.afkham.org* <http://blog.afkham.org> >> *twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >> * linked-in: **http://lk.linkedin.com/in/afkhamazeez >> <http://lk.linkedin.com/in/afkhamazeez>* >> >> >> *Lean . Enterprise . Middleware* >> > > > > -- > > *Eranda Sooriyabandara*Senior Software Engineer; > Integration Technologies Team; > WSO2 Inc.; http://wso2.com > Lean . Enterprise . Middleware > > E-mail: eranda AT wso2.com > Mobile: +94 716 472 816 > Linked-In: http://www.linkedin.com/in/erandasooriyabandara > Blog: http://emsooriyabandara.blogspot.com/ > > > > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Amila Maharachchi* Senior Technical Lead WSO2, Inc.; http://wso2.com Blog: http://maharachchi.blogspot.com Mobile: +94719371446
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
