Hi
On Thu, Apr 24, 2014 at 3:49 PM, Amani Soysa <[email protected]> wrote: > > > > On Thu, Apr 24, 2014 at 3:33 PM, Reka Thirunavukkarasu <[email protected]>wrote: > >> Hi >> >> >> On Thu, Apr 24, 2014 at 3:12 PM, Amani Soysa <[email protected]> wrote: >> >>> >>> >>> >>> On Thu, Apr 24, 2014 at 1:27 PM, Dimuthu Leelarathne >>> <[email protected]>wrote: >>> >>>> Hi Amani, >>>> >>>> >>>> On Thu, Apr 24, 2014 at 12:29 PM, Amani Soysa <[email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> We (Sagara,AmilaM and Amani) had an offline discussion on having URL >>>>> Mapper functionality in Appserver, and these are the things we discussed. >>>>> >>>>> Since AF need the feature to do url mapping for web app's we have done >>>>> some modifications to the old URL Mapper Component and we are going to >>>>> make >>>>> URL Mapper available for Appserver. We will not ship URL Mapper feature by >>>>> default with Appserver as there will be a major performance hit if we >>>>> check >>>>> URL mapping for every request. Therefore, we decided to have URL Mapper as >>>>> a separate feature and install it as we need. Also we need to add this >>>>> feature in our Appserver test plan and documentation. >>>>> >>>>> >>>> Could we ship this by default and make it active only by configuration? >>>> >>> >>> Yes we can do it .. we can have a configuration property in Carbon.xml >>> to enable/disable URL Mapper and make sure there will not be any >>> performance hit when URL Mapper is disabled. >>> >> >> We already had the validation in the relevant Tomcat valves not to affect >> the standalone AS with the url-mapper . But not sure, anything got changed >> over the time. We have to verify it.. >> > > Hi Reka, > > Well according to TenantLazyLoaderValve.java[1] we have two checks to get > from cache and also we check whether it's a virtual host request. This can > have a performance hit. > > //getting actual uri when accessing a virtual host through url mapping > from the Map > String uriOfVirtualHost = > URLMappingHolder.getInstance().getApplicationFromUrlMapping(requestedHostName); > //getting the host name of first request from registry if & only > if the request contains url-mapper suffix > if(TomcatUtil.isVirtualHostRequest(requestedHostName) && > uriOfVirtualHost == null) { > uriOfVirtualHost = DataHolder.getHotUpdateService(). > getApplicationContextForHost(requestedHostName); > } > > if(uriOfVirtualHost != null) { > requestURI = uriOfVirtualHost; > } > Yah..That's true. This needs to be fixed with the lazy loading in the tenant mode, as it will affect the performance of tenant requests. Thanks, Reka > > [1] - > https://svn.wso2.org/repos/wso2/carbon/platform/branches/turing/components/webapp-mgt/org.wso2.carbon.webapp.mgt/4.2.0/src/main/java/org/wso2/carbon/webapp/mgt/TenantLazyLoaderValve.java > > Regards, > Amani > >> >> Thanks, >> Reka >> >>> >>>> thanks, >>>> dimuthu >>>> >>>> >>>>> At the moment we are ONLY supporting URL Mapper functionality to >>>>> webapps (JSP apps and jaggery Apps) we do not support for Services,JaxRS >>>>> and JAXWS ect. So when implementing URL Mapper functionality from >>>>> Appfactory side we have to make sure we block it for other apps. >>>>> >>>>> >>>>> Amila, Sagara please add anything if I have missed. >>>>> >>>>> Regards, >>>>> Amani >>>>> >>>>> >>>>> -- >>>>> Amani Soysa >>>>> Associate Technical Lead >>>>> Mobile: +94772325528 >>>>> WSO2, Inc. | http://wso2.com/ >>>>> Lean . Enterprise . Middleware >>>>> >>>> >>>> >>>> >>>> -- >>>> Dimuthu Leelarathne >>>> Architect & Product Lead of App Factory >>>> >>>> WSO2, Inc. (http://wso2.com) >>>> email: [email protected] >>>> Mobile : 0773661935 >>>> >>>> Lean . Enterprise . Middleware >>>> >>> >>> >>> >>> -- >>> Amani Soysa >>> Associate Technical Lead >>> Mobile: +94772325528 >>> WSO2, Inc. | http://wso2.com/ >>> Lean . Enterprise . Middleware >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Reka Thirunavukkarasu >> Software Engineer, >> WSO2, Inc.:http://wso2.com, >> Mobile: +94776442007 >> >> >> > > > -- > Amani Soysa > Associate Technical Lead > Mobile: +94772325528 > WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > -- Reka Thirunavukkarasu Software Engineer, WSO2, Inc.:http://wso2.com, Mobile: +94776442007
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
