+1 for having it enabled by default. In the current implementation, if andes client cannot deliver a message to the server over a given period of time (this is configurable) once flow control is activated, then it throws an exception and closes the connection so there won't be any message accumulation beyond that point. This prevents any unnecessary memory build-ups at the client side due to flow controlling.
After an offline chat had with Srinath, it was decided that we can also monitor the queues in which the data gets buffered at client-side and do the same as done in the previous step, as well. In all aforementioned instances, we should ship the feature with proper defaults. Cheers, Prabath On Wed, May 7, 2014 at 7:48 PM, Srinath Perera <[email protected]> wrote: > I think it should be on by default. If load is low, it will never kick in. > > If it has any adverse effect, that has to be fixed anyway. > > --Srinath > > > On Tue, May 6, 2014 at 3:32 PM, Asanka Vithanage <[email protected]> wrote: > >> Hi All, >> >> With MB 220 we are going to introduce a new feature to flow control the >> publisher. Currently by default MB pack comes with enabling that feature. >> >> But AFAIU flow control requires only on systems which expose to high >> message loads.for such systems we could enable the Flow control feature as >> required. >> >> So don't it a good idea to disable flow control on default pack and allow >> users to select whether they required flow control? >> >> WDYT? >> >> >> >> -- >> Asanka Vithanage >> Senior Software Engineer -QA >> Mobile: +94 0716286708 >> Email: [email protected] >> WSO2 Inc. www.wso2.com >> >> > > > -- > ============================ > Srinath Perera, Ph.D. > Director, Research, WSO2 Inc. > Visiting Faculty, University of Moratuwa > Member, Apache Software Foundation > Research Scientist, Lanka Software Foundation > Blog: http://srinathsview.blogspot.com/ > Photos: http://www.flickr.com/photos/hemapani/ > Phone: 0772360902 > -- Prabath Abeysekara Associate Technical Lead, Data TG. WSO2 Inc. Email: [email protected] Mobile: +94774171471
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
