Hi All, During the code review, first we check the demonstration and Upul demonstrated the follow of the Http connector tool.
Basically tool is capable of creating the wso2 ESB connector artifact based on the swagger description. For a very first version of the tool, Upul has covered all the essential functionalist. During the code review we informed flowing facts. *Minor concerns and suggestion* 1) Naming convention for some classes need to rename tand suggestiono make more meaningful way. 2) Need to ad proper copy right statement and the licence. 3) Code need to move to carbon-mediation. 4 Connector Arch type and naming convention 5) normalize the pom. *Major Concerns **and suggestion* 1) Documentation need to be completed with meaningful example 2) Sample with Twitter. 3) Make use of Template serializer instant of DOM to crate the xml files *Limitations* 1) Currently this tool only support for application/json. 2) Authentication should handled separately. 3) Current system does not support for optional parameter adding. *Good to have in future.* ------------------------------ 1) Solve the Limitations 2) Create tool to generate swagger description based on UI configuration. 3) Image upload facility to Incorporate the icons and banners. If i missed anything please free to add into the review note On Wed, Jul 2, 2014 at 11:35 AM, Kasun Indrasiri <[email protected]> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=ZG40ajRlODcxbmJuaDB2YzZtNGVraTAyam8gdmFuamlAd3NvMi5jb20&tok=MTQja2FzdW5Ad3NvMi5jb20wNjYxNTA5Yjc5ZGQ4ZmJmYTc1YjcxNGMzNmM5MjQ1NGY5YzViZTRi&ctz=Asia/Colombo&hl=en> > [Code Review] ESB - HTTP Connector Generator > *When* > Wed Jul 2, 2014 1:30pm – 2:30pm Colombo > *Video call* > https://plus.google.com/hangouts/_/wso2.com/code-review-esb > <https://plus.google.com/hangouts/_/wso2.com/code-review-esb?hceid=a2FzdW5Ad3NvMi5jb20.dn4j4e871nbnh0vc6m4eki02jo> > *Calendar* > [email protected] > *Who* > • > Kasun Indrasiri - organizer > • > Jeewantha Dharmaparakrama > • > Isuru Udana > • > Upul Bandara > • > Chanaka Fernando > • > Shafreen Anfar > • > Malaka Silva > • > Ravi Undupitiya > • > [email protected] > • > Dushan Abeyruwan > • > Miyuru Wanninayaka > • > Ishan Jayawardena > • > Vanjikumaran Sivajothy > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=ZG40ajRlODcxbmJuaDB2YzZtNGVraTAyam8gdmFuamlAd3NvMi5jb20&rst=1&tok=MTQja2FzdW5Ad3NvMi5jb20wNjYxNTA5Yjc5ZGQ4ZmJmYTc1YjcxNGMzNmM5MjQ1NGY5YzViZTRi&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=ZG40ajRlODcxbmJuaDB2YzZtNGVraTAyam8gdmFuamlAd3NvMi5jb20&rst=3&tok=MTQja2FzdW5Ad3NvMi5jb20wNjYxNTA5Yjc5ZGQ4ZmJmYTc1YjcxNGMzNmM5MjQ1NGY5YzViZTRi&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=ZG40ajRlODcxbmJuaDB2YzZtNGVraTAyam8gdmFuamlAd3NvMi5jb20&rst=2&tok=MTQja2FzdW5Ad3NvMi5jb20wNjYxNTA5Yjc5ZGQ4ZmJmYTc1YjcxNGMzNmM5MjQ1NGY5YzViZTRi&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=ZG40ajRlODcxbmJuaDB2YzZtNGVraTAyam8gdmFuamlAd3NvMi5jb20&tok=MTQja2FzdW5Ad3NvMi5jb20wNjYxNTA5Yjc5ZGQ4ZmJmYTc1YjcxNGMzNmM5MjQ1NGY5YzViZTRi&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Sivajothy Vanjikumaran *Senior Software Engineer* *Integration Technologies Team* *WSO2 Inc. http://wso2.com <http://wso2.com/>* *Mobile:(+94)777219209* [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: Twitter] <https://twitter.com/vanjikumaran> [image: LinkedIn] <http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> [image: Blogger] <http://vanjikumaran.blogspot.com/> [image: SlideShare] <http://www.slideshare.net/vanjikumaran> This communication may contain privileged or other confidential information and is intended exclusively for the addressee/s. If you are not the intended recipient/s, or believe that you may have received this communication in error, please reply to the sender indicating that fact and delete the copy you received and in addition, you should not print, copy, re-transmit, disseminate, or otherwise use the information contained in this communication. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. The sender does not accept liability for any errors or omissions
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
