Hi, Please find the code review comments listed below.
1. Put the content in the file which has the list of datasource files (i.e. dataSource-info .xml) to the artifact.xml file it self and change the code accordingly. 2. Put the licensing content to the top of the newly introduced classes. 3. javadoc comments should be endedup with . 4. Remove registry related stuff (ex. resources) 5. Remove DatasourceConfig class as the dataSource-info.xml file will be removed. 6. Throw exceptions accordingly rather than logging. 7. Brake down large methods to small methods rather than putting everything into one method. Thanks On Mon, Jun 30, 2014 at 9:27 AM, Rajith Vitharana <[email protected]> wrote: > more details » > <https://www.google.com/calendar/event?action=VIEW&eid=aGF2OXFnM2NwcGtudDg3OW0ycG91ajE5YmcgY2hhbmlrYUB3c28yLmNvbQ&tok=MTYjcmFqaXRodkB3c28yLmNvbTY3YjAxNGIxZTE1MzNjYzQ0NGRlYjIwMjE2ZTQ5ZDhkYzIyNWU1YTE&ctz=Asia/Colombo&hl=en> > Data source deployer feature code review > Code review for Data source deployer feature > *When* > Tue Jul 1, 2014 3pm – 4pm Colombo > *Where* > LK 3rd Floor Meeting Room - Tungsten (map > <http://maps.google.lk/maps?q=LK+3rd+Floor+Meeting+Room+-+Tungsten&hl=en>) > *Video call* > https://plus.google.com/hangouts/_/wso2.com/data-source > <https://plus.google.com/hangouts/_/wso2.com/data-source?hceid=cmFqaXRodkB3c28yLmNvbQ.hav9qg3cppknt879m2pouj19bg> > *Calendar* > [email protected] > *Who* > • > Rajith Vitharana - organizer > • > Malith Dhanushka > • > Dunith Dhanushka > • > Gokul Balakrishnan > • > Jaminda Batuwangala > • > Inosh Goonewardena > • > Gihan Anuruddha > • > [email protected] > • > Anjana Fernando > • > Chanika Geeganage > > Going? *Yes > <https://www.google.com/calendar/event?action=RESPOND&eid=aGF2OXFnM2NwcGtudDg3OW0ycG91ajE5YmcgY2hhbmlrYUB3c28yLmNvbQ&rst=1&tok=MTYjcmFqaXRodkB3c28yLmNvbTY3YjAxNGIxZTE1MzNjYzQ0NGRlYjIwMjE2ZTQ5ZDhkYzIyNWU1YTE&ctz=Asia/Colombo&hl=en> > - Maybe > <https://www.google.com/calendar/event?action=RESPOND&eid=aGF2OXFnM2NwcGtudDg3OW0ycG91ajE5YmcgY2hhbmlrYUB3c28yLmNvbQ&rst=3&tok=MTYjcmFqaXRodkB3c28yLmNvbTY3YjAxNGIxZTE1MzNjYzQ0NGRlYjIwMjE2ZTQ5ZDhkYzIyNWU1YTE&ctz=Asia/Colombo&hl=en> > - No > <https://www.google.com/calendar/event?action=RESPOND&eid=aGF2OXFnM2NwcGtudDg3OW0ycG91ajE5YmcgY2hhbmlrYUB3c28yLmNvbQ&rst=2&tok=MTYjcmFqaXRodkB3c28yLmNvbTY3YjAxNGIxZTE1MzNjYzQ0NGRlYjIwMjE2ZTQ5ZDhkYzIyNWU1YTE&ctz=Asia/Colombo&hl=en>* > more options » > <https://www.google.com/calendar/event?action=VIEW&eid=aGF2OXFnM2NwcGtudDg3OW0ycG91ajE5YmcgY2hhbmlrYUB3c28yLmNvbQ&tok=MTYjcmFqaXRodkB3c28yLmNvbTY3YjAxNGIxZTE1MzNjYzQ0NGRlYjIwMjE2ZTQ5ZDhkYzIyNWU1YTE&ctz=Asia/Colombo&hl=en> > > Invitation from Google Calendar <https://www.google.com/calendar/> > > You are receiving this email at the account [email protected] because you > are subscribed for invitations on calendar [email protected]. > > To stop receiving these notifications, please log in to > https://www.google.com/calendar/ and change your notification settings > for this calendar. > -- Best Regards.. Chanika Geeganage Software Engineer WSO2, Inc.; http://wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
